Received-SPF: pass (google.com: domain of linux-kernel+bounces-131893-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 4 Apr 2024 10:35:44 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>, Dan Williams
	<dan.j.williams@intel.com>
CC: Kwangjin Ko <kwangjin.ko@sk.com>, <dave@stgolabs.net>,
	<dave.jiang@intel.com>, <alison.schofield@intel.com>,
	<vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel_team@skhynix.com>
Subject: Re: [PATCH v2 1/1] cxl/core: Fix initialization of mbox_cmd.size_out
 in get event
Message-ID: <660ee4f023cd7_7702a294d0@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240402081404.1106-1-kwangjin.ko@sk.com>
 <20240402081404.1106-2-kwangjin.ko@sk.com>
 <660d6d64a50bd_7702a29466@dwillia2-xfh.jf.intel.com.notmuch>
 <20240404143049.00005635@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240404143049.00005635@Huawei.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LO1v4/oJl+yY8jGvwKYlgo1VpWFIojLi61NMxxV24WKDEnVoVYPUUBy6TqIZ?=
 =?us-ascii?Q?o3kVO8VkeVBOjebeaEQ6Jgq86oKEOmNAODNw/MVMIf8R/7+OmLWhvGIn4I6o?=
 =?us-ascii?Q?bA4hLW0OpRWaUmz1/DLj8P6iCvq1VEu9tKNuTqhHXTDNaUyhIQLlm1zCRdKy?=
 =?us-ascii?Q?OhYPqGPNWxjcmaSoxGA0e5KirYwrMnON/XOBHjTPo6+R3/KpYP8RWp+uuOBh?=
 =?us-ascii?Q?JURNMIfI9idwPLMvLvdDr+Ahj3f1qtYQkgL27DPybunPiIAtpU1AdF0E/fEx?=
 =?us-ascii?Q?aZjG/NK+rR/tSLEh8qJc4ybO16bH1+KNsI6I8RiLfgJvUd6Hp7aA4oFjoCbR?=
 =?us-ascii?Q?kEuXrJDEtZ9FKKIjytZfCnAHQ06kttcyRi1kiY53NIAOajKpZyx+ZY5drkAz?=
 =?us-ascii?Q?4BPENHn9sCF0yh6aDju29hYxNZeEZr1QW41FpzJt42U3MlyRsEeEDsOrh/jd?=
 =?us-ascii?Q?L+ZTeRqzPDXtIsFEabxPk7d//vMsrtijMewDDfqUiKM3tIU0CVq4fWUFhiIw?=
 =?us-ascii?Q?HisPXVH3HkSzgE6l+X6GidHao7NN+taA4jMJUX9kesHWSqbcSq9kwjwtx00m?=
 =?us-ascii?Q?d5WgirlVaJw1UyTtKHtqSJ0ipb1DCPMh0BKplKAbvLWvv6/ExuAaVq58+jW6?=
 =?us-ascii?Q?4NCARkdPmoKO1qBGMzyzeAEyvUXZEbpmfjNlXyVyoVp7rVB2+KiMStlWU/ql?=
 =?us-ascii?Q?BEIqzGXU9P235encRg6tk6SFXEV+fbrHZeegHFLwZqSn6IBOC1s4tpgyr/TF?=
 =?us-ascii?Q?KhibkOkTwxcC4whC8447YC4FZpG4Rc9qRas/FbKYKcbPgmYx6zbOO52B7UO+?=
 =?us-ascii?Q?x8KHbJ9c1DD+HLzJBsCgn5QWtYu1TUDQObs8LETDE462FVsp3KRSVVm1+BZm?=
 =?us-ascii?Q?Y2wbf85Mcsu78cMJt/nh+IGQKZXxx0P/3JHyOqH6VMkdSy26VBwsZ00GM2lf?=
 =?us-ascii?Q?DM8/HyuzomimN3qny+CS6ONNa8n5qo/Bfng+AllSBiBNKQNzfBJ5K88gsziy?=
 =?us-ascii?Q?UxKppAkPaKjz+5ZUyuSOyyMemFNilqRJCF1NjuEkZw3GE8UOzcV++BcKY1HG?=
 =?us-ascii?Q?3u0recYmDaIfDEt3KKuUL5KU7suaMhq/d6GvyEgzywz9z19Anx6vXYVHLKy+?=
 =?us-ascii?Q?TAbXYZbk6dFH24NHWAHF2lD3dw78sgqxR7WsS4BweG8CMDv1CQA4oOI+9ZoY?=
 =?us-ascii?Q?whqM2aQxC0Oh7cNikuA/dyhyIOcMTG5yUGKB2k4Ytp15re2FCCWNoWySBBhL?=
 =?us-ascii?Q?BieMc6ATS/EiPDZ6q8zEknw5t85ihR0PB2RV0A9XbGV4T4tZ/izcWIdR11RK?=
 =?us-ascii?Q?xVwzcSpuunLjzZ676GMZ0mipA+Gb7zHzId7ryonKRragrFvyguS+W08opU+j?=
 =?us-ascii?Q?hTffFJWTF9l4wf9sSAkRztCko2EjPAa+PMQUjBJ5UhoFj9ga8MyY5Q/WFeZZ?=
 =?us-ascii?Q?uwixHObvo9ttkyR0eBAXqV4IJ0ffnAVouMbio+Vza1TxYwTO9LEzvmATugD4?=
 =?us-ascii?Q?Q3VvEXTUccVVuYzhMlG6YqttKy1BRV/dg4/wyBPBh6esqNnSTmOpsC4AmnWZ?=
 =?us-ascii?Q?Q6EQLlo/6hn273H33KQbaSbbJNH5HAFRyEaiqpGk1I5Iwo++ufjPQj9xPVSU?=
 =?us-ascii?Q?aA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bee57d38-2f7c-47b9-cb4d-08dc54cda944
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 17:35:46.6790
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iH6i57JZgk5yr3KFDQEQT+l2XBqaTRxRPsj0CpCPS4/try9W8dG3KeD0FheT8ywyXwyyOy9kGSe2m7nguDYghf3IsQRjhoB+tP0GtrQZV4c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8067
X-OriginatorOrg: intel.com

Jonathan Cameron wrote:
[..]
> > 
> > Fix looks correct, but I am concerned it is a band-aid for a more
> > general problem. For example, if I am not mistaken, we have a similar
> > bug in cxl_mem_get_poison().
> > 
> > So perhaps a convention to always define @mbox_cmd immediately before
> > cxl_internal_send_cmd() like this:
> 
> Makes sense to me.  These aren't hot paths, so safe code is worth the
> possible extra writes.

Yeah, the before and after size wise is small:

   text	   data	    bss	    dec	    hex	filename
  15407	   2129	     49	  17585	   44b1	drivers/cxl/core/mbox.o

   text	   data	    bss	    dec	    hex	filename
  15461	   2129	     49	  17639	   44e7	drivers/cxl/core/mbox.o

..which I think is worth the peace of mind, and it matches what is
currently done in cxl_xfer_log()

I will send a follow on with this since this patch is already in
cxl-fixes.