Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp209491lqp; Thu, 4 Apr 2024 10:48:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUd7HLZr4EDj7de4SKz3wC+CQGoUL6SSvm5MUT1u9zFHUzvfYUHrXcTq5uOywUn7ohBTf9nVwKyb9CIlM791BwRntc/MFK4kqrYekjCoQ== X-Google-Smtp-Source: AGHT+IHlQyCQB4zC9Wc2pYa1EebF7CFmw07ibXo7n+4tZNkCRwqS4RgH4gYt09rQiE9HhEq3/N0u X-Received: by 2002:a05:6402:241c:b0:56d:fbe4:aeba with SMTP id t28-20020a056402241c00b0056dfbe4aebamr167261eda.21.1712252915673; Thu, 04 Apr 2024 10:48:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712252915; cv=pass; d=google.com; s=arc-20160816; b=qzyibQ/TRwQ/lR28XCZbMItht6+7otKqEcpVEbwW4jx5L8BF/bjmSr9AkUpCz35/xK 1Qi9DTrbVLOTpFL25/hsMmoHJ8SwAGA62u/drgA7HjQLRhqUeRvEmuR2FfmPegNYZbBV AtY75ZNB9DMwzwbgR00UPvrGAERekwjdAALjetrWGDGLminAqmDTnXPJNXtL8xiL4Dmn xGSDj3MmbmY3ZBs3swStGLCrBnw/tvrpKgThzflSAwCGqjSmvL1O6e5Adhw1WRDmQtn6 c1RAUNcEb9qIgbw0e36HBdxhadGnbdFtVM3aJRyocEnMghQ7W9EY39KaY284p1iqKrPR v/8A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=KY5NyprwqnUz5XuA9Kl5z+7VSecMAoWLl/z+MUE9h3s=; fh=EZBtaYJCXbD8AUTMU7SfeO9+PXj+40tJSEIZOplhnw8=; b=tYdvZbDeeOPipTIUM7iaW1zft1io44HLfIetFKcYUH77qHFm6FrfIBo5pt2OiyBi8y bNbyvtrB3k3pXIx8L3D77PvJ4j84uwkmE82Ike3QpI2BIxO4aa+bRD3JNcLf92KbitqH Mc9M2eLc4jVoOvjYiMRkCL/cwZo8cmLjOgp2fS01fHVye/k8KaiHHr4qjuy2mrknbYee dhGf7Y8fOlThlMvZ2uUxBhnpOt8B9o7Rav9A5C/vYfhesFu+DuTSRhNdM6dayMadoPLA FifIcrzSAr2z7qXIPhRRbSEBfRGM1XIJ9LzWXdCPtXa05vfbkUblxovvgpYV/zFvWMIT uEcA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=OIRMCtj3; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linuxfoundation.org dmarc=pass fromdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-131908-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-131908-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id v20-20020a50a454000000b0056e07eae2e8si1764308edb.285.2024.04.04.10.48.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 10:48:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-131908-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=OIRMCtj3; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linuxfoundation.org dmarc=pass fromdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-131908-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-131908-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6418F1F292C5 for ; Thu, 4 Apr 2024 17:48:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 95CF812EBDC; Thu, 4 Apr 2024 17:48:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OIRMCtj3" Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD4BA12CD9C for ; Thu, 4 Apr 2024 17:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712252908; cv=none; b=fl3Z8HIu9uEbePVtx5h1qv/liT9YfMbV9IGAozebyKBW5OVEnt6KF1teWY8k8eehl/9ZYhQCnAyMbIv8/peq8lR4bSVn/Zc/bKU7GfpFlgn2QQfWTts9ZyTQpgQmLlGexU27/X3grJ82OuKawGmIi6t5Ykic6CF2d47AS2FPdB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712252908; c=relaxed/simple; bh=3cSbmZrjAfQIrrTlLR0hOFNu/HfpV2pnoC7RSDEECic=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uPko5QaziNFZvxo1LbJ/0geXUldhQ+2smXSChGald93pJCIOQEzSjsHT/IViD/+x4nJy2dr+QoN9TqWDfzsRpt4CTlX/t/o4j7V6R3oFH+Xmo5/V1lwkifUPLRr6Dz4QUiJuZq4gWDDEpxMSjpZHvvthADKIbunilTWcTsl07sA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OIRMCtj3; arc=none smtp.client-ip=209.85.166.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-7cc5e664d52so27086439f.0 for ; Thu, 04 Apr 2024 10:48:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1712252906; x=1712857706; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KY5NyprwqnUz5XuA9Kl5z+7VSecMAoWLl/z+MUE9h3s=; b=OIRMCtj3/kGO/7uP4JL/ySFZnoCc7BiSL1RmL+60eii00FJKxt/6hS97g4YyrSLfyq kOCg5j4O5+diKaawE3BZOS05l+Sn7hX6GxIShiU/ZXPyYttcZ8eP9vIG9h9xi/evHRC7 3WG8+n19o5WhvobuxmqQZVfvj1ADdIjhjdGag= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712252906; x=1712857706; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KY5NyprwqnUz5XuA9Kl5z+7VSecMAoWLl/z+MUE9h3s=; b=GqMnE/PPsUefIhmbG7VvR8nbu378OC5bsEQlvkvNh17gWM3bjfzxpQ8OJUpDJoaqGn scthmSQmkfrCritBMazyPLQWjQ2XHl86JYRx1dvfz17HlgP9GXCSp6cF01bzPfgMpkML cvD+DiiljyuDN8e6ElAGuye0VAx1Ou4xG8NfUJDTLHBeg7kxmXE1jay88qsPZ48tknRV 4wk4oNbqlOgD82LXvcn2f/XHPILePlEMfVg+wP2g3h2sSWVX6Pm3v6wpk23J2WOECfq9 dtuP+M+lYBkC4wHf+eiu5EjBQiC1d1MCkakY7gk6mo74mRvcQuGlpsh/VnXk/yuy33De DsKg== X-Forwarded-Encrypted: i=1; AJvYcCVV9oUea8olm/3K4aIIgfxkaxv0WnsK5sEl7HFWcsqECYkN1MAtmqDNP+cHzZAFWAOl+3xpppb7DAL5TRuPAGVysuJc3XI5hG+3oYUI X-Gm-Message-State: AOJu0YzKqtuJe6G/wNCGExr8UkbTkf96+FgMp+WgngygnFcBoNiFc/ZS F9BLi+e0jMjwO9mNZqt3Zz2R/JyuANMoYsXILxV5gj3wLfFRWHrCkh1f7EH6mwI= X-Received: by 2002:a92:cc4a:0:b0:369:b728:583c with SMTP id t10-20020a92cc4a000000b00369b728583cmr3556416ilq.3.1712252905984; Thu, 04 Apr 2024 10:48:25 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id he21-20020a0566386d1500b0047f1a41f958sm1238024jab.56.2024.04.04.10.48.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 10:48:25 -0700 (PDT) Message-ID: <9a2b6f33-451b-4cb3-ad6b-be87b4c03a94@linuxfoundation.org> Date: Thu, 4 Apr 2024 11:48:25 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] selftests: add ksft_exit_fail_perror() To: Muhammad Usama Anjum , Eric Biederman , Kees Cook , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan Cc: kernel@collabora.com References: <20240404161433.114497-1-usama.anjum@collabora.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240404161433.114497-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/4/24 10:14, Muhammad Usama Anjum wrote: > In this series, ksft_exit_fail_perror() is being added which is helper > function on top of ksft_exit_fail_msg(). It prints errno and its string > form always. After writing and porting several kselftests, I've found > out that most of times ksft_exit_fail_msg() isn't useful if errno value > isn't printed. The ksft_exit_fail_perror() provides a convenient way to > always print errno when its used. > > Muhammad Usama Anjum (2): > selftests: add ksft_exit_fail_perror()> selftests: exec: Use new ksft_exit_fail_perror() helper > > tools/testing/selftests/exec/recursion-depth.c | 10 +++++----- > tools/testing/selftests/kselftest.h | 14 ++++++++++++++ > 2 files changed, 19 insertions(+), 5 deletions(-) > Applied the two patches to linux-kselftest next for Linux 6.10-rc1. thanks, -- Shuah