Received-SPF: pass (google.com: domain of linux-kernel+bounces-131966-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b2fb5b9f-ea5d-4dc6-8c42-cd14c90eaa08@amd.com>
Date: Thu, 4 Apr 2024 13:35:07 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [RFC PATCH v3 07/17] x86/resctrl: Add support to enable/disable
 ABMC feature
To: Peter Newman <peternewman@google.com>
Cc: corbet@lwn.net, fenghua.yu@intel.com, reinette.chatre@intel.com,
 tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 paulmck@kernel.org, rdunlap@infradead.org, tj@kernel.org,
 peterz@infradead.org, yanjiewtw@gmail.com, kim.phillips@amd.com,
 lukas.bulwahn@gmail.com, seanjc@google.com, jmattson@google.com,
 leitao@debian.org, jpoimboe@kernel.org, rick.p.edgecombe@intel.com,
 kirill.shutemov@linux.intel.com, jithu.joseph@intel.com,
 kai.huang@intel.com, kan.liang@linux.intel.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com, sandipan.das@amd.com,
 ilpo.jarvinen@linux.intel.com, maciej.wieczor-retman@intel.com,
 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, eranian@google.com,
 james.morse@arm.com
References: <cover.1711674410.git.babu.moger@amd.com>
 <0db75c94886da62b8da498ef159d8fe27b0b3811.1711674410.git.babu.moger@amd.com>
 <CALPaoCgRtYLnzpkL6uVjb+LvBbxD8ANRuzACP1UQ=rkzk8TCqg@mail.gmail.com>
 <a7e7f220-99f2-465f-bc36-aadccb891190@amd.com>
 <CALPaoChsU-C6fhjfLFEmxCXCdY-0PL-Hk4pHYs=TZ9PN6UFexw@mail.gmail.com>
Content-Language: en-US
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <CALPaoChsU-C6fhjfLFEmxCXCdY-0PL-Hk4pHYs=TZ9PN6UFexw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YmF0WUpVQ3VOWVFSWFQ2SFhTSHJIYXlKQmFEWm1GenAwRXVrakR2aFRWKzdi?=
 =?utf-8?B?Y01RZWhQZXBnRWpMWmxSZ1kremtuRFhZb1cyRnBKM0JPNldHMTlET3NwSkgz?=
 =?utf-8?B?NSsrN1ZuV283TFVvN2I1VThCbWZUVUUxNkNVdS9mcmlleUkybVdxb0xaN0ZH?=
 =?utf-8?B?VDNzL3JodmFPNlpZUitibzlVT3FQWlFuTUR6aExLUWdHbTZEbk5sL2ptcmtF?=
 =?utf-8?B?ck9PUW1VcG5jNUx3VDFESXhCVzQ4WlZIWVF1NFVEeDlxazBBK09RK3RFQ1RO?=
 =?utf-8?B?dEE4Ynp1RmRSdVVFSUE3Mis4M2RXZFRJY003Yk5VQnc1SmVsSmV5dzBReit5?=
 =?utf-8?B?cFhQdmk4K0FQcDd4WkRkRlBDcFJ3eGU2ZlpSRmlkVDZKRWgxbzBQWHllc2ZV?=
 =?utf-8?B?TGFZUml3bFV1ZVFubVY1VytCbmRpVFNheTM0VTZGa3MyaThjbEQ0d3p3YmZW?=
 =?utf-8?B?VGo4ZkZyT3Q2SUZnSlhxN0psNndTSDhuN0VrUVR5QWdFZkU4NmppODI2L3Iw?=
 =?utf-8?B?L3JHVXFmQldVek1iRjUwMTVvMkJTenJIdUZlOTM2UUJGWVJxamNtRUJwZ0ll?=
 =?utf-8?B?YXRKek9JRWtneGgxb1B1MG9IMlJxRmRZQUNtRHkybFJ3WlFtZDhTNkQ0UGlp?=
 =?utf-8?B?bzRWdFFDK1F6V3AyeXZMaXZ0NGJCNlNmTFRHa0NRYmR4SjhDSTdaZE1Xbk80?=
 =?utf-8?B?azdHZDNQTERUejBDMjduMjVBbnJxVk5Wa1IxWXdpZXlZWUNmVTJXL1ZJcml5?=
 =?utf-8?B?cXJnRVZUbElCcVFlZkhoMnlmZXNJQ29GeWFVREtXYi9wa1BaR2JxRU5mcnN5?=
 =?utf-8?B?QXlwUHNIendJQTd4TXVTZVBONU5wREVVZUp4UzVhZDRKcVdRcHBoOXhQK2Fi?=
 =?utf-8?B?Q2phdjBxNThlbWY4SU9RM09ab3J2eDVmUHR1UDE3TEtaNGV1enhKeWFHMnZU?=
 =?utf-8?B?b3QwOHBBNkZ5S0dKMHZsZm9BZndWd1RzL3AreVpNaWVPM1JWTjlXYUFzc3VP?=
 =?utf-8?B?dnNKa3NZdTRISys1ZFlLWGkyOXU3dFZhaHpvQ2FlcWVLL0lFMlNjS1VLSGEw?=
 =?utf-8?B?YUhzSVFJcExmczk5eGZiM1d0YlhRYStaM3phejJHMnZHNktUem1xOU5rUExz?=
 =?utf-8?B?OWhsWVc5MGlDUFNYWU95U0RYNEFKMTI1a2JKL2pYM1oyOTFQc2RqRzVxY2JM?=
 =?utf-8?B?SWxSNWFkT0k0SDV4OVQ0c3E5RXhLTExlVzN0OE5FRkNaTGk1eDlEZzRIeG1x?=
 =?utf-8?B?SVRQMUw2aUVaY3orVnR4MTJkRlEyRnZ2THd4TU5ZMjliNi9kYU9SZm5aZHBo?=
 =?utf-8?B?Q295T2lxZmd5OUxpdEc4MmZoZ09YcG4vdzlnSlVjR0dXbHk2NU9xdCtGWHF0?=
 =?utf-8?B?NTZzcVhpSHJqUlhzSE1WMGJwZ21YQ3dtaktQL3MrZVlxZS9kbHZDa1U0ajVP?=
 =?utf-8?B?Q3lHTnk3cXhDWlZ6VXZOWWtGQ1A4aWlRYzVsS1BXa3J0V0lITXBBSGVZRHB1?=
 =?utf-8?B?QkIrMmtqRmdNUDd2M2E0Yzk0WTZxdUJiM2kwL2gxZDYrVUgvYkY2WjlabVhz?=
 =?utf-8?B?TE0wR1NLME9tOFdpSVlhRE1LS1cvZjBTcFYySnFkMUxCTGlpSnpadHJkQ0ty?=
 =?utf-8?B?UmQwMnR2d1pFLytrRUF3SVdMc2pFTWZYOFR4UTFCbUNJLytlZjM4MStiMDYy?=
 =?utf-8?B?WS9FcHpSbVNOMTlZbVpzcVptY3lBcS9QRlJJSUpyd1VNU2hoMGVzUEJrb3Jy?=
 =?utf-8?B?MEc1VFQzWWNmRGpIMEFDckNUbmlGcSs1MG5rdm9ma29Vd2pWNFhNQWNaVTRp?=
 =?utf-8?B?Y3BOazFBb3crM21TL3pkenNMeXdVL3BmbkdVdWJtaWVkUzNzWnFlL1JDMG9t?=
 =?utf-8?B?VStxeDdTRTZXLzlYSnp6UnRQOFFORmJiaW1WbUlKajBVU3A4bzI1ZkNsU2k2?=
 =?utf-8?B?NlNkU3d3L1ZoOFpyZW1SdCtuUmNIWXpxZXlhMEJULzMxQlg5d1J6cm9lUVdp?=
 =?utf-8?B?TlRkMUNKTzdObnNtVGJ4TEs3L2RhY05SVTNBMWhieHFqcHA5dy9ybXozSE9P?=
 =?utf-8?B?RjNwMGltZldIRTByQXlSd3hjaStYUkdQZmZ2L2RUa1FsdlRpUVluWGFLUExu?=
 =?utf-8?Q?Rpec=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07ba6ab7-ad75-420f-dec9-08dc54d5f691
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 18:35:12.2733
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +y6o9/g+Pj8R2eWUFXXspYk+Goyq57Vn/A5FSNKLDxCd0Oo++yDPLDnSJ0ylcsZd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8719

Hi Peter,

On 4/4/24 12:36, Peter Newman wrote:
> Hi Babu,
> 
> On Thu, Apr 4, 2024 at 8:16 AM Moger, Babu <babu.moger@amd.com> wrote:
> 
>> On 4/3/24 19:30, Peter Newman wrote:
>>> This looks like it would move to fs/resctrl/rdtgroup.c where it's not
>>> possible to dereference an rdt_hw_resource struct.
>>>
>>> It might be helpful to try building your changes on top of James's
>>> change[1] to get an idea of how this would fit in post-refactoring.
>>> I'll stop pointing out inconsistencies with his portability scheme
>>> now.
>>
>> Considering the complexity of James changes, I was hoping my series will
>> go first. It would be difficult for me to make changes based on transient
>> patch series. I would think it would be best to base the patches based on
>> tip/master.
> 
> I don't need you to push the patches to the mailing list based on
> James's series. I was just asking you to try building locally on top
> of the refactoring changes. You are putting in the effort trying to
> make this code portable (i.e., inventing new
> resctrl_arch_-interfaces), so it would be sensible to check your work
> locally.

I am really no focusing much on  portability in this series.
I named it to match it with resctrl_arch_set_cdp_enabled.
Yes. I got your concerns. I will plan check against James changes in next
revision.

> 
> However, I am the main stakeholder who cares about MPAM and ABMC
> working in the same kernel, so I can continue to give feedback on
> portability as I compose the series' together.

Agree. Please continue your feedback.
-- 
Thanks
Babu Moger