Received-SPF: pass (google.com: domain of linux-kernel+bounces-132007-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240401141031.3106216-1-peng.fan@oss.nxp.com>
 <CACRpkdZAuNXGyg2wwYcQG4oO9w7jPS6vj4Vt0=kqX5fJ+QpNmw@mail.gmail.com> <Zg7dwcFz5eD7Am2u@smile.fi.intel.com>
In-Reply-To: <Zg7dwcFz5eD7Am2u@smile.fi.intel.com>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Thu, 4 Apr 2024 21:03:02 +0200
Message-ID: <CACRpkdYLqO1XGMiWuGhZoM5wn8T7kFOvJ9LkiUp9W6zPufiP0w@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: pinconf-generic: check error value EOPNOTSUPP
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, brgl@bgdev.pl, linux-gpio@vger.kernel.org, 
	linux-kernel@vger.kernel.org, cristian.marussi@arm.com, sudeep.holla@arm.com, 
	Peng Fan <peng.fan@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 4, 2024 at 7:05=E2=80=AFPM Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
> On Thu, Apr 04, 2024 at 01:44:50PM +0200, Linus Walleij wrote:
> > On Mon, Apr 1, 2024 at 4:02=E2=80=AFPM Peng Fan (OSS) <peng.fan@oss.nxp=
com> wrote:
> >
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > The SCMI error value SCMI_ERR_SUPPORT maps to linux error value
> > > '-EOPNOTSUPP', so when dump configs, need check the error value
> > > EOPNOTSUPP, otherwise there will be log "ERROR READING CONFIG SETTING=
".
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > (...)
> > >                         ret =3D pin_config_get_for_pin(pctldev, pin, =
&config);
> > >                 /* These are legal errors */
> > > -               if (ret =3D=3D -EINVAL || ret =3D=3D -ENOTSUPP)
> > > +               if (ret =3D=3D -EINVAL || ret =3D=3D -ENOTSUPP || ret=
 =3D=3D -EOPNOTSUPP)
> >
> > TBH it's a bit odd to call an in-kernel API such as pin_config_get_for_=
pin()
> > and get -EOPNOTSUPP back. But it's not like I care a lot, so patch appl=
ied.
>
> Hmm... I would like actually to get this being consistent. The documentat=
ion
> explicitly says that in-kernel APIs uses Linux error code and not POSIX o=
ne.
>
> This check opens a Pandora box.
>
> FWIW, it just like dozen or so drivers that needs to be fixed, I prefer t=
o
> have them being moved to ENOTSUPP, rather this patch.

Andy is one of the wisest men I know so I have taken out the patch.

Peng, what about fixing the problem at its source? Patch away,
we will help you if need be.

Yours,
Linus Walleij