Received: by 2002:a05:7208:c24f:b0:81:d631:dc8 with SMTP id w15csp396882rbd; Thu, 4 Apr 2024 12:31:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVZuU4y4rgNXQ28MGy8+aBBsQ4oaDj1A0gyWnAK41f5T+De3nwqL/l2myT70/awAQNVJnZNFVAGDd2Mjipydrr2LZY9/0adoRIsuBl+Ag== X-Google-Smtp-Source: AGHT+IFfvWsbRdo3mMHTcl46Kk3RJ4BAEI0+hmQOjybK2W9mDKmB/dW57RIkFwaN/D99JO2Npfib X-Received: by 2002:a05:6820:1904:b0:5a7:c784:bfd0 with SMTP id bk4-20020a056820190400b005a7c784bfd0mr3769060oob.0.1712259060297; Thu, 04 Apr 2024 12:31:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712259060; cv=pass; d=google.com; s=arc-20160816; b=kdP+61rHj5o8N/J50SP8sE6f3jbr/jVTfK+PpdmdSG5nMBTz1Zqmyq19b4We+9i1JI Me+zH9aHCdCLWZkzyULDmy7u4tl8dMAxejwvMXM7GNZGqDX0tjbsZN1xQuUJtrUv5ifZ 0Bbr5PJ8xjE4MIl4huk4CYYCh/WPyUnl/vl+8HQuDpvl+6jhk+ir14vBxskbXV6R3j+D GqYb/47YQBuMEC7x/AD4TpFr8NZRHpmB5e98pj5W9A4A4dNyt0IRcP8FxVCEq5FnQMnd Y74WDO+eoGa9sxNR0u0zRoLDFKAG3+msLKRE86m2PkQHcY8rwAf3FQoPQuYXCUutETM7 9X+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=3fjf6rtzI7r/gGfnWwsdDNFZRhN01nHhVtY9EOEP8yI=; fh=4UmD1yFGRo0MRMWxR5cGs0rHZazPICwTBH0c0TcPKTI=; b=kMvAjCHQeTRTnf1YzIzQp7F3ex1Fl7mxXG7VM6UxgfcpbcH+JhTs2o6X6yee3DJokH LdmeP3sXRC4eeJ3Kgo/ghvWEOeN867UEG8m8I8ju6SbqlQPk9sRsNmSd1r/86Im7u/iN RE8Yoh3Pt/ESpsp6Q7fZxtDh2lrDglouxHY2gdmM4mukzRGapQfYU0h1nBKGDRMKKfJD JFNaz7ixeY8WZOBmJKXHQ7uXHJSdsWei9LEjULC6qIXuNFey4RJpiMlbR7HMpggcmgk+ GywJtSbEgheUwkA2kG3H5ZzptjHU6HG9Nfb28GXfVWjRA4eD6wZPv4FJkYJlOQwf0k6r b4/A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SVTctHKB; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-132041-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132041-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id o9-20020ac85a49000000b0043130f48de1si11311qta.233.2024.04.04.12.31.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 12:31:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-132041-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SVTctHKB; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-132041-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132041-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2A1671C281B2 for ; Thu, 4 Apr 2024 19:30:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0827C134416; Thu, 4 Apr 2024 19:30:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SVTctHKB" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7378913440C for ; Thu, 4 Apr 2024 19:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712259044; cv=none; b=kfgy6AuRA1YlSTBiHYJm8Yxy4biYsqkeLi0qossp+ThzTxQADKLC42N6y0oYpaPZkTDaLD3HWuyiSYnafOio0pXLVvK+XnQQu5HHb61KjK1QCT5fIeaexhcoQEawvb35DML3+a9SbDCn7NngqoRVyTXtd4Kyz7clWDhue+nbHng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712259044; c=relaxed/simple; bh=SrhCNdxzuBp3aZhSeTOGPH4YcHlLvWylC9ihFXpRUIE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tY32kRXyQ7YN8LDyWblcSGcVtOUsl3cSyQcjo0PtIUos4uTKTA5oYn4bBdSSOV9UW11va/gtH9Lg3ysHorLdFv4mYFOZSd+iwMBc5huyQuI/HmIMafv5h6A+PYa63OMtS9JaDmonWPB3ZqlWW0XooymazYtAp6vok7xtQZhszhg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SVTctHKB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712259041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3fjf6rtzI7r/gGfnWwsdDNFZRhN01nHhVtY9EOEP8yI=; b=SVTctHKBAVwniIcny2W6mh77G3VEZKYYLZz6jFD1tesj21qHcZK2j1dfGJBxe5pO/XMrsz WZScEe+gYl9GdK+qeTJBkV9bK7p1CDskJvdsdsT+I9mdKN508CcpPrF20eoLSEetGKDj6Y OC2reYBFhr6HZp+jH0iBd0pJT2zxllk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-0PLgC1HZPqa-h-RXJrlSFA-1; Thu, 04 Apr 2024 15:30:39 -0400 X-MC-Unique: 0PLgC1HZPqa-h-RXJrlSFA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-343da0a889dso130813f8f.0 for ; Thu, 04 Apr 2024 12:30:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712259038; x=1712863838; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3fjf6rtzI7r/gGfnWwsdDNFZRhN01nHhVtY9EOEP8yI=; b=blOHxEbrwxJIIzOhEBKedCvmVfMCA7lYhhqKaki+gBdJllTtcFe81neSkeGFjAQKtQ mhAOdrgKUfZUSKGLEkMl1BoASBGWE8i3sVmMb7eJDaf+tyP1JYewr+UtTIN8zbt5f2+f esiDERwigS+IVSXV+IeCNqVVtakKto64yPjkMwT8ZUPB57wHxPyG555p2oH/+tKYQHe0 mlT9UJo2J5HBxt7Kyl8MPP0b64eRKlgXM2QQ8SJ8exDC8rtyJO2JQyEzPexwAvQ3aDUW 0oJUCLQ62Q2FJga1FbSNGsrT0JCR4xHnnu7IsJ7P69Ms8iBYqnk+nIXcf4VZy/OWswh6 pVZQ== X-Forwarded-Encrypted: i=1; AJvYcCVDModMnDB6D5z1p5PGe0vJOX+sg3GLKwleAY3WM+N/2HXCtaBDx1E8epxJodbEZokUigWyzcxtOsPA1s4ybkqJwATMEfMhpsHWDS9V X-Gm-Message-State: AOJu0YxWpbf/O1xb8qm7pK4iHOl41dboToPY/V99Gp7AzzksFMNXgzrD 6tcFUlcaej0EAk2JEGCioHx/ByBAbgTqcNyesevHTzR9A4uysqyRyuDruqG0f6xWAo8Or0l8e9v 0JcLTrOHvEm1isS6dlVLWJKI5U7b4aAWD9burvHF4+X51ib2uNS2zqveHjOeQFw== X-Received: by 2002:a05:6000:108f:b0:341:d7b5:27 with SMTP id y15-20020a056000108f00b00341d7b50027mr373783wrw.6.1712259038215; Thu, 04 Apr 2024 12:30:38 -0700 (PDT) X-Received: by 2002:a05:6000:108f:b0:341:d7b5:27 with SMTP id y15-20020a056000108f00b00341d7b50027mr373769wrw.6.1712259037812; Thu, 04 Apr 2024 12:30:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c743:de00:7030:120f:d1c9:4c3c? (p200300cbc743de007030120fd1c94c3c.dip0.t-ipconnect.de. [2003:cb:c743:de00:7030:120f:d1c9:4c3c]) by smtp.gmail.com with ESMTPSA id dr20-20020a5d5f94000000b0033ea499c645sm137664wrb.4.2024.04.04.12.30.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 12:30:37 -0700 (PDT) Message-ID: Date: Thu, 4 Apr 2024 21:30:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] mm: get_mm_counter() get the total memory usage of the process To: Chen Taotao , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240322151139.7417-1-chentt10@chinatelecom.cn> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240322151139.7417-1-chentt10@chinatelecom.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22.03.24 16:11, Chen Taotao wrote: > Currently, the get_mm_counter() function returns only the value of > the process memory counter percpu_counter ->count record, ignoring > the memory usage count maintained by each CPU in the > percpu_counter->counters array, which leads to an error in obtaining > the memory usage count of a process, especially when there are many > CPU cores. counts, especially when there are many CPU cores. > > It is now possible to have get_mm_counter() get the memory count of a > process by adding the memory counts maintained by each cpu, thus getting > an accurate memory count of the process. > > This patch is an unofficial version that simply fixes the above problem, > as I'm not sure if it makes sense to do so. What is the effective change? Do you have any real examples where we can observe a real difference, so it's worth the churn? On the other hand, doing the sum gets more expensive, do we care? How expensive is it? Such a discussion should ideally be part of this change log. "I'm not sure if it makes sense" -- you tell us, how did you come up with the idea? :) -- Cheers, David / dhildenb