Received-SPF: pass (google.com: domain of linux-kernel+bounces-132046-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <5f040ba2-627b-4b5d-959a-59f97b6ad0af@linux.intel.com>
Date: Thu, 4 Apr 2024 12:36:19 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] platform/x86: lg-laptop: fix %s null argument warning
To: Gergo Koteles <soyer@irl.hu>, Matan Ziv-Av <matan@svgalib.org>,
 Hans de Goede <hdegoede@redhat.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <33d40e976f08f82b9227d0ecae38c787fcc0c0b2.1712154684.git.soyer@irl.hu>
Content-Language: en-US
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
In-Reply-To: <33d40e976f08f82b9227d0ecae38c787fcc0c0b2.1712154684.git.soyer@irl.hu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 4/3/24 7:34 AM, Gergo Koteles wrote:
> W=1 warns about null argument to kprintf:
> warning: ‘%s’ directive argument is null [-Wformat-overflow=]
> pr_info("product: %s  year: %d\n", product, year);
>
> Use "unknown" instead of NULL.
>
> Signed-off-by: Gergo Koteles <soyer@irl.hu>
> ---

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

>  drivers/platform/x86/lg-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c
> index ad3c39e9e9f5..e714ee6298dd 100644
> --- a/drivers/platform/x86/lg-laptop.c
> +++ b/drivers/platform/x86/lg-laptop.c
> @@ -736,7 +736,7 @@ static int acpi_add(struct acpi_device *device)
>  		default:
>  			year = 2019;
>  		}
> -	pr_info("product: %s  year: %d\n", product, year);
> +	pr_info("product: %s  year: %d\n", product ?: "unknown", year);
>  
>  	if (year >= 2019)
>  		battery_limit_use_wmbb = 1;
>
> base-commit: 39cd87c4eb2b893354f3b850f916353f2658ae6f

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer