Received-SPF: pass (google.com: domain of linux-kernel+bounces-132048-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 4 Apr 2024 14:38:37 -0500
From: Colin Foster <colin.foster@in-advantage.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Lee Jones <lee@kernel.org>, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mfd: ocelot-spi: Use spi_sync_transfer()
Message-ID: <Zg8BvZbrwbi6uzLc@euler>
References: <7af920eb686b719cb7eb39c832e3ad414e0e1e1a.1712258667.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7af920eb686b719cb7eb39c832e3ad414e0e1e1a.1712258667.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?TwwKzI6TdwgmgSkNlHyhd7qC8GsNoU8wJqJ3Y5TQFAz/9hX76HCazF8F54Pz?=
 =?us-ascii?Q?YTtoXoRDXbqwbN8yDf0TV66Bx+IUMlQnYAzzo5OLqKeTytQZBj1D689uWbuy?=
 =?us-ascii?Q?sHg1FBpOt3kGIYIbICFonhkxmvpqh4NKCAueP/CqgOlNcw14dGl2l9ucYNnL?=
 =?us-ascii?Q?gDo94EGnu8SXwq6c4K+O+3AjFWzBI4e60MnV8b3wBOYBezE/vL6qdUlb+yNE?=
 =?us-ascii?Q?83TEf75kfJ+XyS9CKWkmFzcJkwO9yXbF7YdDhY6vxOG1f9zeTxtOpbtJGgjs?=
 =?us-ascii?Q?wuH703tWc2C18y/r4/fE0AjRWxARtZZ2WE5ELU7Bgg1MgJ0apmpoJq3v/M4T?=
 =?us-ascii?Q?86Wv6CMZ5YcGs3DIbY9H5qffSLlUMU0luVIieloEd/9T1hmE8kSNsh9kWdBc?=
 =?us-ascii?Q?RsbwdRtvjwDR07vWOL3Q0uGyccIR+RBj+HXgYWrW34kZfd5uI9uYa9MXT9oJ?=
 =?us-ascii?Q?q2c9oc2e8DKyMD/xg7BBHyYtrBVYCoupC2ec0v01Vu6bkAm0mgfhmpa3AhcW?=
 =?us-ascii?Q?susuAhhlh3GmCzwCaOuLBNW7eVcmQtNX17dgj2XvJup5oV1J14KQb5zHYFf7?=
 =?us-ascii?Q?MbycKnI8U6dr5jHhOSG4AQreKlULyH+tvTCP1pMAzhCAZ5FdcroeU3wmaEO+?=
 =?us-ascii?Q?69puOy4VoZmpcteFWrBf+ryY4c5BmSnS1zG33u1kMAH6/4O3EzJswv6C9x8/?=
 =?us-ascii?Q?ZR0fS/Wionwvz7H7Tb7C/tEsgX6dlm1YzBOqV52olxkxD/Q7kHAEdvThwD9s?=
 =?us-ascii?Q?syOMIZf0jef3fAgrDyx5dTAArb59EnJgWJiE84J05B9Yc6V13B2xk2tdJRZv?=
 =?us-ascii?Q?KZo8EeTAw0D7jh0gcWIHdFf0HTxw6oz+rGc7STx/mMy3OLMInwmV29lG3PG3?=
 =?us-ascii?Q?+1SJ/9z8ODEgaIxdHYwje27F+mMqyb+r++8SJG9CtJsyH5PdsnvpePVlxwX6?=
 =?us-ascii?Q?WTgv39Va8UyB2EXGNadXviqtu9lmzD44FR6jvb6Dl55WjGfZ1ZqObeS/bo7d?=
 =?us-ascii?Q?wdKeOUs3/9m9jIeYeYAPdPZMk4G3T6nWQZrMyoCdileZ1RaXeGtHQFf5x3s5?=
 =?us-ascii?Q?zqPGqT/jYVuXePWaTcpWu2+n7NipFiCo88WSVyM1tqZUIabak6xwvhvwLxG+?=
 =?us-ascii?Q?/8+SFi9AE28ywDW9VmBWKx0IxCTGIer0zSBE+FOpwx9hXy7sDnkE7qJ5MybZ?=
 =?us-ascii?Q?XSPHzj/SVNZP39cqkWmAHnU5CgT3GP/2MWQYGcJnPQ2ismuskbLccISLPtST?=
 =?us-ascii?Q?lsJFh5lRI1wz7mFp3bb3XZjIwJgIjfaYEel8s52NWeQPUU2pF81geUlDh2QY?=
 =?us-ascii?Q?hW+5OZjtMg1XWzq6i657ax646dQBcsXZB8gHP8GEo+mqWOcS0Vwg/hZB+Em5?=
 =?us-ascii?Q?DVzEifrTMu3yrFPcBWLi3GKaIR2oGGonbLDXdfsgQSPsgQ2nOjPYsYwJrVn2?=
 =?us-ascii?Q?u1QOqxNLerLzaOpS36fezZZ0S5hgmT22rkLZpwsV7INJirs4i3enEd1ab7lX?=
 =?us-ascii?Q?dc//Z5S7i2FfVLimFDf13K5LoUR03setpCoPm4+pNU829kzK1DsmzDq1zNbo?=
 =?us-ascii?Q?d8qBFyMcRksPkn16CduRQie7wfFVsVdA53lrlejHJJ33uR+NUxOOSIHHNCb4?=
 =?us-ascii?Q?Nw=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ad8fd30-5c13-49ac-edd5-08dc54ded451
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6974.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 19:38:40.3151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jee8yzdzx/iCDNmSLhA4fVlSBl3wjSBH3FQqeofIjE45g0ivPfNu/cmwG97B+w45h8DC9UyrbE5vxlLH68IDXNqEIrhoD2WQIqxc40jQh3s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5681

On Thu, Apr 04, 2024 at 09:25:09PM +0200, Christophe JAILLET wrote:
> Use spi_sync_transfer() instead of hand-writing it.
> It is less verbose.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/mfd/ocelot-spi.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/ocelot-spi.c b/drivers/mfd/ocelot-spi.c
> index 94f82677675b..b015c8683f1b 100644
> --- a/drivers/mfd/ocelot-spi.c
> +++ b/drivers/mfd/ocelot-spi.c
> @@ -145,7 +145,6 @@ static int ocelot_spi_regmap_bus_read(void *context, const void *reg, size_t reg
>  	struct device *dev = context;
>  	struct ocelot_ddata *ddata;
>  	struct spi_device *spi;
> -	struct spi_message msg;
>  	unsigned int index = 0;
>  
>  	ddata = dev_get_drvdata(dev);
> @@ -166,9 +165,7 @@ static int ocelot_spi_regmap_bus_read(void *context, const void *reg, size_t reg
>  	xfers[index].len = val_size;
>  	index++;
>  
> -	spi_message_init_with_transfers(&msg, xfers, index);
> -
> -	return spi_sync(spi, &msg);
> +	return spi_sync_transfer(spi, xfers, index);
>  }
>  

Thanks! I am fighting an unrelated SPI regression, so I tested against 6.7

Reviewed-by: Colin Foster <colin.foster@in-advantage.com>
Tested-by: Colin Foster <colin.foster@in-advantage.com>