Received: by 2002:a05:7208:c24f:b0:81:d631:dc8 with SMTP id w15csp409462rbd; Thu, 4 Apr 2024 13:01:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU3UnA4PyJkSTR/CI3Lx67jQ0qq90+QG8XeBmZ3MFnwUIzW9ZwbmF5fy3S6sEhHQz3ThoncPCGqHmoYkHfdh3jJDQLM+1Z35dh4drazeQ== X-Google-Smtp-Source: AGHT+IFrUo/CISGuSWaqyMe9r7AsY2lFoN/N9Vy9AlIxVrskrCNTl1++rrEHyy6UhNtJ6MgglKvQ X-Received: by 2002:a17:907:7249:b0:a4e:b3f:1dda with SMTP id ds9-20020a170907724900b00a4e0b3f1ddamr2921493ejc.74.1712260874221; Thu, 04 Apr 2024 13:01:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712260874; cv=pass; d=google.com; s=arc-20160816; b=GHs4W0aZMNrd2hNYL62tR8rNm/QyDh40HScVUN8ydujwOkMXpEI1fIDH/WWE2RjFl4 InmTw5Fw3MMs7MGpKPmJ5eesEXOXgA2ypiMYvRuTuEyDoeqo1V1Xiq7X48865yXPfJs/ dlOnC+/JUI/ucEh7nupZAkb7o/26c6BvhyiF75aLtCIVVqRz+1jKSOj2LMs8zXt+ewoR QCzeg7i2iTwB3lWfRQjfwT2XJtryPrsHUM0Tx642ggiP7I+tiI9R/a4diLxra7eIIZXi 6clNQqopJIy3luvKGjXtsnRfu51Mr4OMEzay1nDcVkCctsO3G7ENqueiStRl77vioHSw Q3nQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Tx0p2zm6YORQ9OO9+YoSesp8h6QYQafmH8Pydzbg9dA=; fh=NQtpIpYmOsnIbhkCOixpK4MaSOleio293cycynjavkY=; b=lJ5HN5OyOUjSmZpgL2O3F6MMQMraZXt7PBUF27fjG88GJfehdnXnu57Ad+eIgLulXF YCVO0kpwyo6icDQy3w3IB+0u8V9WMtYMkwRDpSqjRzjkUVo/1TUfDgcKG+VDx8UST/Rc /GzfN/lrUd1qbqqRPISLm/eF4pOluiyawoYrBVnW8mEU1AuWR+LHI3s+Ib8w7e0YUpPy AW6F4qgM+dLKrcO/IQF4CXzfYDOUSavFY8V8D3TGF6EFaHeTFpD36vnkQYjquQyIeIrh PaSBJPO/ZefAU93A6rOrKbD73oi0J4/StNIVRRbe4GNDP2Lg7XUcqs5zioOP8hc1UPsr Gmqg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=v3ZDjcx2; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-132069-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132069-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id o14-20020a17090608ce00b00a46d22a190csi7823140eje.819.2024.04.04.13.01.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 13:01:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-132069-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=v3ZDjcx2; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-132069-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132069-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id EA4251F25051 for ; Thu, 4 Apr 2024 20:01:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 599E3134CC2; Thu, 4 Apr 2024 20:01:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="v3ZDjcx2" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5705D134439 for ; Thu, 4 Apr 2024 20:01:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712260866; cv=none; b=ee07MmtxMnN8mpaF508yJKi2DbFnOwDaxbw4NJmjh9aJj0I+80oWGFuH0BNzC51Eage9S2/ZgSFgdTchhtJvC1xsdOuhLE9aFJPAUG85PDUlWVf7nAhtKLht6nsBGVrK8hbP7XTm+Q4lPQhHSMvnaLtIqPrz3sHRMHHGIjfXbfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712260866; c=relaxed/simple; bh=jDgRvDUXquf8+1TaLuMSDg9OKMhNKkoBxWlEmTKp85E=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=pQ3+up/+563YCIVNqIvbxvREZ8kjRBbdmlyCYWH0yHRS8PzukWJ72DeWnJCs7qXF+8P815jMG+8MhYJT5hSqbT/Myzo27OcFXKNP19khUMHusx41SksNnNTawOy3pQG4ufNPXWh07TmOW2jE+wNH519HH0qf55XnYwkWZeoXSFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=v3ZDjcx2; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37915C433F1; Thu, 4 Apr 2024 20:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712260865; bh=jDgRvDUXquf8+1TaLuMSDg9OKMhNKkoBxWlEmTKp85E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=v3ZDjcx2JDn180LtBtTUY0btLp75KXzlujdo9T4C8aNGCv0gHU1XYnl09OcNjXzsv MxprMsVHDbcCEy7oF5q3Tc/g3dZIs8phM8mN/U0d1LRHN2+YhVANRC5jroDLIwWA5/ KlIjzseq8tJWn951wgdkSfWHObVQ00Hj0SNj83CI= Date: Thu, 4 Apr 2024 13:01:04 -0700 From: Andrew Morton To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Christoph Hellwig , Borislav Petkov , "H. Peter Anvin" , Andy Lutomirski , Dave Hansen , Fei Li , Nathan Chancellor , Wupeng Ma , Ingo Molnar Subject: Re: [PATCH v2 2/3] x86/mm/pat: fix VM_PAT handling in COW mappings Message-Id: <20240404130104.858c02d23216eb82438444d9@linux-foundation.org> In-Reply-To: References: <20240403212131.929421-1-david@redhat.com> <20240403212131.929421-3-david@redhat.com> <20240403151249.0f4fc5b4f8c07630fbbb6338@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 4 Apr 2024 21:20:06 +0200 David Hildenbrand wrote: > >> Reported-by: Wupeng Ma > >> Closes: https://lkml.kernel.org/r/20240227122814.3781907-1-mawupeng1@huawei.com > >> Fixes: b1a86e15dc03 ("x86, pat: remove the dependency on 'vm_pgoff' in track/untrack pfn vma routines") > >> Fixes: 5899329b1910 ("x86: PAT: implement track/untrack of pfnmap regions for x86 - v3") > > > > These are really old. Should we backport this? > > I was asking that question myself. > > With the reproducer, the worst thing that happens on most systems is the > warning. On !RAM and with PAT, there could be memory leaks and other > surprises. > > Likely, we should just backport it to stable. Should not be too hard to > backport to stable kernels I guess/hope. OK, thanks, I added the cc:stable tag.