Received-SPF: pass (google.com: domain of linux-kernel+bounces-132093-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 4 Apr 2024 13:20:47 -0700
From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, Jonathan Cameron
	<Jonathan.Cameron@huawei.com>
CC: Kwangjin Ko <kwangjin.ko@sk.com>, <dave@stgolabs.net>,
	<dave.jiang@intel.com>, <alison.schofield@intel.com>,
	<vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel_team@skhynix.com>
Subject: Re: [PATCH v2 1/1] cxl/core: Fix initialization of mbox_cmd.size_out
 in get event
Message-ID: <660f0b9f43ab_e7f16294f0@iweiny-mobl.notmuch>
References: <20240402081404.1106-1-kwangjin.ko@sk.com>
 <20240402081404.1106-2-kwangjin.ko@sk.com>
 <660d6d64a50bd_7702a29466@dwillia2-xfh.jf.intel.com.notmuch>
 <20240404143049.00005635@Huawei.com>
 <660ee4f023cd7_7702a294d0@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <660ee4f023cd7_7702a294d0@dwillia2-xfh.jf.intel.com.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y5ZwJRGUWmx6yG1AyYeN8Hv0VmRGd0qXFGy3zYV2aLj1vPk4grl5NeoC7r9s?=
 =?us-ascii?Q?9orQqul1Tn8ORrJvMC78IVe1MRQrsfLfthq2mS2EZInrpGTQWj3a1kyjjsh/?=
 =?us-ascii?Q?yLKQvujJJCeTvKvBlUIoTzeMuPeAeOFCU8y2G70wa70A1gySGz3JvUkDoBvS?=
 =?us-ascii?Q?0KpCWHDXqMzoLZXCq9E5iTrtRhrixXLUrhw0PhReMcolFJejYyU7QBUMu85z?=
 =?us-ascii?Q?zAh4dBLhzO9wjNMk19TH9J91luUJ+UdcUcUSJa6sG85WyWzvliE5VQJEER16?=
 =?us-ascii?Q?ttUxdiE3Ad6iPcYct6P1pM4XzyxNqgsqZJMGTPepLzXW6gJaLXmx99rOUvKW?=
 =?us-ascii?Q?ynMlbCgQf4IpvlrLNaPxgeMV85V9Ed2wUAVNucoHE9MEJxjlRPqIJTIM3BvZ?=
 =?us-ascii?Q?r7CGPiN6AfpLs+/10tL+zoC6w+NxanwNRtyQDSNvijeiwmJMy5vEGJoq1dR5?=
 =?us-ascii?Q?daYyrOXS3xUFtwOOZZnDa3JF//b3Vypzdxg36ZLtF8mx+ChgPqifBoqKWWxi?=
 =?us-ascii?Q?4fOkcw6T9Yluy36smWfDovGLv7y+j1CLuIhQIp0Ex+H2spWRArINHpBpTEni?=
 =?us-ascii?Q?S5ebKGH956QStRL65fMq2vo0i+x0DlSnPa1S78qYeMzNWWo4kqQxMOFXXN92?=
 =?us-ascii?Q?PZBtikk9SctnOG3ox2v+3CARH5OS4GrBYTihuTFhEBsEe5JZwVqXQypH0I6d?=
 =?us-ascii?Q?FOy/kZZcUm0fHpzfHPqQ29Ottumvl/1KEcxm5dEMxHxYcb7On+KG4ZCTIH60?=
 =?us-ascii?Q?7lAbajfjDrNjwj2QkmCAF4ED4jxiPdc0YGGcvhfZrVMAunkATiV3iF+//dCR?=
 =?us-ascii?Q?ltYFtPgVn4BW21+rbyC3UhAuFYb5gLFM9kONb2YdWxpB6OP2+u8BGiyCQ+xl?=
 =?us-ascii?Q?odLET22ju5MUGqy9DNvcQzuCysWGwl4CKk6w0ZjyShbWcfJrAxqPvV6jVc8G?=
 =?us-ascii?Q?K9tDRzF+NRfnnUYjXwWxgg6eojF2X1G2QuXBBWpw1pFciVX/hFFl69yGGkWM?=
 =?us-ascii?Q?lL3ne7L+NF7cgAtN2qeeBS6RKoGy5a9CoPdzGhoOeikjgqHcXUX7C4XjC27o?=
 =?us-ascii?Q?cp6WTJ8Om6XHtlsULwktwAPXt99YF1fsofGTmNEaCUhh4tKTVj+F3qZ9oFb1?=
 =?us-ascii?Q?z/FcuthDdU12WIwXYVwvMxNG6WzmURtpUegTos+TjWWNbaMnYligzb7vl2c0?=
 =?us-ascii?Q?r6Uqhsd0dt1ktwERR9AG462uFB8kW/1Hv5k+Gcwi0hTdhbRsHTqtKIvXYgUj?=
 =?us-ascii?Q?FSB9+tkpmmpVHY+LYNFn8dSIr1Vst4gq7u1Ha1rOf35oEChmNKgq77pkxKXq?=
 =?us-ascii?Q?HUgYQBY7dZVX1EEw4/IxBNozHrQqwTrc/nJBt2W3ZLkjN2XHnVvgjqcadwIA?=
 =?us-ascii?Q?X+ky1bqzIX9lP/hzL3fJ5So3i4WxtyInDSNChzr8GsmzLiQdcimgkDJJ7cKQ?=
 =?us-ascii?Q?CZcq/QxkPDGnxo3li4DFB3O9rQpxq5leEuqeD0CTEF4e1c/kn4Typ1LytjJj?=
 =?us-ascii?Q?K2SUS4ir6hW4CyxoLhICETUyNQhSYIv1GYWLHrFcm0o7T9Np7rDLXBmzuofO?=
 =?us-ascii?Q?ruXu9Uso86RVp9uAvlek53UIG8D8st7PvuGhasO3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cbf98dff-00e3-4a71-ed25-08dc54e4b81b
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 20:20:49.9118
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tlBnfYHxaCCNhauvVYgAo+Z5YVTUNVOmgTkrtOinWDkMiCcDKOWXY7bOPW5TlX8QDx8ZfecVZdcgEENleZk8JA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6800
X-OriginatorOrg: intel.com

Dan Williams wrote:
> Jonathan Cameron wrote:
> [..]
> > > 
> > > Fix looks correct, but I am concerned it is a band-aid for a more
> > > general problem. For example, if I am not mistaken, we have a similar
> > > bug in cxl_mem_get_poison().
> > > 
> > > So perhaps a convention to always define @mbox_cmd immediately before
> > > cxl_internal_send_cmd() like this:
> > 
> > Makes sense to me.  These aren't hot paths, so safe code is worth the
> > possible extra writes.
> 
> Yeah, the before and after size wise is small:
> 
>    text	   data	    bss	    dec	    hex	filename
>   15407	   2129	     49	  17585	   44b1	drivers/cxl/core/mbox.o
> 
>    text	   data	    bss	    dec	    hex	filename
>   15461	   2129	     49	  17639	   44e7	drivers/cxl/core/mbox.o
> 
> ...which I think is worth the peace of mind, and it matches what is
> currently done in cxl_xfer_log()
> 
> I will send a follow on with this since this patch is already in
> cxl-fixes.

Thanks Dan.
Ira