Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp300018lqp; Thu, 4 Apr 2024 13:38:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUuE6DQBdv7syP622nFzcU77oTGQ7gKnHZcvybWIe2PQAKGGmT47+CTcFLL5BWZAIzV/VpCeak5xzpyAhaxgB+xdUK/KsCo0cOFDe/QwQ== X-Google-Smtp-Source: AGHT+IH+xWmYqXfGikMGhP7+8yc0OLKqSY55bwIndm8GDBCU3BQHpQZkyzV0hhbpsmZuIxbmSHx/ X-Received: by 2002:a05:6512:3e28:b0:515:bc26:24d8 with SMTP id i40-20020a0565123e2800b00515bc2624d8mr363711lfv.66.1712263086923; Thu, 04 Apr 2024 13:38:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712263086; cv=pass; d=google.com; s=arc-20160816; b=XNX6fnZ5R9kpfGosW3F/lsq3xcQOFq2261lrQCxWaOoVlaFBPE5OXk8yRXEIa4RRjx pNMopazkecGwobDfGgfIlfefr4YX2aI2i3G9qj/OS+a1nmIJRiA5NRakK30iKMF/Lwd9 QXhM/Xxgli9Po1nyOT4ucD5Sz+Xz5STX6k1suLXD1HeqkBp7mvLwDi0fiJTG7BC7Tl6V xAiwZ8ti+KOI+rrtIZmP2ScZufdFXyKqBYY42oZYJJDzfuzON/edL5vDgrYF/3GdQHR2 hnXrpM7NZZSkj40WnGkKo9g8DQTvasTo9tdPU+ZsoZlspo8kErKhEGKVAp7etqJuzfBT O0WQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=yXWXvXaQQwwdlGUzvlG1EN94rlNOVaOKWLnNHntvCjU=; fh=W2kIIPI09UCmihruaY3KS0TkYMtQ3rbs+0ZuDpyvOl0=; b=GaFss4pCtOjE3DBX48CGtJLpZ/fxYnwkjESSsL0tGaXu6ClmX/akB+i9+IGbqD+LvQ 351BUhf3q51yZnBc+RFmSrcuTwB5bZrjffzYvp0l7iEpmgxoXQsJhgzHQXJrI2C057LV lcl1h4rKDwmFXuBmxBIn8bKiRpHlK6BMy0GkhQunchTzUu3aj480+61oGaO3otw8R7Tb 7umSHKhofEuerrlWd6DeP6+FcIrvk6e5X0C2bl57GoVjs2G7jJbZgfuNIY1atkyG5R16 z15CsSoK0ZZVnLrVwLPfyPtNpwJq1uvrV6eq9R5T2R++RwLZOtYtRZJNQDEDgb6xW8Dl ihuQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=khwTkHXk; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-132105-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132105-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id m25-20020a509319000000b0056e244988b9si22768eda.46.2024.04.04.13.38.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 13:38:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-132105-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=khwTkHXk; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-132105-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132105-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4E93A1F256B1 for ; Thu, 4 Apr 2024 20:37:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E98C013AA4D; Thu, 4 Apr 2024 20:37:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="khwTkHXk" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B89C135A57 for ; Thu, 4 Apr 2024 20:37:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712263051; cv=none; b=g4RDQNy84s3r0RRQXE5COZV2cbgngng8WEoQJkCNP9hLPF456PH5O+wJmiPT48Ou/9JqxYbjnTwFGk3tHkxXgu/xjmgibbSV+Oc9qmxV5ckk3i3ALmXu3Ws44WwlrJ9SHSB7DVc790KAiyx/WwFml4EoofO2eTVevs5HK4GEso4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712263051; c=relaxed/simple; bh=xOQUEK2idfQXjXTkdK30ijsm3ifktBoOy9VrkQdzNRY=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=fZ8ms88fCc6CKQqrajZCKSLqKUC0VmHPaqiSpCA+0IOlZwgz7+sJpfl0fL3rpglhI9DrfLmegBgF4WutWWQWPn3N7APEEe//wCNQacVww2fyKRn8ehq3UNYqvfbGhGLb+T2OCA3jSR4sVLkP5T78sLGyhmcIVdYLuWvcZC7kuL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=khwTkHXk; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34191C43390; Thu, 4 Apr 2024 20:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712263050; bh=xOQUEK2idfQXjXTkdK30ijsm3ifktBoOy9VrkQdzNRY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=khwTkHXk9LKus1LB5F1FSwOahT01SmpcrJgqZugyKsvzvqOehNBbCIodSj9MVTYXB rjukLs2wHTk4nGnAcWJfS8QPoKK0bIVrOil0WpGxQUlc8ylNnINeG0e3G0z6NGe55V 6OZ6a4dZK05g0ipmIjW28Tj3q5/gLd8BlLUqrqW8= Date: Thu, 4 Apr 2024 13:37:29 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: David Hildenbrand , Matthew Wilcox , Lokesh Gidra , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com, aarcange@redhat.com, peterx@redhat.com, zhengqi.arch@bytedance.com, kaleshsingh@google.com, ngeoffray@google.com Subject: Re: [PATCH] userfaultfd: change src_folio after ensuring it's unpinned in UFFDIO_MOVE Message-Id: <20240404133729.df00c3517e0b2cc3fd0d7e3c@linux-foundation.org> In-Reply-To: References: <20240404171726.2302435-1-lokeshgidra@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 4 Apr 2024 13:23:08 -0700 Suren Baghdasaryan wrote: > > Agreed, I don't think it is required for ->index. (I also don't spot any > > corresponding READ_ONCE) > > Since this patch just got Ack'ed, I'll wait for Andrew to take it into > mm-unstable and then will send a fix removing those WRITE_ONCE(). That > way we won't have merge conflicts, Yes please, it's an unrelated thing.