Received-SPF: pass (google.com: domain of linux-kernel+bounces-132206-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 4 Apr 2024 15:31:02 -0700
From: Isaku Yamahata <isaku.yamahata@intel.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc: "Yamahata, Isaku" <isaku.yamahata@intel.com>,
	"Gao, Chao" <chao.gao@intel.com>,
	"Zhang, Tina" <tina.zhang@intel.com>,
	"seanjc@google.com" <seanjc@google.com>,
	"Huang, Kai" <kai.huang@intel.com>, "Chen, Bo2" <chen.bo@intel.com>,
	"sagis@google.com" <sagis@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Yuan, Hang" <hang.yuan@intel.com>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"isaku.yamahata@linux.intel.com" <isaku.yamahata@linux.intel.com>,
	"isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>
Subject: Re: [PATCH v19 018/130] KVM: x86/mmu: Assume guest MMIOs are shared
Message-ID: <20240404223102.GT2444378@ls.amr.corp.intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <b2e5c92fd66a0113b472dd602220346d3d435732.1708933498.git.isaku.yamahata@intel.com>
 <3c51ec38e523db291ecc914805e0a51208e9ca9f.camel@intel.com>
 <20240327172227.GE2444378@ls.amr.corp.intel.com>
 <f7d0a8475c9d2e18a12f9da286163c75b11282a8.camel@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f7d0a8475c9d2e18a12f9da286163c75b11282a8.camel@intel.com>

On Wed, Mar 27, 2024 at 05:27:52PM +0000,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com> wrote:

> On Wed, 2024-03-27 at 10:22 -0700, Isaku Yamahata wrote:
> > On Mon, Mar 25, 2024 at 11:41:56PM +0000,
> > "Edgecombe, Rick P" <rick.p.edgecombe@intel.com> wrote:
> > 
> > > On Mon, 2024-02-26 at 00:25 -0800, isaku.yamahata@intel.com wrote:
> > > > From: Chao Gao <chao.gao@intel.com>
> > > > 
> > > > TODO: Drop this patch once the common patch is merged.
> > > 
> > > What is this TODO talking about?
> > 
> > https://lore.kernel.org/all/ZcUO5sFEAIH68JIA@google.com/
> > 
> > This patch was shot down and need to fix it in guest side. TDVF.
> 
> It needs a firmware fix? Is there any firmware that works (boot any TD) with this patch missing?

Yes.  Config-B (OvmfPkg/IntelTdx/IntelTdxX64.dsc) works for me without this patch.
I'm looking into config-A(OvmfPkg/OvmfPkgX64.dsc) now.
-- 
Isaku Yamahata <isaku.yamahata@intel.com>