Received-SPF: pass (google.com: domain of linux-kernel+bounces-132261-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <16f786f1-e214-43f8-ae0b-7ab537bb511e@intel.com>
Date: Thu, 4 Apr 2024 16:35:17 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/4] x86/cpu: Add and use new CPUID region helper
To: Dave Hansen <dave.hansen@linux.intel.com>, <linux-kernel@vger.kernel.org>
CC: <jgross@suse.com>, <tglx@linutronix.de>, <x86@kernel.org>, <bp@alien8.de>
References: <20240322175629.01E8B39D@davehans-spike.ostc.intel.com>
 <20240322175630.72CE974F@davehans-spike.ostc.intel.com>
Content-Language: en-US
From: "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <20240322175630.72CE974F@davehans-spike.ostc.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?My82bklQZnNScy9yMXhCTEk0SmhwRFdaMzdPME9LeVBaYnJOUzdqcW1CZ3Nu?=
 =?utf-8?B?bFVUZEhzanFvQTdOZ3NZTjN5emd4UmZDZklabC9RdGpvN04zY1kxNkg0UHlt?=
 =?utf-8?B?MzI0MmRILzROc0xxRzBQSUhGekxmR25FYWdySGlSU3RnSnBOSFEvb21oZFRR?=
 =?utf-8?B?Vmc1bUNaYnpJdGpnUGREbkJUVk9PUU42K2RaMUFRWldFKzhWNTBMcnY3OTBE?=
 =?utf-8?B?MFpYSzREeEdUdkk0cFFCSWorZE9VSEl5QWZ3YUNPUjJneWlabk1BSm44THhj?=
 =?utf-8?B?NldOYnlvNVBsLzVWVzI2L2FsamdkVWJWamR1bm1yNXZCU2NxZXhzeXdUQlNm?=
 =?utf-8?B?bUJsb0pFekNtYmdzRUVCUTNrMkQvak5EbUk4ODVuL0gzcnpqZ1VLSFVpcHpR?=
 =?utf-8?B?OVB3d25CTjBaaUUvY1NYV2lEV2pxM2Z6VnlPTlJ2UXd5YXpxSS9QOWpsZXhn?=
 =?utf-8?B?R0NmK3FkK0NVTkdhY2RzRExqaTFFTHNNZ0xYL2p5Z0lTNnJ3YkhtYU5oTGw0?=
 =?utf-8?B?NVlxRTRTUURobDY4M2VhdFhaZHErM2dMZHV1NllkVm5FTk5qaDlWRTVyTlo0?=
 =?utf-8?B?bDQ1dXFzV3REd1UxV1Q4a0pKd2ZodERwTHVLalFsM3hpV0ptNkQ0cHlYdThI?=
 =?utf-8?B?Ty82Qitjd1I3WHdwS3NXaG5weHhPblM0eThnbDVxMDlhZGt2KzRQWnBhQURN?=
 =?utf-8?B?NkRvdGRxS1U1WWxxQzBWYkxScWpjMkQyMDVLVzJIYnQrdFVIRDZWWTl2MGpK?=
 =?utf-8?B?VFFSMWYvTXk2cjJyMXRPSS81TDdjMWJyYVVQTnE0VWEyTzg4cjc1QWZQNzRR?=
 =?utf-8?B?dmxia0NkK3BVQW5aS0c4NEExQU1pa0prRkxjMWVENmtoTFNwODNoVmErQnNr?=
 =?utf-8?B?NWpZME01SjE2aDlJSGVaMFRBbENHK21VcjQvQU5OK3A1YTV6dUJaMVNnV0lM?=
 =?utf-8?B?VS9pNm5JRHN5SDREYzZUNEZmcXFCQmV5ZDRySEdHbTMwRVUxWkI5NDNjR1JS?=
 =?utf-8?B?M0Q5RFpLV2VueWFESTJFQW4zakEyczhTTEZ1RE04aDVneW51V1VaNG94L0ZF?=
 =?utf-8?B?WlJjVFNhVitjRlA1YmJpVnRoYzFzMCt4QURKajIyei9QMCtSbjJLV0ZWVUNY?=
 =?utf-8?B?RE1jdEdMZDBFdmFlWWdyWmRrdDJPY2JrdU5KVnMxeGt2NjhOZnhqYUFaRFB1?=
 =?utf-8?B?bHlkZUNEaXdjN2JWNXpTSmhNRGVJS1U3U1ZhcGtWVTBqY0ZRT05UODdoeCtE?=
 =?utf-8?B?NUFLVHRETU1XTHZIeFRHUnlZbGUxZjFXZ0xrN3JWcy9qQjd6N2V6TUtWZUVw?=
 =?utf-8?B?UnlUV0UyVEUzUldVVmdSWTVvblFTV1VwT3l3N09wVW1mdjlKa3kyNUQ2c1pT?=
 =?utf-8?B?WmNyNUtQZk5SczZwYi9ubTVpYitSQlJTV1lzOTRzTzBPdUk4NHFHZVN2TWJm?=
 =?utf-8?B?Y0h6Vzh4RHlEZkJXQ0loWjIvVFR3czk3V3hFYUpJaUtHVUFLQlI2Nmw4WGh0?=
 =?utf-8?B?eVZOV1JkM3hZS1N5SmpIaFR4S0FVNE9TY0lMZmpXa0Jtc29XdmtzTTFDUFUr?=
 =?utf-8?B?ZWtJM09qWnpOemtxSUlpRml4T0xMc3lVSFM4Qm1UQURPVjg2cWlFNHdmWHNR?=
 =?utf-8?B?TEZxMUZEMDFCdmRWbkJtSlZpY3g3TkZNOE9lZGs2UjZidW1yV1RWUXAyd2VC?=
 =?utf-8?B?MzdubzI1R1ZHam5YMitCSDdOV0VIdzJDNStaU21SK2NuUjBEZ3RmbitkQ1F5?=
 =?utf-8?B?Ukdxd2FQLzYySEN1dWZpeGkvTkJqL1VjVlJ6QXNYVzFEMTF3bU0yaGlyOW5k?=
 =?utf-8?B?UTQ1dW9wdGVwV1BIR2VINlFFSTduc3JwY0xxWUt1aG9iNGdob2pydkQyRHMw?=
 =?utf-8?B?VGtQcXdTcXhiTVNwa0FlR2dYYWdjSmRQbHR6MDk5WjhZbnpPcDA0MTBwNmhy?=
 =?utf-8?B?c1djSmVhTVVFa2t6YWhYVUx4Q0VqWWFFaVdDUFNwZWpETHZvM2RkRXJYQlNy?=
 =?utf-8?B?YnErQUJldVkvK0xkUWhOUjhhL1E4NnZaRVBPcFc3SEZsSWl5elpDQjBpRW81?=
 =?utf-8?B?QzgzUUorYWRPMk1CVkIxOWxudUNWOTY4YmJvZTAwU0tRV0xDQktOL0N0UmFH?=
 =?utf-8?B?YzBjTHUwRytqU3pGMWxlTnE4b1RhbGp1QTI5d08xWWNlcmJpY25MWHg5V3Ar?=
 =?utf-8?B?ZHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d4b0ecb6-57b3-43fa-5305-08dc54ffe392
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7164.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 23:35:19.2618
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sT0Ct913uj0epnGaP3oyRzQoeVdm0bQeL4qUa6d0z/34e5LItpJXA6rFAoEh2ETR9gpx+J+z1QS6mpRXu7PlGr8mXysSYyZyBAKKOx2Hq4M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7109
X-OriginatorOrg: intel.com

On 3/22/2024 10:56 AM, Dave Hansen wrote:
> 
> diff -puN arch/x86/kernel/cpu/transmeta.c~cpuid-regions arch/x86/kernel/cpu/transmeta.c
> --- a/arch/x86/kernel/cpu/transmeta.c~cpuid-regions	2024-03-18 15:12:20.680308889 -0700
> +++ b/arch/x86/kernel/cpu/transmeta.c	2024-03-18 15:12:20.684309023 -0700
> @@ -9,14 +9,9 @@
>   
>   static void early_init_transmeta(struct cpuinfo_x86 *c)
>   {
> -	u32 xlvl;
> -
>   	/* Transmeta-defined flags: level 0x80860001 */
> -	xlvl = cpuid_eax(0x80860000);
> -	if ((xlvl & 0xffff0000) == 0x80860000) {
> -		if (xlvl >= 0x80860001)
> -			c->x86_capability[CPUID_8086_0001_EDX] = cpuid_edx(0x80860001);
> -	}
> +	get_cpuid_region_leaf(0x80860001, CPUID_EDX,
> +			  &c->x86_capability[CPUID_8086_0001_EDX]);

Just nitpicking one minor thing:

CHECK: Alignment should match open parenthesis
#136: FILE: arch/x86/kernel/cpu/transmeta.c:14:
+	get_cpuid_region_leaf(0x80860001, CPUID_EDX,
+			  &c->x86_capability[CPUID_8086_0001_EDX]);

Thanks,
Chang