Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp381894lqp; Thu, 4 Apr 2024 16:57:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVyJRzJVL/dngND7JEkjaqmHvWEgbjk3+ObuxneHgc7tREKj9slI2NntozTPdMHAeDNR2VZpeJEFuLvzPwO/TOu9YfU1JFV2MDn1Ivk+g== X-Google-Smtp-Source: AGHT+IEHmIWPl1Fvv3nEaPKLH48p8BF4rMARAbCNY0+lXf9+81xv0LV1IU/KDSX4XVczMmxSus4D X-Received: by 2002:a05:6808:2f05:b0:3c5:dbb6:4467 with SMTP id gu5-20020a0568082f0500b003c5dbb64467mr1236052oib.7.1712275073736; Thu, 04 Apr 2024 16:57:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712275073; cv=pass; d=google.com; s=arc-20160816; b=RSSc0yVOeQjPPyybKY2SUWzvXZDu7GoX1keKdK2BMEZL20wYzjGQB1zSkmJJBn4/AR B+DM/opwgWqdRit3WBysJpkPI3J4zl1Tp6yQEwEMHODKDuYyqoXxvhAUbu4xa9knO8+3 Prj1VFY31BTAWxlQEAeV/taSBz2TK7B/A45ZVg+K3Nwy2pnNFeSB4HSLymMMtoi+5diW a0q7U6cc2/eDdiXi8x87jJecVHoxw8e94uEnP3+PjIMMfFv4KOPvYSGdIW2RX/j4XNm4 /itPToB3oXySLo569d9oZMUnnYxb6kIxsJo3uAjsj2tvpHUa/q5WqrhdHuqVRkyI3ZIM 7cwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=7HOSizFgEBxz4+Tar9vBiEOD02Kepsu9qJoptqH4MM4=; fh=OnZU0tWlT+BOmWVwRq/bVijh32Wu5SoOpLoQiVFXtQ8=; b=GRCoMhbCTGjk9rUVFUH4MfHbwr9CXt5fGQFn/dQYdOYfxYSS+Y4V3dsUWYinvNumce figFjAvrISr8fk1RpgsvHHXIyeUpkec4Ue3Zuicgiw3I28zRL8/HynqGHxRsZ7UJ41AI k6n4TqC1fDG1uO+tSL3dLWDdkx8U6J72y+DdYdGvvCvnCm8xbJwUlsSFPo/BailTH5aM Hr36vPlNkhnJ9L3ucYwT6TOzfnJ621uZJrjPP7HZa1/UBPTjpxHV1hkR+EUF2SV3C7J5 ZIaCItnVLGNRHZRPJyesB31urg8tzhQ15nZ7N0Xhn6zxoMd/ZTPsrvLIbp2iA2yyWwSN pqgg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-132274-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132274-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id de5-20020a05620a370500b0078a5d35436asi581919qkb.639.2024.04.04.16.57.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 16:57:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-132274-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-132274-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132274-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5594E1C21C20 for ; Thu, 4 Apr 2024 23:57:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DE04813C69E; Thu, 4 Apr 2024 23:57:07 +0000 (UTC) Received: from mail114-240.sinamail.sina.com.cn (mail114-240.sinamail.sina.com.cn [218.30.114.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB8E6FE1A for ; Thu, 4 Apr 2024 23:57:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=218.30.114.240 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712275027; cv=none; b=mE0dXVRKeQC2gFhCOBqT3xGz2/EJeVCkDmzaJXSB1tWqm/+Lx84ESH/AEcIgepymdgkM83efwy5Rp2LpwaPnjE54jnjKw7ke3oXBLtJMioS97ZjrmjFf/bWGc8Ne/Gvo32/vYPPFlgsqfygxHYUEDrtLjEtSCm4OLAG4w+mm/pw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712275027; c=relaxed/simple; bh=tiR0dWhX/RAb/Jzq06KY+ti0WH3crAYGNjpl1P5V7JE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hoAS0VC6uHzZ/pEqdczMdI6xeZ28wwsEc1NIlflP7Vn6JibzqO0PbiM0MrCtZVTkAXEU0FjEFZMfnAOSyZRXPULy7MUBJwROMwuJ/GnJzun2wMLoZyuamHQEN2mmO1ctg6FlpIznxAc6/X2bkCccQbSb/xob8Hha4LF6Td7serw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; arc=none smtp.client-ip=218.30.114.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([116.24.9.172]) by sina.com (172.16.235.24) with ESMTP id 660F3E3F0000459C; Thu, 5 Apr 2024 07:56:52 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 6179345089537 X-SMAIL-UIID: 1348F282FC554D269D623240BBF186E8-20240405-075652-1 From: Hillf Danton To: syzbot Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [net?] possible deadlock in unix_del_edges Date: Fri, 5 Apr 2024 07:56:38 +0800 Message-Id: <20240404235638.771-1-hdanton@sina.com> In-Reply-To: <00000000000083ca480615479e79@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 04 Apr 2024 09:13:26 -0700 > syzbot has found a reproducer for the following issue on: > > HEAD commit: 2b3d5988ae2c Add linux-next specific files for 20240404 > git tree: linux-next > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1133aaa9180000 #syz test https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 2b3d5988ae2c --- x/net/unix/garbage.c +++ y/net/unix/garbage.c @@ -358,7 +358,7 @@ static void unix_collect_skb(struct list #if IS_ENABLED(CONFIG_AF_UNIX_OOB) if (u->oob_skb) { - kfree_skb(u->oob_skb); + __skb_queue_tail(hitlist, u->oob_skb); u->oob_skb = NULL; } #endif --