Received-SPF: pass (google.com: domain of linux-kernel+bounces-132112-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240404162515.527802-1-fvdl@google.com> <20240404131549.27a454072f7e96530dce2d62@linux-foundation.org>
In-Reply-To: <20240404131549.27a454072f7e96530dce2d62@linux-foundation.org>
From: Frank van der Linden <fvdl@google.com>
Date: Thu, 4 Apr 2024 13:45:40 -0700
Message-ID: <CAPTztWaXXuP3uiJDBHEZR-WDrs8pzOBC0v7Mb5fz3sbK+zweEw@mail.gmail.com>
Subject: Re: [PATCH 1/2] mm/cma: drop incorrect alignment check in cma_init_reserved_mem
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, muchun.song@linux.dev, linux-kernel@vger.kernel.org, 
	Marek Szyprowski <m.szyprowski@samsung.com>, David Hildenbrand <david@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 4, 2024 at 1:15=E2=80=AFPM Andrew Morton <akpm@linux-foundation=
org> wrote:
>
> On Thu,  4 Apr 2024 16:25:14 +0000 Frank van der Linden <fvdl@google.com>=
 wrote:
>
> > cma_init_reserved_mem uses IS_ALIGNED to check if the size
> > represented by one bit in the cma allocation bitmask is
> > aligned with CMA_MIN_ALIGNMENT_BYTES (pageblock size).
> >
> > However, this is too strict, as this will fail if
> > order_per_bit > pageblock_order, which is a valid configuration.
> >
> > We could check IS_ALIGNED both ways, but since both numbers are
> > powers of two, no check is needed at all.
>
> What are the userspace visible effects of this bug?

None that I know of. This bug was exposed because I made the hugetlb
code correctly pass the right order_per_bit argument (see the
accompanying hugetlb cma fix), which then tripped this check when I
backported it to an older kernel, passing an order of 30 (1G hugetlb
page) as order_per_bit. This actually won't happen for 6.9-rc, since
the (intended) order_per_bit was reduced to HUGETLB_PAGE_ORDER because
of hugetlb page demotion.

So, no user visible effects. However, if the other fix is going to be
backported, this one is a prereq.

- Frank