Received-SPF: pass (google.com: domain of linux-kernel+bounces-130822-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240328020711.125070-1-jiapeng.chong@linux.alibaba.com> <20240403182320.93491c23ed5ae19e94158ceb@linux-foundation.org>
In-Reply-To: <20240403182320.93491c23ed5ae19e94158ceb@linux-foundation.org>
From: Suren Baghdasaryan <surenb@google.com>
Date: Wed, 3 Apr 2024 18:50:03 -0700
Message-ID: <CAJuCfpF8jrZx80j_6DgAKt0d_OSUwktpubY5kEHBp_dgU5A3bQ@mail.gmail.com>
Subject: Re: [PATCH] mm/slab_common: Modify mismatched function name
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, cl@linux.com, penberg@kernel.org, 
	rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, 
	roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>, 
	Kent Overstreet <kent.overstreet@linux.dev>, Randy Dunlap <rdunlap@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 3, 2024 at 6:23=E2=80=AFPM Andrew Morton <akpm@linux-foundation=
org> wrote:
>
> On Thu, 28 Mar 2024 10:07:11 +0800 Jiapeng Chong <jiapeng.chong@linux.ali=
baba.com> wrote:
>
> > No functional modification involved.
> >
> > mm/slab_common.c:1215: warning: expecting prototype for krealloc(). Pro=
totype was for krealloc_noprof() instead.
> >
> > ...
> >
> > --- a/mm/slab_common.c
> > +++ b/mm/slab_common.c
> > @@ -1199,7 +1199,7 @@ __do_krealloc(const void *p, size_t new_size, gfp=
_t flags)
> >  }
> >
> >  /**
> > - * krealloc - reallocate memory. The contents will remain unchanged.
> > + * krealloc_noprof - reallocate memory. The contents will remain uncha=
nged.
> >   * @p: object to reallocate memory for.
> >   * @new_size: how many bytes of memory are required.
> >   * @flags: the type of memory to allocate.

Nack.

>
> Well ok, but krealloc_noprof() is just an internal implementation
> detail.  I suggest this documentation be moved to the new krealloc()
> wrapper site.  Because krealloc() remains the thing which people
> actually call.
>
> Presumably the same applies to more of the new _noprof functions.

We don't need this fixup. Randy Dunlap's change [1] should handle
_noprof suffixes correctly. The warning was likely generated because
his change was not yet picked up.

[1] https://lore.kernel.org/all/20240326054149.2121-1-rdunlap@infradead.org=
/