Received-SPF: pass (google.com: domain of linux-kernel+bounces-130688-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240402180933.1663992-1-surenb@google.com> <20240402180933.1663992-2-surenb@google.com>
 <20240403145719.547d1083fede2cb4ca2c41ef@linux-foundation.org>
In-Reply-To: <20240403145719.547d1083fede2cb4ca2c41ef@linux-foundation.org>
From: Suren Baghdasaryan <surenb@google.com>
Date: Wed, 3 Apr 2024 15:31:16 -0700
Message-ID: <CAJuCfpGMDz7jKCLTVFZZB+XVAb9jfK79C1kNa7-BsYGDT7hj3w@mail.gmail.com>
Subject: Re: [PATCH 1/1] lib: do limited memory accounting for modules with ARCH_NEEDS_WEAK_PER_CPU
To: Andrew Morton <akpm@linux-foundation.org>
Cc: sfr@canb.auug.org.au, kent.overstreet@linux.dev, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 3, 2024 at 2:57=E2=80=AFPM Andrew Morton <akpm@linux-foundation=
org> wrote:
>
> On Tue,  2 Apr 2024 11:09:33 -0700 Suren Baghdasaryan <surenb@google.com>=
 wrote:
>
> > ARCH_NEEDS_WEAK_PER_CPU does not allow percpu variable definitions insi=
de
> > a function, therefore memory allocation profiling can't use it. This
> > definition is used only for modules, so we still can account core kerne=
l
> > allocations and for modules we can do limited allocation accounting by
> > charging all of them to a single counter. This is not ideal but better
>
> I'll queue this as a to-be-squashed fix against "lib: add allocation
> tagging support for memory allocation profiling", OK?

Yes, that would be ideal. Thank you!