Received-SPF: pass (google.com: domain of linux-kernel+bounces-128254-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
CC: Quinn Tran <qutran@marvell.com>, Nilesh Javali <njavali@marvell.com>,
        "GR-QLogic-Storage-Upstream@marvell.com"
	<GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley"
	<jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        Larry
 Wisneski <Larry.Wisneski@marvell.com>,
        Duane Grigsby
	<duane.grigsby@marvell.com>,
        "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: Fix off by one in qla_edif_app_getstats()
Thread-Topic: [PATCH] scsi: qla2xxx: Fix off by one in qla_edif_app_getstats()
Thread-Index: AQHahOQh91yVHc4OCEGa0hzVKaMVTbFVHrUA
Date: Tue, 2 Apr 2024 15:42:15 +0000
Message-ID: <ABEE85CC-86A8-4DBB-A409-212834875E08@oracle.com>
References: <5c125b2f-92dd-412b-9b6f-fc3a3207bd60@moroto.mountain>
In-Reply-To: <5c125b2f-92dd-412b-9b6f-fc3a3207bd60@moroto.mountain>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?6wCuZxBf3nCMEjjYu1fltub2/45QRAwno1YfujxxE/zPONHKYnlg8A01OWc6?=
 =?us-ascii?Q?DCXA5PogUCse2TZUL37ddlKC4FYQTEZ9l1Qj/PPjCiT84crV+PMlXwUsg6Aj?=
 =?us-ascii?Q?Y7cchFGVM+811+EGe0QdBC8LWzt6J0YWNAXshkvEx5VJIzemC98gm4yz6/hJ?=
 =?us-ascii?Q?nZ6s4yM8W5ec88/NQ/132IUBwjNv7yKvmqIGD+UHy42KsJl2eb1hX2GHIW8o?=
 =?us-ascii?Q?PnPwwtMIQZsPGh8BNT/E3601lDQRk2CxTpGqUP1xbaV+E8SsB7Pq4UxPApCj?=
 =?us-ascii?Q?GWBkQvOMHtKScObn8YMEsx3/DUuACGgf5hV5FtX+4v0LVJ4eocGpmQ7oa0gD?=
 =?us-ascii?Q?8VbaAIdqsjDxlZARI33mwvsK+lWmkbfwn01VIUt/Mf39JAMLUlxH+HofyS/k?=
 =?us-ascii?Q?8D0J2BaBrrvSAGVwh0fFOIxSXZopMam+hOhMzl1I0ACHZhrLeIhfFssZdJtf?=
 =?us-ascii?Q?altMNnoao3s82cDTWQipYnNRao61NCjvTIJ8fD9nwotue7t+v+yVYf3fFTW+?=
 =?us-ascii?Q?ZwrurWwR/EGyFf84Zk5XEN0a56AibFAWqMN56g0TO3IRowTlncSqhzxnJY1G?=
 =?us-ascii?Q?+cuIWSQqgcFG/EM/3nBfOYPUy0Yd1GlmOpNw135es0qDyhM7v6ctq+xbJ8c/?=
 =?us-ascii?Q?JzLwBkpTNjxVSN7cPPgKjbyQg9wjCgUMMrdXlcx+P4Wo8aPDqWWoMFLmoFR3?=
 =?us-ascii?Q?DNSmJ5Vh2xC/jsP3A3jORhUarrAamiTF1mHYy0Hzm3eWrXzBzp1GPOd+qDit?=
 =?us-ascii?Q?931KzIU9JviQaecOHuIhP5dKikp/wGZjJ64Q3EviVEbzUjyf1pCmZFoQlRmw?=
 =?us-ascii?Q?eENXQi6klvDYIrG9b76nbKNGif1/ovWkjldjZVRGjt1YtmjSQhYiceE2+L+X?=
 =?us-ascii?Q?IXX/pS+GADylroApe9MgYcQRe5fVdKNRBkFncuQ5pEY9k3qokK8HeS96SNtl?=
 =?us-ascii?Q?glXVQIk8pi/+alvCpqNSjt2Zg/eWCdq0mPHPprDb+5LksWj9Ujg6Tvryp65t?=
 =?us-ascii?Q?9FLkOmsNwZR+sTm1db9hwroQBPRkk1p4M3dVM3n/Lc9BudqMGJTnCA3KN/Aj?=
 =?us-ascii?Q?MddC1VQaJRW2Te3odXdz3lqyGXN9CZPPxYEvr5FOTOnKLM6S+wQFYWg4aeUe?=
 =?us-ascii?Q?SbPqKhxwt8QyKi+PSK5ZZi+RawJj0MFR0Q88N+XWBdwZdqKSh7KAsOeHEd40?=
 =?us-ascii?Q?98p7vEwoK2Hc2eq6C+p9XioRTd6LtnxtawR55JiWbhDruLlwza7I+ZUvEk+u?=
 =?us-ascii?Q?7BgBjrrE4Q8qA+AQUBs4SqYdPtgDP19LP8zwu74KvvrzjX6mi42coPZEdKWy?=
 =?us-ascii?Q?/534ISNg0q6atBa14Q/PYOhSQd0QTZ4evzpnWhFr7ekiXwMpjQs7rzfdvlMd?=
 =?us-ascii?Q?jpw2AO5jXwSuwv7Hf6LfSb2DHMymxyGOUQ66w/jK794gJg3rF+taWGiNLQOZ?=
 =?us-ascii?Q?hUaOvjs6RcP8gC/NOVQ46zBMiqQHo+ZgN7fZEL7INXGsTtjYqwxnMXfP4f5b?=
 =?us-ascii?Q?T7iy5RIyVyIpCTOLq7aB/X7Z1ZpCTjMVchknnvUvlcP4fB9ZnB52X+jC1mn2?=
 =?us-ascii?Q?Y52TBckXWdrEVMq6Ey2zFnCD8ta/0hXGbt5a12+TogSJ3DH3I5gZWFb+3bUG?=
 =?us-ascii?Q?2nnjfgcIcn21GP8wU0lOd/I=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B3332801D2332C4585760D60413BC21D@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	J2sVHmE6UlkG/+8qWK1bVYQpz6LwWnk11BPWMnPNWXF1rzrbkM+FxUiLVvSg1PdFLrUKUZ1f/N7FCJFlGclu8AZEb6HU6r67tsWzJo7glfAFFibzdXY+nYTKYt578fxS9h81xBHCmWdTENeH0ky8/bt+02FS412NcplbuqbxwaQf/Pn7AairP8wgAeLsMCjVxav8QaACSqas1bZaSiVNGtkpfNFOLiqx3ZyhBY/ToZhWpMNzUZecc0ePrlgYds+6gv5Po5xUZArhgU4MP0pRfuPklCTS9I7FEDrwAE7nyD8sA8TMCqTlJRZfWRcfJg/zMCr0tg0J3jeHPberU6F0Z5JareOzSuhV3vUE0nJYiAP0rHNOmEBW4YMPKTeI/z5aj7GQ6sIVyPG7WMhZsg91WISccTyqUWPZW4CcXKoHyP4t+CPc7yI8yGodXS4RSxBWhyJsioLKHA2a3l/2qvI3X2K+FwMqFwryeQn2h3nYEgqaj8xIWbqdFBTsK3uHRL30Dp+YJDyAxzcn9lzB7Tc4pp5j3QE161ig5BbhB3/b0/kq+Y/+leThzsJj/fuJ1B7Q2WCnFzwr/qkceYfvC00ZmgXEp1/nbe3Cw1HxmWrVB6Y=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH3PR10MB7959.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 216c3925-3215-48b2-2288-08dc532b78d2
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2024 15:42:15.5236
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0E0I4SAjY+DMKe02hMnIa3OPja3qE4Xr47JKleiQTSt/S1TvlpVdv9imI94Wdggb+jiBv6+n1+mq7yiYP8E3QEYo0+rvaFG2SjOgySe7Ekw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6137
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-02_09,2024-04-01_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 adultscore=0
 spamscore=0 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2403210000
 definitions=main-2404020115
X-Proofpoint-GUID: x7XqOVCHw_xHFlZxhb2NXXz3wd-jiO2l
X-Proofpoint-ORIG-GUID: x7XqOVCHw_xHFlZxhb2NXXz3wd-jiO2l


> On Apr 2, 2024, at 02:56, Dan Carpenter <dan.carpenter@linaro.org> wrote:
>=20
> The app_reply->elem[] array is allocated earlier in this function and it
> has app_req.num_ports elements.  Thus this > comparison needs to be >=3D
> to prevent memory corruption.
>=20
> Fixes: 7878f22a2e03 ("scsi: qla2xxx: edif: Add getfcinfo and statistic bs=
gs")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/scsi/qla2xxx/qla_edif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_e=
dif.c
> index 26e6b3e3af43..dcde55c8ee5d 100644
> --- a/drivers/scsi/qla2xxx/qla_edif.c
> +++ b/drivers/scsi/qla2xxx/qla_edif.c
> @@ -1100,7 +1100,7 @@ qla_edif_app_getstats(scsi_qla_host_t *vha, struct =
bsg_job *bsg_job)
>=20
> list_for_each_entry_safe(fcport, tf, &vha->vp_fcports, list) {
> if (fcport->edif.enable) {
> - if (pcnt > app_req.num_ports)
> + if (pcnt >=3D app_req.num_ports)
> break;
>=20
> app_reply->elem[pcnt].rekey_count =3D
> --=20
> 2.43.0
>=20

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com <mailto:himanshu=
madhani@oracle.com>>

--=20
Himanshu Madhani Oracle Linux Engineering