Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp450776lqp; Thu, 4 Apr 2024 20:22:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUskzfzK2XbML2zWd2/3w1Wx7E/sME8CESDXYOOL6NMJXMdqDqDQNMJ9UDehLeWd9OcRwDbuVj6xxpdlZTipFu0xORpr/cK7SIQIJ17Bg== X-Google-Smtp-Source: AGHT+IHK1b7htjahbKxDDv/t8jfGgwMh8vKKvxxLZzJT5YVO+L10shBx03YiHzMw7h46lH5Fi8Xw X-Received: by 2002:a17:906:3c16:b0:a51:9354:9362 with SMTP id h22-20020a1709063c1600b00a5193549362mr75948ejg.56.1712287362033; Thu, 04 Apr 2024 20:22:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712287362; cv=pass; d=google.com; s=arc-20160816; b=vsWHmuFniEXNelPj+N/OZn0sGpcRh6/ZmXI2H8SEI8DHOwVgxNbfPojmSVwInYzV24 SJjL22sQI1EbUFT7KIk4OIe+Ie1dAJIhZQE1mgGLIOByUmXQIk+8mh+yRhYa/Imf3GYk E4rRj9jyJmZIg0VuK3hvBta2uKCqH/Bx3KBwnyazjWBQjA1GJX4NN1407ymdJXdO4HGr ojSKvpZPda+JcVz7cDyh780Nhtu3OtM2BL/ssU3Qd+cuMAQkCBscekwkHejcYqtgYv4Q cVurS1WizGEeGuHKfcDFNy4VP80VrjFaqhjnarYnDZWY+B/wcyc6s7KxOCFCZ9qIK+qo iXRg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature; bh=Bk0QEmVb4f1vKjQAZiyiyCp+0dlzrHmnKU+o76nG/Rw=; fh=dtsKfPdwqhF9wRzOr+FZ2RLVJMI8gKggY7qXEdUmbR4=; b=Ny5M1mFT1XX3aO5CEVQk90EfDllVUxQMBw5uGxTH40PKcvWzqWua7YnRns6PdI+XFA 00d8AjzrgOYLwdR5PoNHcLqcNw4WrDsASgP6oHrSfnnuGTcBlFJ/gEJQ0f8IVG7JTLpz Njj2YMDNKfFuH1HJAr2LqnHunAxoefE7UYxvkSlvz3O1wQs2hhBkR1tvmVv+/zeadu6A 1kb0BH/hQfuJcxIngp9Cg3MfBbLPqAtcRbwM62/Hu4z/igmf8rvCkhCqPIwY1YlA8v27 xXI3JPAyUDa5UY6oQcXFN5MWgREV4CM4D8n1quaGN9KwSEzIiPsTEQITH0+YOzxFyQ2X pqdw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ZTXTCTXJ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ZTXTCTXJ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-132373-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132373-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gs44-20020a1709072d2c00b00a4e207ee793si266917ejc.646.2024.04.04.20.22.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 20:22:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-132373-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ZTXTCTXJ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ZTXTCTXJ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-132373-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132373-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8935D1F233CD for ; Fri, 5 Apr 2024 03:22:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D7CFB1A26E; Fri, 5 Apr 2024 03:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ZTXTCTXJ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="cVHpIw3J"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ZTXTCTXJ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="cVHpIw3J" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D83215E9B for ; Fri, 5 Apr 2024 03:22:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712287339; cv=none; b=G1i4vfYDUsw+2RcsIQDZXBsP0GbuD+4TzFKDazJMtVF8LojpCn85BFYn7koTQjX/T5xi99oNm6Tr3DjYZyZmM89bkGOoHCxRY5FsQWqjDc5bezvBVLYcYiTA++QKg1loHi8C3G06cwRqGWgAmq/e6z+4gISOvy/JiirWOvNWbDw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712287339; c=relaxed/simple; bh=8GGmPCwTYZZ46IcWHTyVP1u1MlUe46zXkKoyQoyoLlY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ePYQTx/W/XVLeCm8Sn3MisYRNg5GtUZkZcnjRUNuS/mjcMW+XENSH61E3V/E2Y9Q0Mk5TOXA0ggh/wJWRzdzlm2BwpU8c3N2V09JqBWiLSX9Bly7IEAaaJIovEg0APAUSPKWJQR5+p0KYuSnOHz8Obk6mzYnTkXe8kdWgMXMG6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ZTXTCTXJ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=cVHpIw3J; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ZTXTCTXJ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=cVHpIw3J; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7C27E219FE; Fri, 5 Apr 2024 03:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712287335; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bk0QEmVb4f1vKjQAZiyiyCp+0dlzrHmnKU+o76nG/Rw=; b=ZTXTCTXJHkV5L2weiLQfGIi65BJP+jesilOXdH+NvJ14EtfNSXTTupHTq64XJvSAkXczG/ RV7NqQLLPSk27OZ4JB9NOC1GLTHbwSFchpyeDqp2igBkohVCZ6h35b7IoXOt8INeLI6XQ8 4F8lnpl20qVXRM1Xt0PQ0HFiaCnGQJ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712287335; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bk0QEmVb4f1vKjQAZiyiyCp+0dlzrHmnKU+o76nG/Rw=; b=cVHpIw3J4tKLV8ACRkgprcsRV6onQV2rxLDCEg3vRA5d5Zv3Te6ReQ0KGjeeeqBGdUCqge qbafQz1YSpWHTmCw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712287335; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bk0QEmVb4f1vKjQAZiyiyCp+0dlzrHmnKU+o76nG/Rw=; b=ZTXTCTXJHkV5L2weiLQfGIi65BJP+jesilOXdH+NvJ14EtfNSXTTupHTq64XJvSAkXczG/ RV7NqQLLPSk27OZ4JB9NOC1GLTHbwSFchpyeDqp2igBkohVCZ6h35b7IoXOt8INeLI6XQ8 4F8lnpl20qVXRM1Xt0PQ0HFiaCnGQJ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712287335; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bk0QEmVb4f1vKjQAZiyiyCp+0dlzrHmnKU+o76nG/Rw=; b=cVHpIw3J4tKLV8ACRkgprcsRV6onQV2rxLDCEg3vRA5d5Zv3Te6ReQ0KGjeeeqBGdUCqge qbafQz1YSpWHTmCw== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 1C16113357; Fri, 5 Apr 2024 03:22:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id 4Dm4A2duD2ZxaAAAn2gu4w (envelope-from ); Fri, 05 Apr 2024 03:22:15 +0000 Date: Fri, 5 Apr 2024 05:23:43 +0200 From: Oscar Salvador To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, muchun.song@linux.dev, willy@infradead.org Subject: Re: [PATCH v2 3/3] hugetlb: Convert hugetlb_wp() to use struct vm_fault Message-ID: References: <20240401202651.31440-1-vishal.moola@gmail.com> <20240401202651.31440-4-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240401202651.31440-4-vishal.moola@gmail.com> X-Spam-Flag: NO X-Spam-Score: -2.80 X-Spam-Level: X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_TO(0.00)[gmail.com]; TAGGED_RCPT(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email] On Mon, Apr 01, 2024 at 01:26:51PM -0700, Vishal Moola (Oracle) wrote: > hugetlb_wp() can use the struct vm_fault passed in from hugetlb_fault(). > This alleviates the stack by consolidating 5 variables into a single > struct. > > Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs