Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp491181lqp; Thu, 4 Apr 2024 22:42:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUbLjrh2RxPKMtQXZsfUcsBwpzY377o94t7I04fB/aBykLA3VwZWc9NEoxcsR/NLk4i1qe87aDLMi2tFxCizC1uXPxye15rXpXGoanOmg== X-Google-Smtp-Source: AGHT+IF/Rgk/d2wvXZfnYZYgmyesp2YnQuZU9T6TbwScMNIlBQB5wxGywiqQMd77/Z7X8XD6VxnA X-Received: by 2002:a05:6a20:daa2:b0:1a3:6dbb:f072 with SMTP id iy34-20020a056a20daa200b001a36dbbf072mr714613pzb.8.1712295774549; Thu, 04 Apr 2024 22:42:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712295774; cv=pass; d=google.com; s=arc-20160816; b=ia2XbS4+zg6eroKZkzAITZWBcm/06dUBK8JuUwhJ/TBhNFRXE6xRaWE9YyeW23TG5I nvHd6QJhZGgS4Fej2iPpKrx2imtT09t7NIN+UqTUbfzwv96vycQtbuKo4HVtFZoBzLaI rkXX8/OtBPUKIX1a1L59MDSfbrHVgE9h3/R0dzuv1P21lwCsyWxJmWxJpLr8QlfpH2pU J3LXPaM8I/LYlFkYkwy74VnDUN2+Eg6/Ic3AIcAo0RNpE5168iz2DAK/y+2aCK9pZ5z6 qhDnp6Chx6CIoxZoE453fWlUgBZsGFA7b75XDF6Ent+jtFzevpnw//ZV4uG2/fpVLHBX rAXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=AcltF4rXp8Wbpda+aejkh/mnoyPg7d26vErpj50Kt/s=; fh=PYtl/mvlVc9iaVbSJg4Qq01lmv6tkykkwdJ0Hpczb3Y=; b=nRgtRCzo48O87pEBllAh+Ge3DqAivWMtehiv1b/23dR+HYP6Oaejh9cqduAFZDhWil F3c/yww8tWUL1o8ip541fMFwW9uJgnA7kzpwqbHuCm8SRgAbWokY72ddSgF9fF8nLy0t +ZKNuvdb0q2/cnQMAYyUsFPXsbk0l+Gv7LQ0JlMG5pQXsClYw07YblT+5v5JaXJKxtY8 hQjmcAMerH69MYS+09OfwqDfmBfFj6paMe+AGC5n2+vTcc5wcqMgfbZsAqKMAcz47oQC wnJwAfgZFASQsVPCpeUmls+wwSYStEZBRwdmC6q5Hg5jjqHAVC9dT0v6n/MFMkJnPOCw vzfQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@atomide.com header.s=25mailst header.b=Cc76vaP6; arc=pass (i=1 dkim=pass dkdomain=atomide.com); spf=pass (google.com: domain of linux-kernel+bounces-132430-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132430-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j7-20020a170902da8700b001e27f807a8esi740954plx.343.2024.04.04.22.42.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 22:42:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-132430-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@atomide.com header.s=25mailst header.b=Cc76vaP6; arc=pass (i=1 dkim=pass dkdomain=atomide.com); spf=pass (google.com: domain of linux-kernel+bounces-132430-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132430-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1E363288287 for ; Fri, 5 Apr 2024 05:42:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 52E7E2232B; Fri, 5 Apr 2024 05:42:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b="Cc76vaP6" Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A31B224CC; Fri, 5 Apr 2024 05:42:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.50.62.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712295768; cv=none; b=DBKQTnI8x1cYQqVqGGfy8ejPDIFaPNtooGuvS6spqzBm1o5vPHS6RePwmn5Ebz2HQ5tThNIjnGvgeUqd2UWDFlnD5i1Lb8tW78SA5AQMM2eG/cgtcbd7UiGfK1BEEcGFqWm4LWye7VXuXi7HXuOO98n7OEOtgqkOWlcl4TZ2ay8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712295768; c=relaxed/simple; bh=AcltF4rXp8Wbpda+aejkh/mnoyPg7d26vErpj50Kt/s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WvMhOun9AMAtLWfmBRleivv/XZ8egeK4aA1RntEYNvuxBti8LDfct+zV/NZ7McGelpsgyc0oUekES3PhO28zAbfwGoST4ckZD+2rWwoeX9rEQnGW3C/LNYEpNqoNTHRompVOzDjjz4P/I9BZcnhfa3zHEU39ieP0BlXCwK9BT/A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com; spf=fail smtp.mailfrom=atomide.com; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b=Cc76vaP6; arc=none smtp.client-ip=74.50.62.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=atomide.com Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id 995E860333; Fri, 5 Apr 2024 05:42:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1712295759; bh=AcltF4rXp8Wbpda+aejkh/mnoyPg7d26vErpj50Kt/s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cc76vaP6j3Q9EZW/45vE2uiMyUkrv75nWQEOIhm63C1ZFv56Ki2LAAqUkWQfEvvUB hX4Tnw21pwCj1NW0AkKOVMMWLeE/t3q8PxmpnjaA7wwi+DqScIfrFIPyxzVu44Lwjj KZo1kh3Ib+Tczklk+tFWHeXAEZQvt3gIXmnXYjT0avwHooJM80COE2fRKIEyBbNDM/ H+VnCZ5qfLMlMFsrAXobz8bwpd/Ad9FVBaGo3DaTkz06GQgusVuLRow1RDMmX85Zaq dHbYd4spab87apKDOKy6Aea5O7laVqLahLGP/1VIuEAHIfCg8Lya7iuethjB5RrcGZ c4DrDyXMBrSeA== Date: Fri, 5 Apr 2024 08:42:23 +0300 From: Tony Lindgren To: Jiri Slaby Cc: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Yicong Yang , kernel test robot Subject: Re: [PATCH v1 1/1] serial: core: Clearing the circular buffer before NULLifying it Message-ID: <20240405054223.GP5132@atomide.com> References: <20240404150034.41648-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: * Jiri Slaby [240405 05:25]: > But again, serial8250_start_tx() should not be called after shutdown(). Sounds like we should add some check in addition to UPF_DEAD to serial_port_runtime_suspend() and serial_port_runtime_resume() to bail out early on shutdown. Regards, Tony