Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp502681lqp; Thu, 4 Apr 2024 23:16:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXWWCL4OkNy3eCDQp3wPJNesnfHsSy3/yaPJ7UaBjNT+LD/x+tFeo8uv2RlDI9oGnrcTbfr7j1sa2K6Y9iFL4JHau9lfau+YVwzG2MA8w== X-Google-Smtp-Source: AGHT+IHbtTtQeG3705qNmJOM8D+kEW1hIk7PrCx8oF07EbxMw/b4vw7anA5rG0ODHWXjqEkFHzki X-Received: by 2002:a05:6102:304d:b0:478:81c6:780a with SMTP id w13-20020a056102304d00b0047881c6780amr860813vsa.25.1712297797546; Thu, 04 Apr 2024 23:16:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712297797; cv=pass; d=google.com; s=arc-20160816; b=xUN3tUsknQroTfXE6K6ESS/WMVgCuyhts03VSBYDka9brqAriqveOHaT5gL1VIyQHq 0hyIW7k7gemeyBNC3RSIkbBmAKmvjVqoF9kP/TAh4R0p8cW+pEUTOzrhZ1ASLd4H+Piu A+wRv6gZ2RY5ecu/0RiL7g98HTVW5V95jT8RRZtaB/8BZNGogyJOP8rMeY/T9UoyI096 M+T9x8wyBGKd9siYOhPEK2yN+E3voYc2jBP1APdyetXhqEDv+k/rhHTouTGkzAiGVIkI h5Sv7qadAF/b986edypUKAbneZnIJmy26/wvhsqHmjhLMwdggSUN/4bATFWpOjiJTE5a vEGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=N+y4gVZPxqoPWF3mCG9OTNmFc7apGuxsri5ldIPkgQ4=; fh=Z/DuZz7DTBFCNWksBKpKJu8nj+rwZLNKB1GlBH2f3A8=; b=lIQpf9L/CrLxxnwwhCTJg/OmjLugw4bigbpDlKLICIa1kr6QuQkaHzlRaN9k7Od1uo 7dQTQuxa3w1xK2CMGIWlVjmD7QspYfLi1SK4xYemVUU0fKhsdNSSwO3T4daHPnm7WDPU BztnAidaq+LjLPBIKwfUjCqwFjbl5ikiNcZR1CAe3/gftvNlTlV8M5g5IFc6e9r2dH5t Z74cjMQYtIUB344oyQybNpW3hGgDAPUJFERaHogm2zGmJT+rEJEpvXH1NOSMsrPxc7aX bp6y/do22G/PsLV8mGB5ej69fNjOrXzQbBmBpTjnITTK1KtQtNRpYreKzjtmqcyXAZUe o03g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-132464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132464-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e11-20020ad4442b000000b00699306c2b78si1062933qvt.215.2024.04.04.23.16.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 23:16:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-132464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-132464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132464-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4928C1C2222E for ; Fri, 5 Apr 2024 06:16:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4FBB422616; Fri, 5 Apr 2024 06:16:31 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4599D22612 for ; Fri, 5 Apr 2024 06:16:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712297790; cv=none; b=cI4evWpbk6TZCo/ZWJM0qzhR1KBKBp4uo72pBhSt3zizU0IV3PFMrgie1pzc+QKKioH48Cpe+DubbYM1rySGbvnJt6mPwETqtQnTOyOmJAXlTjTGSbofGO5NDBbc/iww4AcvjfYoe2l80cJ4eOGkgOKbpZZTs/LDmS8H3yoZvyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712297790; c=relaxed/simple; bh=f7YjR+Pr4pA5TXDvpEHMiIFNiuTLf721psXAU0xMLkc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NwMKLxmP5A4M2ihsk2VZ0K6ZEdPIMfmfLtXmCsqOvkf4JlyjwQv9nypqes53RXwfUvSX7LQFNUERPwqbpVGAwmOA6HnTUpXO/OIj0/eoC3lccBEc0fCpH5AmF3GHZXeMazX9GgeUBNRaPz5A79xqj3ctp2LMmNaB2smr+9AEv5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 9E16C68D07; Fri, 5 Apr 2024 08:16:25 +0200 (CEST) Date: Fri, 5 Apr 2024 08:16:24 +0200 From: Christoph Hellwig To: Daniel Wagner Cc: James Smart , Keith Busch , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/5] nvme: authentication error are always non-retryable Message-ID: <20240405061624.GA3107@lst.de> References: <20240404154500.2101-1-dwagner@suse.de> <20240404154500.2101-2-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240404154500.2101-2-dwagner@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) > --- a/drivers/nvme/host/fabrics.c > +++ b/drivers/nvme/host/fabrics.c > @@ -467,7 +467,7 @@ int nvmf_connect_admin_queue(struct nvme_ctrl *ctrl) > if (result & NVME_CONNECT_AUTHREQ_ASCR) { > dev_warn(ctrl->device, > "qid 0: secure concatenation is not supported\n"); > - ret = NVME_SC_AUTH_REQUIRED; > + ret = NVME_SC_AUTH_REQUIRED | NVME_SC_DNR; This is still abusing on the wire status code for in-kernel return codes. Can we please sort this out properly?