Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp530801lqp; Fri, 5 Apr 2024 00:36:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXR23Hpd/5aVc5MayDGTLFb3NsiVsXPv1HNxxgAZPzPdMwHeOZSNottcr5Fq544YeUmXoqjyCRe5Jf708mniJ/ox61wwYi8eQSsD88S5Q== X-Google-Smtp-Source: AGHT+IF02DT1rAQQrIuL9QAHT0gUrtQy9NBZ0qYHr43KsVW0pm/fIdzYdLQiX88gF0EpWlXPEKfc X-Received: by 2002:a17:906:2798:b0:a51:a42e:592 with SMTP id j24-20020a170906279800b00a51a42e0592mr398156ejc.63.1712302608960; Fri, 05 Apr 2024 00:36:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712302608; cv=pass; d=google.com; s=arc-20160816; b=skg9SDOMj5Mw9r9GFGDv7DlaK/56Wd8grDDPqIHXzxmGvgMmIYX+nJWU3mrWJiA3kc eMGePz7K3IZwRwv5XkFoQrIgojwOiMckmZoXqKDMPAppuu1Dgj6LTYFo8sj273d3p1ST sqm71EbDQ5Vf23exeCgS1Az0V6iE/ci1MOpXr9tiGbXIE2RZdRQSYSyMA6Nk9RCg0ZFt THapFxYOKBoSUZ43WE65alY8g079EudUFS251BsSi2Dw6JZ0tdH4BmWpRUiOwBoLOMfG 01oHFQUGzCPc5XhR1bsdY7JqXPdqtanzKua4edghWw+oxdmr2/r9ol7SdXfLPr+4bacx rR2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :date:message-id:dkim-signature; bh=2y8u7mwlp5ekwXbwQkfIoccQIC1fIHBDNEWQHYbjVLA=; fh=SDH0+6wRgXUScPPjJQaJ6oM4zjfdaJgX0wzEBJcP9dM=; b=ev56/gfGVTzgM+BsXNfYbQD9At9gpqZ+DSCO0n3yP3aFA2YGE0OQLJrZQQmp/xixa0 nnFOSf1SKu82HelG6buVKJIFt5HBjjxlBelt69inymjtsBkGSaHRwf/HJT1cYmSe+/63 KEt8QiWaOQDLPkz7Zr4V9m4NWE0HgcTkCzNyVWMXJeyJSRU3Jn+53XY/Tcy6+KeNFv1V o+0SpXqkhOwlPw5PDa7Dc8QBsrP16hT51GMnpXL1FX7vp2jRXqAJ+rxvpxvBOiGY5tW5 omJQ8Urnsqm+v2OkhxgSL4aolEDxI39p8msZ1Ies7DyVIpnogw1zW9UboCeC6TvHmW60 3PyQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Bhkccrcb; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-132561-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132561-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id go37-20020a1709070da500b00a51a9b16e5bsi176228ejc.969.2024.04.05.00.36.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 00:36:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-132561-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Bhkccrcb; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-132561-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132561-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7F2981F21990 for ; Fri, 5 Apr 2024 07:36:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 34BF74E1AD; Fri, 5 Apr 2024 07:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bhkccrcb" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D2B34C610 for ; Fri, 5 Apr 2024 07:36:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302601; cv=none; b=m+PZkCxqoQ75pkL8jPCH+RRq4seo8pmg8VfuU5gl9ZUY4P0ZStM7RgpqFeFWYUjtiniBymDc+2qHXSu26KXSGbE0JChwAMymcj3LJaAxUiYHyVa+1PnT/izTYToFqqEqAmqVMvTUavDowFkV2XoZfghfEt2T4TmlBXPub6AXbbo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302601; c=relaxed/simple; bh=TMwy3wHtQiofB2H2K/QILd7SO+d9opnrdv705aVCSLo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NRlQvGH73lYhodq1QAqUCkZq1o4k0/cZiZKs0ZHtRPC12ajWJXxxlE2WRhyPJJrD5Ge2SlaaUC2BXDe6sb0nVvAJXn6kzt4nB80KkLycHDjdYcNKW98ce53NUVNljkEMwwviETO5fqDO3US4fVFlgsR7AEJZdanQGwsNv3yg4c0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Bhkccrcb; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712302597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2y8u7mwlp5ekwXbwQkfIoccQIC1fIHBDNEWQHYbjVLA=; b=Bhkccrcb+1fVDXNHXT9HtTUnBH08YYNKFPZD2ovZs0lv4PcCeLJdyowuNnY3EphKBUJj4R YinqAS7ESs+v/NWyN9LwyECrMsNATFjWWG9sr853sqV3cMNUl8eSRLSiCcUU4q4NUEJxVs jgJbOZ97W5BSi4yxCkaeNPCZ8Yk6HeM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-Mp-c_XrjN9ukMb-1C9CfTA-1; Fri, 05 Apr 2024 03:36:36 -0400 X-MC-Unique: Mp-c_XrjN9ukMb-1C9CfTA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4162b93067dso6509575e9.3 for ; Fri, 05 Apr 2024 00:36:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712302595; x=1712907395; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=2y8u7mwlp5ekwXbwQkfIoccQIC1fIHBDNEWQHYbjVLA=; b=L5n//BpbOO0I2ewKcNkWOdi2Fv9WgVbHoaO2GpSNRHPnwyfiie8Ikcf3LFGpKSptai fZVodYUGtZWis1NId94vJJKe0z0WxKdwM7KUK3/pAkX4PRMLCSP5u2PbPXv7d9hLBcEz xLcjjmlyLhX4KuUegpjdZDWVaL6VAxIxnFMKxZKzjD7q9B+A8sPqu7L9qzOml9sV/UVh BUMnqj5A+dAV0VE70ySW1kqVy0UrCFkxOdejkun1x7YockVgsufJYiCGpOkzMEeY69Vw ibnAV5eQpmkmZNjOcyYcKlAkv/a0a17J6oeMfrMuwoU5nl12C9LfPOiEf0K0LlTH0c++ EtPA== X-Forwarded-Encrypted: i=1; AJvYcCVRsr7NywU+6BE1L+NuFsOuUpapG1U8jogKUiWSNVQmudCjTO7KbX4xJsybxaf98qlJ4lqCY8Wbl9eSurGgQ+Nb9MM5vgdQmHBeJJfM X-Gm-Message-State: AOJu0YzwBxWXLN4A3K1490tnn5ZSgOGYXFD9JNEMTUATGX7mi4ub1TdD U4a4eBaCWyTuDBpf3+w4phGU2aDPaWQtSXLHu2m2ZalYnvi7DBCDbt6vmQZ7q5Nv+hp0vDB26/D 3AvNxFU0fVFLMCZGhOl28fEM6Q5C3hMzLy+ZLYpFOJ3BMC/YPtOssSStb+fY51g== X-Received: by 2002:adf:b1da:0:b0:342:61ee:bee1 with SMTP id r26-20020adfb1da000000b0034261eebee1mr479565wra.23.1712302595119; Fri, 05 Apr 2024 00:36:35 -0700 (PDT) X-Received: by 2002:adf:b1da:0:b0:342:61ee:bee1 with SMTP id r26-20020adfb1da000000b0034261eebee1mr479546wra.23.1712302594695; Fri, 05 Apr 2024 00:36:34 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:5500:e1f8:a310:8fa3:4ec1? (p200300cbc74b5500e1f8a3108fa34ec1.dip0.t-ipconnect.de. [2003:cb:c74b:5500:e1f8:a310:8fa3:4ec1]) by smtp.gmail.com with ESMTPSA id t20-20020a0560001a5400b003434c6d9916sm1313388wry.110.2024.04.05.00.36.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 00:36:34 -0700 (PDT) Message-ID: Date: Fri, 5 Apr 2024 09:36:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/14] mm/ksm: Convert chain series funcs to use folio To: alexs@kernel.org, Matthew Wilcox , Andrea Arcangeli , Izik Eidus , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryncsn@gmail.com Cc: Hugh Dickins , Chris Wright References: <20240325124904.398913-1-alexs@kernel.org> <20240325124904.398913-9-alexs@kernel.org> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240325124904.398913-9-alexs@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25.03.24 13:48, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > In ksm stable tree all page are single, let's convert them to use folios. > Change return type to void is ugly, but for a series funcs, it's still a > bit simpler than adding new funcs. And they will be changed to 'struct > folio' soon. > > Signed-off-by: Alex Shi (tencent) > Cc: Izik Eidus > Cc: Matthew Wilcox > Cc: Andrea Arcangeli > Cc: Hugh Dickins > Cc: Chris Wright > --- Why not simply squash 8,9,10 and avoid this completely? There are not that many relevant calls that need conversion. -- Cheers, David / dhildenb