Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp532379lqp; Fri, 5 Apr 2024 00:41:29 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWPOb+oCir6Zq7oN2c3hBwqnLuB4SlBC0mD0n9tZoxxxRnPXlPf2/HnnlmdlCz+2LDB6Ut7KYvi3oPN7udiF1D80isZTGoqEYmFGduCqg== X-Google-Smtp-Source: AGHT+IFvHOENAqLUydGWmPZ1Fx4VSY8o60bRNduv+AuP19Zu/cAudfD6e3aNAogSvShmqRY2tFkN X-Received: by 2002:a17:906:f909:b0:a4a:33b7:e828 with SMTP id lc9-20020a170906f90900b00a4a33b7e828mr400113ejb.40.1712302888994; Fri, 05 Apr 2024 00:41:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712302888; cv=pass; d=google.com; s=arc-20160816; b=OgWzwKl1IRdN5CKaS88LfiV1abtaUzmx1DU4q80bQPDGXT682qxzNFjm+iPoiVjDKP CYf+SAqrvbfhuIVE2dvqortR2qchGv1Q5+e4bAuMwN3T34hIZZ0xW2mUwTMCOCrj/d63 WIY8JoeMtjzcOBCX7w35f1GfruMK2pVJbBuienAolei5/5nQzeUMZpBwkvdcDal0I+oQ iThLY1dupcHYC4FfkDiqwurW2QkFlEh3cZ69XbtsrS3uWg7WhVc0dC5ivD0qvpIZ8wlj Rdrez/hGcJ5BTin4KxvOodCTg21xOGIJIhOyVQFHFFD//3neQnuwBMgeLBdeJKJy+wU5 Vr5A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=RNwZe5BOe/LQIqDd4/80RXtPtgdVPrSCbY1S4wwVTwY=; fh=DxsVbh2UZDkyLx21HhDpPyoZWmfJ0RNhyMjo3H2uc9g=; b=SQiihS9BUx+Tpg9CdtUC/jIzIPQvjNz/9WTuyEosevY49Vo3LALUF7AZOlDJoTSB4e aWs2ANyOIhYqXLjUk/s+uPyKvxkAq45l+Nmbs47uXF6Anp2IBBUYyyNzzeOMB2YPxLTd uyY6PPOeau4ssc/qteHAqNzAq0Gw0xKRBcb0jA5YXRpNnfUDcUrToK7FYmy5LfaQEaRV 5j04oXtK+ZpLEN+mjxsjDG9eN7z5v/WUMJSNwOjneF1Iqicn1TwFqWlEU03OAE8ST8sy JVG3TT6mzT1ts3Fg16LRHzl3/N/zLjQ2pTIjS/KKIh0al8tumUSqMQTs7zA7+5iEgYvl 6gbw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=BeBA8KKK; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-132574-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132574-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id g21-20020a170906395500b00a462435da0bsi424611eje.659.2024.04.05.00.41.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 00:41:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-132574-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=BeBA8KKK; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-132574-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132574-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A84FD1F22DA6 for ; Fri, 5 Apr 2024 07:41:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE54513C9A0; Fri, 5 Apr 2024 07:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BeBA8KKK" Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B41312FB0F for ; Fri, 5 Apr 2024 07:40:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302820; cv=none; b=rh6Dbuoo5REN66cnJ8QKUXH422V4/wkOElhx9+UZuHD+JfQs/iTm6ybN/4LLb0fihEu5+shvxVFeLxH7CIIVvP7nrQSZ406ZrREbzOeYLum1XHKPaHiaHXm4sG63EVj/FgDUrrt5zEXCDPcUm/eFU6258DOylzETHOH/rJuINQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302820; c=relaxed/simple; bh=YoCK0eHi9vC1QpW8oygU2C2KyLLNC61wcBUkYFvHKuQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fh3o0QZxVhdzzHaed7gnVzOb3nqagoXLRm+JMLryD/HCXByKcwV0dSHfKPjqo/Da/Q7VGuaEH0oRonBlJ9Xel9oagXYDV+EaOwQEF9qc0qz5eAdWNvfAIqTUEe5nrzT0bA7eejA3qhdPAuQ35l4lcPFS0e7qxvM/LmG4BNcr4C8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BeBA8KKK; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-34339f01cd2so1313347f8f.2 for ; Fri, 05 Apr 2024 00:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712302817; x=1712907617; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RNwZe5BOe/LQIqDd4/80RXtPtgdVPrSCbY1S4wwVTwY=; b=BeBA8KKK+hB+Tw7K6TnUgNj+s+MGxDNmBUJCl4GvX4YtAs7pFxG3047fZG/gjBiG2B hPLYPa+qg19HJBWTQzBPMJa9Kn/ASLVEo7r02OpyKXc6x/17dJEyB6rc77UV4vHG380j yZhoOfAk9kSkLSx7uevLEFt2Cs0oZlYxiQflJYSbKG+oMIzO4jGkQPb4xIQ2DfImmnCe MXpc4ALNuKABL7y682A+atzXRPSOrfTyIqhOjMYkAQ0kFnbC4XLam7KXyWIA8FDQrTQw EBOhWe33tOKSSMhrPvFXC91pgN6KLb06IhHVplQ6QPFiSwp2QsESY1iV/5sM1fV7eTYh 7USw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712302817; x=1712907617; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RNwZe5BOe/LQIqDd4/80RXtPtgdVPrSCbY1S4wwVTwY=; b=SA02AMuxXdaE0IQTDL2I5o0arJhQXinH4/mEJUkPa+SIY7ozi18MNjBrJU7kqCfcoo mICGrnsVe1xndVbZRDLofmNk+tNU7rNmBVJ8j8gK78Ikw8QHUn+HCnFQszLDMSMj5zw2 HHhG6ET2WrTy/rQ4a8f3JdbzaYaZgrENCuGIUVIVOAzVNqONMhrMX1u5HyRV3RqO0kj4 RXsxpuOj0kA+f7AUsarMHn5UpqH51gjMwp3IRomqNdy21FyGVUmLnFHjzjmCSKVCg5Vq eIU3dV8btRRx2kt4AMJzBZV5sxRGlT2qttqoTm2wt99mTQ7t2BnSfw7/dMInMd2snVo9 KsYA== X-Forwarded-Encrypted: i=1; AJvYcCXRJhERQkkScPA3/IWov7d7e6nvD4/I7V3KeGqTJmFUwUIdPLgK2lHrxYdGW6hH9WFQXmXq8Kbm9bSVbp/bgXpPdzVhi6QbJOvI/o75 X-Gm-Message-State: AOJu0YzVaFSdwsLpdI8iKrFeerJ20ayLkt+rxN88isZDOzCk77thRGw/ tX9HgYMoNMGJstZAh+rAInlCzo7hQaGxWfsaUM8vKzw6lEjwUtkq X-Received: by 2002:adf:b1da:0:b0:342:61ee:bee1 with SMTP id r26-20020adfb1da000000b0034261eebee1mr485769wra.23.1712302817549; Fri, 05 Apr 2024 00:40:17 -0700 (PDT) Received: from localhost.localdomain ([2a06:c701:737b:ef00:2bdf:f41a:ebd1:fb2c]) by smtp.gmail.com with ESMTPSA id l10-20020adfe58a000000b003434f526cb5sm1311643wrm.95.2024.04.05.00.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 00:40:17 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, andriy.shevchenko@linux.intel.com, robh@kernel.org, felixkimbu1@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 6/7] staging: pi433: Add debugfs_remove in case of driver register fails. Date: Fri, 5 Apr 2024 10:39:59 +0300 Message-Id: <20240405074000.3481217-7-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240405074000.3481217-1-ikobh7@gmail.com> References: <20240405074000.3481217-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit debugfs resources were never cleaned in case of failure to register driver. Fixes: 4ef027d5a367 ("staging: pi433: add debugfs interface") Reported-by Dan Carpenter Signed-off-by: Shahar Avidar --- drivers/staging/pi433/pi433_if.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index b01ee145ff3c..77e37a5bd1a2 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -1415,6 +1415,7 @@ static int __init pi433_init(void) return 0; unreg_class_and_remove_dbfs: + debugfs_remove(root_dir); class_unregister(&pi433_class); unreg_chrdev: unregister_chrdev(MAJOR(pi433_devt), pi433_spi_driver.driver.name); -- 2.34.1