Received-SPF: pass (google.com: domain of linux-kernel+bounces-132643-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: <Raju.Lakkaraju@microchip.com>
To: <andrew@lunn.ch>
CC: <netdev@vger.kernel.org>, <davem@davemloft.net>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <edumazet@google.com>, <linux-kernel@vger.kernel.org>,
	<Bryan.Whitehead@microchip.com>, <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH net V2 2/2] net: lan743x: support WOL in MAC even when PHY
 does not
Thread-Topic: [PATCH net V2 2/2] net: lan743x: support WOL in MAC even when
 PHY does not
Thread-Index: AQHaen5pA5HIVZmbdE+YwqVuzvYGF7FBPcYAgBgZppA=
Date: Fri, 5 Apr 2024 08:17:22 +0000
Message-ID: <LV8PR11MB87003ABBCA98F00F3EEA9AB09F032@LV8PR11MB8700.namprd11.prod.outlook.com>
References: <20240320042107.903051-1-Raju.Lakkaraju@microchip.com>
 <20240320042107.903051-3-Raju.Lakkaraju@microchip.com>
 <22089299-a3e2-4cbd-942a-65ea070657b8@lunn.ch>
In-Reply-To: <22089299-a3e2-4cbd-942a-65ea070657b8@lunn.ch>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2C1G5LQmtcY5AcXFBtPdNsMJx4EuucwGbgoCBqMFdoevDfkDnMURFbBX2rWi?=
 =?us-ascii?Q?VBLX86AcSkpSj+l+9fbbAb6DmFwAtSoKuHbznb1tQk/oPnLGpV0jxX7qPBVk?=
 =?us-ascii?Q?J1ZdJrg7xZbCW/JDDCksyZiatLjvsaHYa1f2aTm4gHi1Po8xNDNLM9cv6Jg0?=
 =?us-ascii?Q?Mb2ZKhjGQqR3xdRjGYZoN7Bsc+RLHs595TUvXz9zHdFcIHq2XXqScvha3Gau?=
 =?us-ascii?Q?Ypx/sv8vrLloKCwIey3ZtqSsZlrO9fobgJQpcf/SsrlfV3gGVQJ4eHF4WIvD?=
 =?us-ascii?Q?y49O9Xo0Alw6uKO4ClsOxtEmN8ulfsYGoPdS+SqH666kcmqnAIaC7XHx9oVe?=
 =?us-ascii?Q?23pIMFl27VH0zmj1y9arpkROfC7WIxrDR0qtTCY7Gx2IZwO2zlU9HC89KTJ3?=
 =?us-ascii?Q?ymV6rOCK7RHF5JKSgbztK5g+xRqNlK7p6RhjBbg6W4il5H1tP1rb4nSs4/zl?=
 =?us-ascii?Q?HGCWjlP8USsWb9VYMHpbfnbUbmvNeycC2dyceRh80h9U0UJO7MmnD8WprR42?=
 =?us-ascii?Q?mj0MX4RFGN69zLUp4RUnkD1mNkLd5CpAIocjRod7gEwjpmpPKECwbywnkRHU?=
 =?us-ascii?Q?MSBkG0vhhM1hKudG67ew21s2DSMdh99K7Wj5ypPhNZkR07J42cp6sp45vEhl?=
 =?us-ascii?Q?21/sF0MG4BB0kTAB288XyNjg9HtdRui/dADI7LyC0H5mDIwTx90ucki4rn30?=
 =?us-ascii?Q?nBuHt04MAMUNLqUP+IFvDLIswAXbkDSGJGUxcy+a937VfNgZQ5AQmAvCTi77?=
 =?us-ascii?Q?tlvX0cwQ2BiS8rY+CGXrAU8d4kWnYGG9QkQe0U6lNxoME6FxRCq+zTkYC5FS?=
 =?us-ascii?Q?09S15m2LPl/RSRigOgGbZ/OY9MOwbEN3KERRxmI8n7zNM1+PrqJmvED1Qg5a?=
 =?us-ascii?Q?6l53H4zXNAW6kXGO8GS3z3Zs2VNvTR2h6gdRilldLE+ij3pRLxsriVuQaB7A?=
 =?us-ascii?Q?5oYmw7QlN8lywueaeuW7xf7ljVIi9RUTkgev3vJ0HTPGZ7UCUAqtWTLzk1pg?=
 =?us-ascii?Q?q3ZDM7AkxSINS48jbxj/2bi4rgl4n5Xy5KzAR2EItj3IEGr0qLr8/18sGSGm?=
 =?us-ascii?Q?g3fjl47sxdGpge5NoTHSGFmj11203HSJOLU+rMp69ZUAOO2g82GHkCq8rsrf?=
 =?us-ascii?Q?+mIPWzkk12ejSyLHr2IRw7hi8bYh9CAi1nA6cXhvYmTOo24Wa1l2Vt27+WLO?=
 =?us-ascii?Q?xGAeQhVglPILuOuvtlfNZkLZERWeJYFUcFeR4rt+U2R8EWriDTkzsPAQXZAY?=
 =?us-ascii?Q?lm5BBwc9t0CUvJUR66OHx1TZa8KcD2uIRrTxcBenI4bM5fUzqzId5KqFWOq7?=
 =?us-ascii?Q?R/r/8W3CypyYwCnT/b1Fwps00VLupCndGSr7uwz5YZI+IgnlI9uATXSxqTvR?=
 =?us-ascii?Q?1iInNu9CAc1HKgvX19HSviMf4kYC59SyvTq+Nw0d+5OYM2TZI0hD1bT8kbqI?=
 =?us-ascii?Q?SpOXvkRLhPxWaQC2FwlpOakiRgwuoLNtidLwvaqHWVMlLRnEU0aybxa3M0aR?=
 =?us-ascii?Q?Bh3iRItIlP0E3t/XGGKdewv1yn76LzhPi/fu1u2XDy8gjVBhHQSwYapeh1a4?=
 =?us-ascii?Q?n8idcDgA3Cc1Ka0hgAIG9UDfG2HqTN0YaY8BSAcRfew161pqgZzJ4DwLMwnu?=
 =?us-ascii?Q?Wg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: LV8PR11MB8700.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f95e7813-8568-4a46-f854-08dc5548d190
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2024 08:17:22.1185
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sffs6XGMsSZkiTrHfc9SGv2nQ0VLxzrHLa0y0QnyxuaXvrYeZ4GUZEL0wOBb5qQY2N583yaqJU9JiZ0l4AXv4fDIvQvd9BZrR5kK2SvhuQo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4770

Hi Andrew,

Sorry for delayed response.

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Thursday, March 21, 2024 4:23 AM
> To: Raju Lakkaraju - I30499 <Raju.Lakkaraju@microchip.com>
> Cc: netdev@vger.kernel.org; davem@davemloft.net; kuba@kernel.org;
> pabeni@redhat.com; edumazet@google.com; linux-kernel@vger.kernel.org;
> Bryan Whitehead - C21958 <Bryan.Whitehead@microchip.com>;
> UNGLinuxDriver <UNGLinuxDriver@microchip.com>
> Subject: Re: [PATCH net V2 2/2] net: lan743x: support WOL in MAC even whe=
n
> PHY does not
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> > +     if (netdev->phydev) {
> > +             ret =3D phy_ethtool_set_wol(netdev->phydev, wol);
> > +             if (ret !=3D -EOPNOTSUPP && ret !=3D 0)
> > +                     return ret;
>=20
> I'm not sure this condition is correct.
>=20
> If there is an error, and the error is not EOPNOTSUPP, you want to report=
 that
> error. However, if the PHY can support the WoL configuration, it will ret=
urn 0,
> and this function should exit, WoL in the MAC is not needed. And doing Wo=
L
> in the PHY consumes less power since you can suspend the MAC.
>=20
> So i think it should simply be:
>=20
> > +             if (ret !=3D -EOPNOTSUPP)
> > +                     return ret;
>=20
> Do you have a board with this MAC with a PHY which does have some WoL
> support. Could you test PHY WoL is used when appropriate?

Yes.=20
We have external PHY (Max Linear GPY211C) attach to MAC of PCI11x1x (PCIe E=
thernet chip)=20
If I don't register the Ethernet module in wakeup source, WOL is not workin=
g. Ethernet device power state shows as disable.
i.e.
/sys/devices/pci0000:00/0000:00:1c.4/0000:05:00.0/0000:06:03.0/0000:09:00.0=
/power/wakeup   <--  disabled

PCI11x1x is PCIe bridge device between PCIe and Ethernet along with other p=
eripherals (i.e. UART, SPI, I2C, USB and PCIe devices)
0000:09:00.0 - Ethernet device
0000:05:00.0 - PCIe Bridge Up link=20

When I test the WOL_PHY option on setup (PCI11x1x MAC + GPY211C PHY), obser=
ve the following:
1. When enable WOL_PHY by using ethtool (i.e. ethtool -s enp9s0 wol p), GPY=
211 PHY configure the WOL. After resume from sleep, GPY211 WOL configuratio=
n vanish. Observed that gpy_config_init( ) function reset. Is it expected b=
ehaviour ? In other mail thread, we discussed that Ethtool configuration sh=
ould retain after resume from sleep.

2. when WOL configure with ethtool, Either Link-down and Link-up on CLI, WO=
L configuration vanish. Is it expected behaviour ? Due to this, every time =
we have to configure WOL through Ethtool.

Based on above information, We need to check for return < 0 condition and r=
eturn the error. Else enable the wakeup by calling "device_set_wakeup_enabl=
e( )" function.

>=20
>         Andrew

Thanks,
Raju