Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp559543lqp; Fri, 5 Apr 2024 01:54:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVwncHSrv6IPlRLbRr7hvBIztHGi2XXbPi2e5xeuc43T+9cTqlWbFrCxnfGmuQNXPhn93sQJ4J41bi1NZ4CHtodc+xQduMjAOglymQMow== X-Google-Smtp-Source: AGHT+IH0TAtYbetIW2t79bqBsGwne3tH4pQCsrMwQ2OsErXS7eFqMjIFcCwEhTopDLjHb7Iw0+/4 X-Received: by 2002:a05:6a20:54aa:b0:1a7:237:c3ae with SMTP id i42-20020a056a2054aa00b001a70237c3aemr983960pzk.52.1712307298825; Fri, 05 Apr 2024 01:54:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712307298; cv=pass; d=google.com; s=arc-20160816; b=JsVOzGxl7FuMPG3njv3xftkzPzAXSya13yTxw6JJ/IatUIefH9CZQLA3RqNLBlwyWX xprvyUh4If6TN1nqTDIdMz/dW70h4h4u6Ws/Eeg2dPg4/stX+Aq3cAL3tpWzxL6RBnZ/ sjydjnAgLQ05GWbaaCF6Yo0A7Dr/SA24lXjfVHmbid7MAM08k74BfEQTppypnV8WoPYw xtJXuxbMAcJ5tQbUvmmVNW7EmUz8kxUMI9dY2pAoCzNg9tqREXOzgO3oyB/bljXGCW4v w0tlggOtTdoSuvwdw6NyC/40br2cuQA7VcVJZiNjsVS9lSuRrnp1zd3tGgStN2PQ8Cjg q+bg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=+rd7OWEfOgaXcRrsSTTxKuVoa46Lnc9mtKHiCb+X01E=; fh=eAmQA/+rZxc79dD9a0cpm39N2Pm4ib6iN+ot8KxubLc=; b=jadgila6NmTcz86IY9y5Pds0TDNPVgBATDT8jV7ls8b4sO4Savnk74eS39q8vMZJzA yd16Aj1MyplJbXnliHCW0KX6Wkg9eBYL0FWYN8hmX4OB5psN8gwzY75BGfn1CCMdhNXG KXR2ZoZdmtnaSYEfRv1YJ+xcGyaLOn9a+wgkqUrz9guPY93Ec8/jGZ1sdTgLwaAA8IqS 8WP3wdbcLl1wovTpU/jpCFC8N/jUm5uG3ZaLL8mn0UQzApmj8n4Pwgu4lhUHn+jTaAxe IlXAsN5dNSIL7kOCKMsRHF1ctqoSYDIoLyza8bxaDKKpRe+SqHkAHXX6hP3HRdLd/qft 3FtA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M2ew5+H9; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-132687-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132687-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id iz11-20020a170902ef8b00b001e25659e19dsi980291plb.108.2024.04.05.01.54.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 01:54:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-132687-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M2ew5+H9; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-132687-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132687-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 601E3281185 for ; Fri, 5 Apr 2024 08:54:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AC05915FA79; Fri, 5 Apr 2024 08:54:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M2ew5+H9" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68F06611E for ; Fri, 5 Apr 2024 08:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712307291; cv=none; b=m8ezy8h3CJ0nBOXlEfbJy0RGBLeYX5IQErclSuimnHA2UtI3RpRz7GMQ8IjLFwLnxNOJuElt4SpIu7MchBucw6nso0JsjTEwuFm3LSBSyJQFXTUED59wsUaXpIwTwKqkMMBsQW+xwAhjfWBB6jOqK51Bdc5zSIjMeitIZsY/OPs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712307291; c=relaxed/simple; bh=N3tSnJJ5B9cvcmlA05jWhatlsn0eDJOoakXmXKZPw0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i7WANIbWBrG9Ne3WEsCb9hLKLanubU/nZFL2od/X6lWJHA2R6BwlFxmkWOwvHAuJ2nKQUT9+N+7oAtP46PXVMnPrtfaaBFw0VLEJaZUYzWlKfnq6ETs9iG4t9Tqaa+N+4tzWc2VJchqF8cpFl2xuaZ+jJscEJjrem/8bLGRX1C0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=M2ew5+H9; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712307289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+rd7OWEfOgaXcRrsSTTxKuVoa46Lnc9mtKHiCb+X01E=; b=M2ew5+H90/7juVMGikvT9yDGOFEHkznzPfDOjOJKANyhEtNetDh681RcpKg8sSrziRuQNG icmRjfcJr6bmYEdQSozkpPi7ZU13KyWJAwRNfkzRt4sxQQ1zegNnUzJa7GgzX8aE7C7WmX ONeCkCQ/RpKs7vaUi1hpjO05wYE3G/E= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10-3OhZOoMvOJ6BR-EB9nfbtQ-1; Fri, 05 Apr 2024 04:54:47 -0400 X-MC-Unique: 3OhZOoMvOJ6BR-EB9nfbtQ-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a467a6d4e3eso109280866b.3 for ; Fri, 05 Apr 2024 01:54:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712307286; x=1712912086; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+rd7OWEfOgaXcRrsSTTxKuVoa46Lnc9mtKHiCb+X01E=; b=IgrnB44GTUbPC0mcLTq0S+HZY59rX3PI7jOXnMjxS+FoJAcOIjn+mVdkOTRqOdN2q9 g++DBnqrgljOw8XqIGCedYHL9va7xXeYONRM9D5+OSOFSS6M14Lf15Pp+cnCkG3buCV2 f8i+OylLHS9ttDYgDI8i6cePGyf44EeC2T2D7NNvHRl+jVAOwWXYm5KAzZRoTkpJhHil VCa5dYbXZvhinPFAj6cdtt4C9iz5ejWlOGQxHeY2APMQ3bFTM30USoZL7iAaJVhskNBn X4cw/ZpcDTj4vo7HlqUaTMWsXeGFeGbLKtLrlkKv3Kr91wi2fI2LhuLgbocJsJsyIcok IsiQ== X-Forwarded-Encrypted: i=1; AJvYcCVXggjOzhK5XZQLJzyCtbHbdMGJ+FmQ+yjds36/O2S3VXJ7KFwH2pSG3uexlYFli+0mRw2KxceoAPYWW/PuyByQNSuswT/w540ECfe7 X-Gm-Message-State: AOJu0Yxz0Uk/3UhILOFRcGxz7T2PrrI7DwuFEi3PTAB2CWRQnJlT8BA2 RsnLaldYHAALe+fTa0p2vAIQPxVJGWZYDR8U19hpOoeKZXquR0MH9wJvXm3q4uZIUx4eNwHN8zk KUEJ0yHXLp6HHZ0IiZp5XS/8JFZCnDM5vbmLzZzVUYTLm4MOnJqd7iE+2x/rWjg== X-Received: by 2002:a17:907:7b89:b0:a51:9d99:78ae with SMTP id ne9-20020a1709077b8900b00a519d9978aemr712166ejc.67.1712307286661; Fri, 05 Apr 2024 01:54:46 -0700 (PDT) X-Received: by 2002:a17:907:7b89:b0:a51:9d99:78ae with SMTP id ne9-20020a1709077b8900b00a519d9978aemr712152ejc.67.1712307286440; Fri, 05 Apr 2024 01:54:46 -0700 (PDT) Received: from [192.168.0.182] (host-87-2-128-150.retail.telecomitalia.it. [87.2.128.150]) by smtp.gmail.com with ESMTPSA id z12-20020a17090655cc00b00a42f6d17123sm594252ejp.46.2024.04.05.01.54.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 01:54:45 -0700 (PDT) Message-ID: <4f30b6cd-8077-4ab3-87ab-8f29a66cc6c4@redhat.com> Date: Fri, 5 Apr 2024 10:54:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 12/15] sched/deadline: Reverse args to dl_time_before in replenish Content-Language: en-US, pt-BR, it-IT To: "Joel Fernandes (Google)" , linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider Cc: Suleiman Souhlal , Youssef Esmat , David Vernet , Thomas Gleixner , "Paul E . McKenney" , joseph.salisbury@canonical.com, Luca Abeni , Tommaso Cucinotta , Vineeth Pillai , Shuah Khan , Phil Auld References: <20240313012451.1693807-1-joel@joelfernandes.org> <20240313012451.1693807-13-joel@joelfernandes.org> From: Daniel Bristot de Oliveira In-Reply-To: <20240313012451.1693807-13-joel@joelfernandes.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/13/24 02:24, Joel Fernandes (Google) wrote: > From: Suleiman Souhlal > > dl_time_before() seems to be incorrectly used, we need to check that the > 0-laxity time is ahead of the rq_clock. Fix it. > > Signed-off-by: Joel Fernandes (Google) Makes sense, I am adding it to the defer patch in v6 as it is a fix for it... -- Daniel