Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp566703lqp; Fri, 5 Apr 2024 02:11:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUD9d/0ehRIZpCniCpvvhRN1GlAXcIEcoifoqoKmCkd2sT0ev4ViINCtEYgJHZ1NMfDrcVACtf55q9NXdov4RfXNJ3bL/KXrN95nr+c6w== X-Google-Smtp-Source: AGHT+IEp9g0raL/XjnNnzPW5WLPaoLxuti72eMiQN5/99hpgZe6CXTLUy0W4gSOrqTIpfzkc3xQn X-Received: by 2002:a9d:7ccc:0:b0:6e9:e1cf:b332 with SMTP id r12-20020a9d7ccc000000b006e9e1cfb332mr958225otn.20.1712308298796; Fri, 05 Apr 2024 02:11:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712308298; cv=pass; d=google.com; s=arc-20160816; b=YTmAvbFjw9ztKhVjCfbhdfmvWB21tFKUD6uRStIr45okzCrqAXN25CuOLp9snz+JlP auhSMas9KfPo2wvmdQ/Q5OjTOYjdvMTDAZ0dEmccDK2Dp46owCF3zSzSZA47Z9Io11Nk vsQJ3Yv0LjWqGu4S6I7yPtO8VyTugmIU9ifiCEVd5AUFwuSJhovEW+itRynLNqZJfgp0 IAs485MLMD3bhlG4owoonB051uq1dIdckaylZYG4sjkq4cXnB+UqzIiNUN1IRrl7YV5R fJ+g/1WFYYLn63UW6sl5FUsUfHznxVPzL7IUCzmqNe9tyKNXl2TPouCNDIpvE+9IXj+j +Gaw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=E+32tc+g6bFUi7eOalPmpwKSPNS4pCbzAaqy2IDSlhk=; fh=ofhkgXnrpq5c23RvFoxTnOmOWdeR74qWTldqQgjrua4=; b=DJEdNddZdYhcpy41KaYAsq/zgdfRLgV2xFZd7bNzHrqE3YSkHu9yTSTkFApuwbOm14 8up0Zy/KnSoHel8befl54FAea6TCN/Hgl/AMhlLdxKLDo0AalN2aNxbKMUWB7cvKcpYd +chk4GAP49yfVX8ElVQGds7T7rh2NyW9209zee2TXFTzuk0z/npBGGYsfa5BvwH9Vc71 Lv95I3f9vR+hS4nWI3N3zP1BtsdyJWWEvaQGIdy/o3edVzwD24WlfauihP72J7hfBwyo Q2I6ZJzpDYe8u3NGsJJNEmWoy87tgJcV3JVtzh/HB0bZ7miNxCPZ3627nVUL0vUVsMio n6OA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IepPMTgV; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-132704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132704-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id z6-20020a63c046000000b005e4a4aa2528si1080007pgi.48.2024.04.05.02.11.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 02:11:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-132704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IepPMTgV; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-132704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-132704-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A0FFEB2206A for ; Fri, 5 Apr 2024 09:10:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4211915FCF1; Fri, 5 Apr 2024 09:10:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IepPMTgV" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA74715FCE3 for ; Fri, 5 Apr 2024 09:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712308236; cv=none; b=aWnTvC00vSiyLQppvsmI6PVaaeERjpBP47yRGUqlGCKZXevbAm2U23yLcjRX8rl+K5TFYPaVzR7hh/kTnUNq3hktDQwq0+WqDm8q1TDAagSlI2qeZxajyEMLK1dYm2b31nbeSWmkJlB0V4yHANweUvwrQwH7MpAz3ckPZBc822Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712308236; c=relaxed/simple; bh=81eM6jiXwtalbaZcX5u6YOuEklPGUYeCbo3s4KCd5z0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lnfcsQk15lSh1F4h0NaPUdUV64O0N2qy1ew+tl2aVkPHbscypJB+kVBz5shjAr/2cV10gKZc+FrHCj7rwjn9snJcfVdSRap5DW2lzgEioBSWuXqVlXxOeotVZMlBACYNzRu77smz8ZjaTL5UNuK4d6FfQz/Gf6JMh6yumQgjdRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IepPMTgV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712308233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E+32tc+g6bFUi7eOalPmpwKSPNS4pCbzAaqy2IDSlhk=; b=IepPMTgV0r+/r6V2tMB/znrmABGss4dQAC/PrjayrNThgasv6ELwAp4uqCQGaiyYzxM8GE a2yTsggviijYz0dWB+I0wRg78D8PX2T/g7aIHB73mtKTTIc6vSbtRthjVu6vj4plL64lh8 15V+J6rtNOJHQstcHborSfjNA6aIG7k= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-482-ta9lZDMeNLKgdaWG8kQb9A-1; Fri, 05 Apr 2024 05:10:32 -0400 X-MC-Unique: ta9lZDMeNLKgdaWG8kQb9A-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a5198c1a6f4so56034766b.3 for ; Fri, 05 Apr 2024 02:10:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712308231; x=1712913031; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E+32tc+g6bFUi7eOalPmpwKSPNS4pCbzAaqy2IDSlhk=; b=iztpoXOqujBVUdhV/fVMUUUcDLgJMxxQ+l1rnLjQgg3gc9+oCHm2LfZCjbkgRS3fx2 VkVkITHwlyqvG9RButjivxy7B3e1cPbxfUwNVGQ64bDtRCZgMuWFArZsDwY2cONVCEln GnY2K94ne1c29DXRSkYcydfUoESGMvjlvLnCPFbibot+ROZ8InoZ/Sdvl1o8vF2voWuP Qwm4bPTqh0jHvB8c5Z2/kIFKSVKySXq9oCejk17fwuUpcSsPnpj9TC9W0QEkL95HwfNH 2FbykdqxK3Wp4VV+7LPozpUoPBiN3oi3X90tS4DjjYIY6dd3o112UEdjhMjJ5jH+TYq3 G6ng== X-Forwarded-Encrypted: i=1; AJvYcCUwQT0Gu4CkhaRxq3GS969fJkGs2YU281ppOijNXUIlIDXeRZf2EOUL1GZ2nYcel9k2dPeZl078V3qaVn8YYLSPOsAbMipueIzMguxm X-Gm-Message-State: AOJu0Yzx9hvn7FXXJqLEpQnfotvRBgsgieTWcehkE++rFobkRs3dv1We l8UYGvregxhrPVqyUvH3JKpIDr84LNRNTXb3vOdIa71rn7zkxHlFeutnVN13o/eC0H7pZl7enm6 hDCv7psK3eCDwtNTdZ5kW65AfgskWahfOXdIrQQbyIobDlK5vpOZxLHrv4nMEew== X-Received: by 2002:a17:907:7ea2:b0:a47:16d1:113f with SMTP id qb34-20020a1709077ea200b00a4716d1113fmr908612ejc.47.1712308231281; Fri, 05 Apr 2024 02:10:31 -0700 (PDT) X-Received: by 2002:a17:907:7ea2:b0:a47:16d1:113f with SMTP id qb34-20020a1709077ea200b00a4716d1113fmr908582ejc.47.1712308230994; Fri, 05 Apr 2024 02:10:30 -0700 (PDT) Received: from [192.168.0.182] (host-87-2-128-150.retail.telecomitalia.it. [87.2.128.150]) by smtp.gmail.com with ESMTPSA id v17-20020a170906b01100b00a46aba003eesm607927ejy.215.2024.04.05.02.10.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 02:10:30 -0700 (PDT) Message-ID: Date: Fri, 5 Apr 2024 11:10:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/15] sched/deadline: Make start_dl_timer callers more robust To: "Joel Fernandes (Google)" , linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider Cc: Suleiman Souhlal , Youssef Esmat , David Vernet , Thomas Gleixner , "Paul E . McKenney" , joseph.salisbury@canonical.com, Luca Abeni , Tommaso Cucinotta , Vineeth Pillai , Shuah Khan , Phil Auld References: <20240313012451.1693807-1-joel@joelfernandes.org> <20240313012451.1693807-14-joel@joelfernandes.org> Content-Language: en-US, pt-BR, it-IT From: Daniel Bristot de Oliveira In-Reply-To: <20240313012451.1693807-14-joel@joelfernandes.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/13/24 02:24, Joel Fernandes (Google) wrote: > For whatever reason, if start_dl_timer() returned 0 during replenish (it > did not start a new timer), then do not marked dl_defer_armed, because > we never really armed. > > Further, we need to cancel any old timers, > > This is similar to what dl_check_constrained_dl() does. > > Add some guardrails for such situations. > > Signed-off-by: Joel Fernandes (Google) Makes sense, added as part of the defer patch. -- Daniel