Received-SPF: pass (google.com: domain of linux-kernel+bounces-132720-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 5 Apr 2024 11:16:23 +0200
From: Horatiu Vultur - M31836 <Horatiu.Vultur@microchip.com>
To: Divya Koppera - I30481 <Divya.Koppera@microchip.com>
CC: "andrew@lunn.ch" <andrew@lunn.ch>, "hkallweit1@gmail.com"
	<hkallweit1@gmail.com>, "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"davem@davemloft.net" <davem@davemloft.net>, "edumazet@google.com"
	<edumazet@google.com>, "kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>, "richardcochran@gmail.com"
	<richardcochran@gmail.com>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, UNGLinuxDriver <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next 2/2] net: phy: micrel: lan8814: Add support for
 PTP_PF_PEROUT
Message-ID: <20240405091623.yxbx5pkoxqqokyr2@DEN-DL-M31836.microchip.com>
References: <20240404080115.450929-1-horatiu.vultur@microchip.com>
 <20240404080115.450929-3-horatiu.vultur@microchip.com>
 <CO1PR11MB4771B9B8238242DA6406CBE6E2032@CO1PR11MB4771.namprd11.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <CO1PR11MB4771B9B8238242DA6406CBE6E2032@CO1PR11MB4771.namprd11.prod.outlook.com>

The 04/05/2024 08:35, Divya Koppera - I30481 wrote:
> Hi Horatiu,

Hi Divya,

> > +	ts_on.tv_sec = rq->perout.on.sec;
> > +	ts_on.tv_nsec = rq->perout.on.nsec;
> > +	on_nsec = timespec64_to_ns(&ts_on);
> > +
> > +	ts_period.tv_sec = rq->perout.period.sec;
> > +	ts_period.tv_nsec = rq->perout.period.nsec;
> > +	period_nsec = timespec64_to_ns(&ts_period);
> > +
> > +	if (period_nsec < 200) {
> > +		pr_warn_ratelimited("%s: perout period too small, minimum
> > is 200 nsec\n",
> > +				    phydev_name(phydev));
> > +		return -EOPNOTSUPP;
> > +	}
> 
> Unlock is Missing in above and below conditions.

Thanks for the review.

Jakob already mention this in a previous comment[1]. And I already sent a
new version where this is fixed.

[1] https://lore.kernel.org/netdev/20240404094137.51b1397e@kernel.org/T/#m3053305f9a354ebf89e4dd0e6140f6cfbd2591e6

> 
> > +
> > +	if (on_nsec >= period_nsec) {
> > +		pr_warn_ratelimited("%s: pulse width must be smaller than
> > period\n",
> > +				    phydev_name(phydev));
> > +		return -EINVAL;
> > +	}
> > +
-- 
/Horatiu