Received-SPF: pass (google.com: domain of linux-kernel+bounces-132729-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240404045701.27284-1-rdunlap@infradead.org>
In-Reply-To: <20240404045701.27284-1-rdunlap@infradead.org>
From: Huacai Chen <chenhuacai@kernel.org>
Date: Fri, 5 Apr 2024 17:23:09 +0800
Message-ID: <CAAhV-H5FOWKCB7kXQ4KT2cOc=MwucnQeK3+vPtv+QgwCQmc2sA@mail.gmail.com>
Subject: Re: [PATCH] LoongArch: addrspace: add linux/sizes.h to prevent build errors
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>, 
	loongarch@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Queued, thanks.

Huacai

On Thu, Apr 4, 2024 at 12:57=E2=80=AFPM Randy Dunlap <rdunlap@infradead.org=
> wrote:
>
> LoongArch's include/asm/addrspace.h uses SZ_32M and SZ_16K, so add
> <linux/sizes.h> to provide those macros to prevent build errors:
>
> In file included from ../arch/loongarch/include/asm/io.h:11,
>                  from ../include/linux/io.h:13,
>                  from ../include/linux/io-64-nonatomic-lo-hi.h:5,
>                  from ../drivers/cxl/pci.c:4:
> ../include/asm-generic/io.h: In function 'ioport_map':
> ../arch/loongarch/include/asm/addrspace.h:124:25: error: 'SZ_32M' undecla=
red (first use in this function); did you mean 'PS_32M'?
>   124 | #define PCI_IOSIZE      SZ_32M
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Huacai Chen <chenhuacai@kernel.org>
> Cc: WANG Xuerui <kernel@xen0n.name>
> Cc: loongarch@lists.linux.dev
> ---
>  arch/loongarch/include/asm/addrspace.h |    1 +
>  1 file changed, 1 insertion(+)
>
> diff -- a/arch/loongarch/include/asm/addrspace.h b/arch/loongarch/include=
/asm/addrspace.h
> --- a/arch/loongarch/include/asm/addrspace.h
> +++ b/arch/loongarch/include/asm/addrspace.h
> @@ -11,6 +11,7 @@
>  #define _ASM_ADDRSPACE_H
>
>  #include <linux/const.h>
> +#include <linux/sizes.h>
>
>  #include <asm/loongarch.h>
>