Received-SPF: pass (google.com: domain of linux-kernel+bounces-132781-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 5 Apr 2024 11:54:57 +0200
From: Pavel Machek <pavel@ucw.cz>
To: Luigi311 <git@luigi311.com>
Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com,
	jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, sakari.ailus@linux.intel.com,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	phone-devel@vger.kernel.org
Subject: Re: [PATCH v3 12/25] media: i2c: imx258: Allow configuration of
 clock lane behaviour
Message-ID: <Zg/KcQ6OI5QhgMaI@duo.ucw.cz>
References: <20240403150355.189229-1-git@luigi311.com>
 <20240403150355.189229-13-git@luigi311.com>
 <Zg2kcI/1Gdgt0ilB@duo.ucw.cz>
 <6c15e492-411a-40aa-b02e-83b8a6d107da@luigi311.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="webUCHTtncLR1UEx"
Content-Disposition: inline
In-Reply-To: <6c15e492-411a-40aa-b02e-83b8a6d107da@luigi311.com>


--webUCHTtncLR1UEx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu 2024-04-04 16:29:11, Luigi311 wrote:
> On 4/3/24 12:48, Pavel Machek wrote:
> > Hi!
> >=20
> >> The sensor supports the clock lane either remaining in HS mode
> >> during frame blanking, or dropping to LP11.
> >>
> >> Add configuration of the mode via V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK.
> >=20
> >> +	ret =3D imx258_write_reg(imx258, IMX258_CLK_BLANK_STOP,
> >> +			       IMX258_REG_VALUE_08BIT,
> >> +			       imx258->csi2_flags & V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK ?
> >> +			       1 : 0);
> >=20
> > !! can be used to turn value into 1/0. I find it easier to read than ?
> > 1 : 0  combination, but possibly that's fine, too.
> >=20
> > Best regards,
> > 								Pavel
> >=20
>=20
> I assume you mean by using=20
>=20
> !!(imx258->csi2_flags & V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK)
>=20
> I can go ahead and use that instead

Yes, I'd do that.

Best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--webUCHTtncLR1UEx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZg/KcQAKCRAw5/Bqldv6
8mS+AKCFPh0X/iB6sA+t92hWIheMuvdPJgCgrDY5MXzkkvty0rnIgJpFyEfabBg=
=ZRF5
-----END PGP SIGNATURE-----

--webUCHTtncLR1UEx--