Received-SPF: pass (google.com: domain of linux-kernel+bounces-132795-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 5 Apr 2024 12:09:57 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Shahar Avidar <ikobh7@gmail.com>, linux-staging@lists.linux.dev,
	kernel-janitors@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"Felix N. Kimbu" <felixkimbu1@gmail.com>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Rob Herring <robh@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH v3 5/7] staging: pi433: Remove duplicated code using the
 "goto" error recovery scheme.
Message-ID: <2024040546-crudely-demanding-c13a@gregkh>
References: <20240405074000.3481217-6-ikobh7@gmail.com>
 <12a5180c-fbac-41dc-b1bf-9eded9d8c5ed@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <12a5180c-fbac-41dc-b1bf-9eded9d8c5ed@web.de>

On Fri, Apr 05, 2024 at 12:05:56PM +0200, Markus Elfring wrote:
> I suggest to use the summary phrase “Use common error handling code
> in pi433_init()” instead.
> 
> 
> > pi433_init had "unregister_chrdev" called twice.
> > Remove it using goto statements.
> 
> How do you think about to use the following change description?
> 
>    unregister_chrdev() was called in two if branches.
>    Thus add jump targets so that a bit of exception handling can be better
>    reused at the end of this function implementation.
> 
> 
> …
> v2->v3:
> …
>           a seperate patch.
> …
> 
> Would you like to avoid a typo here?
> 
> Regards,
> Markus
> 

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot