Received-SPF: pass (google.com: domain of linux-kernel+bounces-132799-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <569849e6-0bf5-485c-b22e-cbf05ddaa2b5@intel.com>
Date: Fri, 5 Apr 2024 12:12:46 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v9 4/9] slab: introduce kvmalloc_array_node() and
 kvcalloc_node()
Content-Language: en-US
To: Alexander Lobakin <aleksander.lobakin@intel.com>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
CC: Alexander Duyck <alexanderduyck@fb.com>, Yunsheng Lin
	<linyunsheng@huawei.com>, Jesper Dangaard Brouer <hawk@kernel.org>, "Ilias
 Apalodimas" <ilias.apalodimas@linaro.org>, Christoph Lameter <cl@linux.com>,
	Vlastimil Babka <vbabka@suse.cz>, Andrew Morton <akpm@linux-foundation.org>,
	<nex.sw.ncis.osdt.itp.upstreaming@intel.com>, <netdev@vger.kernel.org>,
	<intel-wired-lan@lists.osuosl.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
References: <20240404154402.3581254-1-aleksander.lobakin@intel.com>
 <20240404154402.3581254-5-aleksander.lobakin@intel.com>
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20240404154402.3581254-5-aleksander.lobakin@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFE1QkNDZGMzSkZkUDZqM2kyTWVZTVZ0NVZ5ZXFTNzVYZEI5cFNBcU8zeGJI?=
 =?utf-8?B?VmVvc3pyQkJVUlVQczJjNXFQRHpXc1pqNERISC9FenNHLy84RTc1cjM5Y0hJ?=
 =?utf-8?B?ZEx6ZEFjWVFKMVg5cXpFQ3p6WGdkaTFEVjFzekJmM2FzODRFYldieDBoUUVq?=
 =?utf-8?B?VE8yMFdrellYd0VCbHYxYnhHSkxLRXFGVEowdXdZYmtPbU9lUmR0REFuck5h?=
 =?utf-8?B?MEVGbDIza1kyUEVXZ1I3VjJFZDdQTkYxZmpvUC9RbEx1aldxbzgzV1l2VStF?=
 =?utf-8?B?NE9QeTdMK1Z6dzAzeEQybFA5WlRDNnBFNHp0d1MvbytScnk0dC9HdC8wNjhz?=
 =?utf-8?B?dURnN25ZVW9EdExHeWczTFhsUEc3VXhyV1NpNjVSMG81bS9ydGxkR1I1OThw?=
 =?utf-8?B?eVRhaC9NbGZEcTg3UkpIM3E3NExFVHhHeGp4dFVraEhLam5HVnVvY1FUSWpC?=
 =?utf-8?B?YTI0Q3FEV2NtN3E4b2VSUVJmZEtveXBxRjJmcmpMbkgzL3lNaEc2aElUajJ3?=
 =?utf-8?B?TTUzc0dmYXRlQ2VkaTIzcDFwMXZETXhzQ1F6VmlEZ01JNEFsZHZvZVphWFN1?=
 =?utf-8?B?SlFHTS9oOEhKdEs2L1oyRWlpVjB4d2c1Snd1c0xQRFdyNmV6VDE0aDlweSsw?=
 =?utf-8?B?OStJOWpkUzMyTEZ6RWZWdmtlVDlpdWtndFhSc3R4aU9IRVZGMEd3WHJPZ0g3?=
 =?utf-8?B?U0JNM1Y0NHFpdUtPeFNjK042SGt2dlkwRDhYa2liR05FbEJGMWh3S3B1QVFZ?=
 =?utf-8?B?WFF4WlVLUThpc0dHOWV0K25FVGFKaWk0TVRwaU1xRkRpUHFvRS9yaWQycUNT?=
 =?utf-8?B?eXI0YW5XYjJJSnpyUFNGeEs1NEpKUi9RTDVxOVhDZllNVHRWZmdWSG8vZVlj?=
 =?utf-8?B?MTk3YzF5Y0t5MnpaKzNnM1VCMGhYamJJQ0ZIWnFUeUpRclNQUzFkZzJwOElr?=
 =?utf-8?B?Y1d0b1A0T2tuZGJseFRjTGRZR01yVXMrSktrZUVlQUZUZTV0L3FNOHh0VDI4?=
 =?utf-8?B?aEErK3JOdWc4akxNVGVteHFDUVlTSkxPalpCaFdnWElkVnp1d05aZlJFRjVa?=
 =?utf-8?B?TEFRMkVFUzdGSkRhZVJHYjFiM2h3RUgrS3NyT3pmbWxnWld0amMvWld4ZmhT?=
 =?utf-8?B?blpHcUxUYlFIOFNDOVJQb2Z5dHBmTGlnUVV0Wkcyek9KbHB0UjZldjEvNHJp?=
 =?utf-8?B?VE5MNXlBZDFjZElCOXZaUjJUcS9VNVorelRqU2FaUDE4UEMxNi9ScWt4dDVx?=
 =?utf-8?B?Mm1WRnA4VUUxeFI2K3VucS9USkpSWGxxWHNkNHZrSEdWb3BSbFJPQ29xem95?=
 =?utf-8?B?UXRPOVNKY1puZ0gzRmwwdXJ0dTd1alR5RlBzQXJDdmM3bWdOUTVsZGlzRmQ2?=
 =?utf-8?B?THduTFM4QVpBdGliWVFwQjBoT1ZBdmpKQnRtOTlXM2srK3VWbU5GTDRycDVF?=
 =?utf-8?B?YlRaTE1qQXl3VnlBME4zU0ZCVXBvUVFlQ1pqQVkxWnNqaVFVTVNTTjU3U0tm?=
 =?utf-8?B?WmtHcURBZFFPK2F0eCtramc4WVFNTG1Mc29oZUxNVWwwMXlJZitsUnh4bXJq?=
 =?utf-8?B?ZGppb0xzSVpSczZ0aEhjNlFnVFlYQUdwajM2Y1libytvWWNyaFZpRVdaQlhK?=
 =?utf-8?B?UlQxSGNvS09zM1BOazdES3FaaVk1L3hDK1l0dzMwemtYS1RrdU5kTmNjWC90?=
 =?utf-8?B?OHo5Y0syazB5UG1TZkd0RmkwQXlpbEhNWUQ5QU5vWG9LK3FpVUlwb2lqUFFq?=
 =?utf-8?B?ZXNBTTZiYlQvMjNqTFVtMXJTM1JVc0xwb1hDbXVNUWN1VWVzelRBOEUreG1q?=
 =?utf-8?B?WEJwVGhuYlR3K0RsOTJ5azYwQ0xWbzFDYWwxb3F2RmM4UE9DLytlVHl2dUlr?=
 =?utf-8?B?VzBUaXBjLzE4RG9WeUhwVGtNaU9ZK1ZMbGswSllRQU5IL0V2ZG1ZcG91WS9W?=
 =?utf-8?B?ZFc2d1pqeURMOW1OQ2lvNU5ValR4N0ZzN0RUbWdGUEorSWtGVXVYeUZVb3dP?=
 =?utf-8?B?R3F6UnFBVjR2UU9vZkxaKzZsS1l0OHBCVjRBUWRQUjBRSldDbUc0cThaK0di?=
 =?utf-8?B?MDdna0w5bEZSL211YS9xMHI2aEhOOUlkdHR4alFsQmROcnQ1VVBGaUdMVmF6?=
 =?utf-8?B?MVVUQVh3MGJaMnZWZjhPTi9Kc0dXcld4SVBxNXV5aUJ4bkJSR0lHaTZWRmxk?=
 =?utf-8?B?U3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 96ca8373-bb2b-4ba8-8f03-08dc5558f416
X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 10:12:52.1634
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kkMraC9CyJXnzTm/BBtt67uwFXAr4zjmcbBItljvtG3Av0nRu5v8a3H/TB6gt2fBQ6m4xgNQTH9l2hmkdANhaeU7suWz4RTpF+g+rN/UiIM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4646
X-OriginatorOrg: intel.com

On 4/4/24 17:43, Alexander Lobakin wrote:
> Add NUMA-aware counterparts for kvmalloc_array() and kvcalloc() to be
> able to flexibly allocate arrays for a particular node.
> Rewrite kvmalloc_array() to kvmalloc_array_node(NUMA_NO_NODE) call.
> 
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> ---
>   include/linux/slab.h | 17 +++++++++++++++--
>   1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/slab.h b/include/linux/slab.h
> index e53cbfa18325..d1d1fa5e7983 100644
> --- a/include/linux/slab.h
> +++ b/include/linux/slab.h
> @@ -774,14 +774,27 @@ static inline __alloc_size(1) void *kvzalloc(size_t size, gfp_t flags)
>   	return kvmalloc(size, flags | __GFP_ZERO);
>   }
>   
> -static inline __alloc_size(1, 2) void *kvmalloc_array(size_t n, size_t size, gfp_t flags)
> +static inline __alloc_size(1, 2) void *
> +kvmalloc_array_node(size_t n, size_t size, gfp_t flags, int node)
>   {
>   	size_t bytes;
>   
>   	if (unlikely(check_mul_overflow(n, size, &bytes)))
>   		return NULL;
>   
> -	return kvmalloc(bytes, flags);
> +	return kvmalloc_node(bytes, flags, node);
> +}
> +
> +static inline __alloc_size(1, 2) void *
> +kvmalloc_array(size_t n, size_t size, gfp_t flags)
> +{
> +	return kvmalloc_array_node(n, size, flags, NUMA_NO_NODE);
> +}
> +
> +static inline __alloc_size(1, 2) void *
> +kvcalloc_node(size_t n, size_t size, gfp_t flags, int node)
> +{
> +	return kvmalloc_array_node(n, size, flags | __GFP_ZERO, node);
>   }
>   
>   static inline __alloc_size(1, 2) void *kvcalloc(size_t n, size_t size, gfp_t flags)

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>