Received-SPF: pass (google.com: domain of linux-kernel+bounces-132844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <f0cb08d3-00a5-4ed1-adf1-05f40875c510@web.de>
Date: Fri, 5 Apr 2024 12:42:38 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Shahar Avidar <ikobh7@gmail.com>, linux-staging@lists.linux.dev,
 kernel-janitors@vger.kernel.org,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 "Felix N. Kimbu" <felixkimbu1@gmail.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Hans Verkuil <hverkuil-cisco@xs4all.nl>, Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
 Dan Carpenter <dan.carpenter@linaro.org>
References: <20240405074000.3481217-7-ikobh7@gmail.com>
Subject: Re: [PATCH v3 6/7] staging: pi433: Add debugfs_remove in case of
 driver register fails.
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240405074000.3481217-7-ikobh7@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:sHoSA0adK7U=;BmEev2IrjKj4JG7kD3JEGVdUydM
 v7PvTR4wFJlwfSIwjIVZLAGnTd5SXewMjTxXRTFvpwMQJDIHygFahK8quWhIc7l8LImIBKxq3
 J2VyPDOXsStOGLcPfIRJN5tZjlVEbxBzUKBHGDpy06Is5fUrkvrheoWXET5U8XR8VY1oZj4Jh
 55TfsGXcuJGq5NzxmkHQ8E2495Z1/CuMPASm9Ff078ZqO2rKyKQIL6CvJdjNwzH8U9OSxOo+A
 xYCGHu5U/morsY1gqVsaCjCaoftyddEfr2M3/LX5fvS6ooDgXjIZisnqBuEQ02aZDmhdHti4X
 2PfjkuohfRK9ch4D8DtkthAPhXnO4MDeU88f4oPMsAkX+EID0w8XaJEyYk4aOboku8dRnjltI
 wFQXYEyLqH4ZXpOeME29aSJbbrZHvzSvDfp0VBOleXqoJLB+3EqFlpVbLuT6MtugTF6YSZD+W
 IxCxRf402jWu6fbuAETipbbKXugrtxgx5Re3jAQL4OccLXLg0QRrGUpI2BpbOVd8fUjuyVPkb
 p43VkE5f31ThKxgDQM1bQJV74c184SHCsAVnxGMABvt+gs6+zItM9Jh4dgUo2pMFPDV02L80P
 S8AyboP7uxCbeiwyKqyACTIOVDv35T9QY066xjEWBIp/PWGcNjmi3E71nF/xmxOE2vPfAaDy1
 9k6xGnMWc8vLZg5JuElv7sle5jz4DrXQaX6IbNMSmdj23X6qhsQYWdLx89qT+fGiFOVAG9WnO
 RRywZ7yRpRlsijuedh3zzIE5L9pc7rQDrKaV5szNV0ZnaHFMaDTp4EPkyFsmMrgTDzXkXVq0m
 i6KygoM1yRuFsS7sWKbL+LMAqtjNlu3Ll8fXvqDk/tgM8=

I suggest to use the summary phrase =E2=80=9CCall debugfs_remove() in case=
 of
driver registration failure in pi433_init()=E2=80=9D instead.


> debugfs resources were never cleaned in case of failure to register driv=
er.

How do you think about to use a change description like the following?

   Debugfs resources were not released after a call of
   the function =E2=80=9Cspi_register_driver=E2=80=9D failed.
   Thus fix the exception handling accordingly.


Regards,
Markus