Received-SPF: pass (google.com: domain of linux-kernel+bounces-132851-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 5 Apr 2024 12:50:45 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Shahar Avidar <ikobh7@gmail.com>, linux-staging@lists.linux.dev,
	kernel-janitors@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"Felix N. Kimbu" <felixkimbu1@gmail.com>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Rob Herring <robh@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH v3 6/7] staging: pi433: Add debugfs_remove in case of
 driver register fails.
Message-ID: <2024040538-voice-debit-b8be@gregkh>
References: <20240405074000.3481217-7-ikobh7@gmail.com>
 <f0cb08d3-00a5-4ed1-adf1-05f40875c510@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f0cb08d3-00a5-4ed1-adf1-05f40875c510@web.de>

On Fri, Apr 05, 2024 at 12:42:38PM +0200, Markus Elfring wrote:
> I suggest to use the summary phrase “Call debugfs_remove() in case of
> driver registration failure in pi433_init()” instead.
> 
> 
> > debugfs resources were never cleaned in case of failure to register driver.
> 
> How do you think about to use a change description like the following?
> 
>    Debugfs resources were not released after a call of
>    the function “spi_register_driver” failed.
>    Thus fix the exception handling accordingly.
> 
> 
> Regards,
> Markus
> 

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot