Received-SPF: pass (google.com: domain of linux-kernel+bounces-132866-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <2e82a05d-f0b4-4967-a6d0-11f9282e3058@oracle.com>
Date: Fri, 5 Apr 2024 11:55:41 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 00/10] block atomic writes
To: Kent Overstreet <kent.overstreet@linux.dev>,
        Dave Chinner <david@fromorbit.com>
Cc: Matthew Wilcox <willy@infradead.org>, axboe@kernel.dk, kbusch@kernel.org,
        hch@lst.de, sagi@grimberg.me, jejb@linux.ibm.com,
        martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk,
        brauner@kernel.org, dchinner@redhat.com, jack@suse.cz,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org,
        ojaswin@linux.ibm.com, linux-aio@kvack.org,
        linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org,
        nilay@linux.ibm.com, ritesh.list@gmail.com
References: <20240326133813.3224593-1-john.g.garry@oracle.com>
 <ZgOXb_oZjsUU12YL@casper.infradead.org>
 <ZgSCMXKtcYWhxR7e@dread.disaster.area>
 <62uvkga54im76lnz47nc2znoeayidp2tcwpffseqtl42xdwxlc@hep6ckbgpwqz>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <62uvkga54im76lnz47nc2znoeayidp2tcwpffseqtl42xdwxlc@hep6ckbgpwqz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?TWgycTlFNkJXd3ZWVXRyMTJwaE1EVGF4ZUcvREdaYjl1UUlLR1JJRkpicHVw?=
 =?utf-8?B?anV3Y0lZcWQ4T1hndkozaHU1Y3k2aW1JeUFTeHdjS3BCbm0rS2NaTXVXcXU1?=
 =?utf-8?B?b0RHaUREYlFCUnQrUGxQcUc1NTFsMEVGSVZZSGY4Q3dDUG9PdFZhTFg1eTdK?=
 =?utf-8?B?YU51d2k3dHNzcmF6bEo2bGF1VDBjaU1kaTVQUXRKNGwzU2JxRFZMWlV1dUx4?=
 =?utf-8?B?eHgzWVE5ZDJHQ2VKNlVVQVdGMzFNVnFNYnNsSWZVVlp2bGFZdmdzNUV5TmFt?=
 =?utf-8?B?S0VCME5oZTJzZVY5aWZNRWEySmg0bGNvcFNxSThQakQ1UFUrYXRvekVweHcx?=
 =?utf-8?B?UFF1a1Y1SFNXaUFYWDUzSmR5dUpuVC8rVjRWdGQyVjB4cUZ3eU8xS0lJWnJW?=
 =?utf-8?B?VjZNc3pjOFk4WEEybEdDUjFoTkwvVWM4ZjN1ekQvanllbVhzSjhzUU8xcm40?=
 =?utf-8?B?dWt1UUhMQ0pZL3pzOVBSQ1JYTmNtUnRjTmFKWGd3Ui9CaGJYL2F0MDhUZSsx?=
 =?utf-8?B?Q2xzL1UzOFNBR2NGa0c3U0RvcTRBMThSRWlkS1lrWXVBc2s0L21yMndkbVQw?=
 =?utf-8?B?SUYwanhqZFZTcjdmV3AwRWxCS2lMeTdGM1I4Wk5jOCtsMmtSV3h0enM3QW5O?=
 =?utf-8?B?S09Ya2VlRXF4YzdKZWlrVnVNODJqRFFxQTgvT1FCa3RLSTNuZm85N3hVMmJq?=
 =?utf-8?B?MnFuTktockhtWTBURHY2TXdLd0dVSlFmTDF0UmhmdlJBa2dLaXA4OG5rOTZ1?=
 =?utf-8?B?ZU5sQW9SY250WVQxcHFnRW9XSWltSEZDSk1kMGZnenV1dDZzMCtQNDZFU010?=
 =?utf-8?B?YU00TFJ3SmtYcGM3eGg3SGttQkVpNVdRM2xyOE9ER0crdHZJTWpaZVRiMzRQ?=
 =?utf-8?B?VnYxaGtEaGVUL0xUYmdUTk5LSFJLREFGeERFY2E0bHc4c010SU02RGgzUm9z?=
 =?utf-8?B?ZGVqOVF0N2RHaTVMRzlCWWZweDdJcng2TFdFTGU2U3BJYUNkZHRYWGVvdWw4?=
 =?utf-8?B?WmJEWGd1RHNYRDNRV1ZDM3M3N05qN0VqNXZ0bFpDVDluTWtxRlUzNVlNOE84?=
 =?utf-8?B?S1pEU1A2TFBhUXYyRHBWOTVtVmtzUzFkblNYUFpaR2F5Z1d2N1FidEFsdCtj?=
 =?utf-8?B?ZGNCK0Z3S0kvVTlqcE1Hbnd0TndNajJzWWNORUFaQ2RZZUJvN0pDbWZZTldN?=
 =?utf-8?B?K1pGZDNQMWdFN3ZBdVJ3KzRLL2MyenJUL2NOeHBrdzFvRU9wMTY4bmZXL2ty?=
 =?utf-8?B?eVZnbkF3RmRCNnVQVmx4WkpsUDBSTFFJcys5SUE1a0lpNnVlSWlvaDNpeWRt?=
 =?utf-8?B?S2tEZ1FCZTZGNmZpMkxITkF2Q1UrMUxEbWlyMEsxaVhoTFZwdGFQMEpoeEQ4?=
 =?utf-8?B?NmxSZ0N2bjhST0ErUC9TOVdFVTRGUnlGVFhRZlQvTW5PNEsyZnJMNHRNTzZj?=
 =?utf-8?B?UnhrRk0yYlVwdy9udVFqOUdZSUtTdjlJQ1dyQnJFUjlQeERUMWZPemRndjlR?=
 =?utf-8?B?TDEzS1BxV2F5ME5EZW5ZSnY4ZmZOcTVySy9MVjZIa2F0VjZpZS8vcmtnQWdl?=
 =?utf-8?B?YklGVjNRT1pna1ExUlhZbGpVNzVnYm1UaG1aWDlDQXBNZVlBNTNiMXZiSjlB?=
 =?utf-8?B?eGRUMnJPYUp6eGtLTno1NmZYSFgxSll6Zjk2V0dxM2Z4NHAwQmgxbXlIUXZl?=
 =?utf-8?B?eDJuRFU4Q1lGZHlBVHBJVHVmK25ZMzdmdnZKUy9FOWdtdjFDdW43dWJvOXln?=
 =?utf-8?B?N2JDQmw5SVBpcnFVRm9oZWl5eXB1aXJQRWJHK2JPdHJyUnlvajNiM1lGb1Nq?=
 =?utf-8?B?Wldmd3VKdkpNc2dFNVNpY1llK05tVEh4dWVYK0NjZ2VZWk40b3Fud1Yra2J1?=
 =?utf-8?B?cEpNc3BWUVJMcVFiYk1kaTJkOWJTbUZCdnp0TkFsVDArNUEra1VrUmQ1K1li?=
 =?utf-8?B?Q1pGalVyUVp2UlZDalNVZ3R6L2JtOXlEL2ZtQzZSZ1owUUovVTh0ODVzcjJz?=
 =?utf-8?B?MHhYVEg0dG9taTBIb1ErVHA0YmJvdDJGYUZleVlVNk5hcEZiVUZvTjBuTFpk?=
 =?utf-8?B?aSt0Wi9qbGdmY3h0R0Fya2VyczFzd3lKTFEyU0lPeUVldFo4SDh2Tm1hMlJO?=
 =?utf-8?Q?JvMf2wjts72hArLwwXGGuvQ/O?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	e3ge0v7J7OdcUNOhzSW6MEIqOb8Tg/MeOAjnivi9tt17uIrp1q5c7Fut/ruNKmnFlA5QX9ql1O3dzELAf5twjqyNw0PyD0KYXKJRmviJftbRdmFO3OuCM/8R3PVHcQ17f8DkyindF0VTtW/U7tbwi/Ok+mzj0a1auQpvWCbSqTuiljtfKcrae+R2wRV6bsfP9TJA51oc/t98V3e7toHnOxr42pX1U137z4IOZA4dVVxszhaxifcrzskExJimekXf7lRU8YGg1JTWF5v6IC1wd73xx45k8TDifgyRoUOKyD/rVhvWXkjJagWcdTFP9D3Yj1ePIiks/oeGUfuB7itCxOAjUzTs8ldh8xAsFb1LyhhGZjBZ6ArbdN2e5QagwrTVsTrwZk1SFKYbiB5YU4Q254rsEdZkGuiCnXuRSwjgG27IOm6ZmK1w3ZFbBg+b8/S0abfDsetWpw+otdMHRl1cExJjvyD2pYDACOL8yoYcDA+6DU4ysySOJvIaEnz1n3UhT651+A42Po3bPQl7zTf7L2T6vENHb1GmgZAyT3MVpu5kYhQ/vkHH21f2x/jl2lKKJ8DV7Nqtm/d0nN+Out7spNoXdQABqfKXatILslj7zfc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c91553fe-dbfe-458d-2d26-08dc555ef305
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 10:55:47.4523
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cahxDEK3x8EBo1gJNHutCir5TK+onDXZzkF7DGDT6Jfzrk0vzfY0QFb8aaSlvDAHXtoAd3C6EmxkzXY7AiFmmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4808
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-05_10,2024-04-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0 bulkscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404050079
X-Proofpoint-GUID: Pxy3z_N-4gG6LrpX2hfgn3WSbHRTXDCU
X-Proofpoint-ORIG-GUID: Pxy3z_N-4gG6LrpX2hfgn3WSbHRTXDCU

On 05/04/2024 11:20, Kent Overstreet wrote:
>>> The thing is that there's no requirement for an interface as complex as
>>> the one you're proposing here.  I've talked to a few database people
>>> and all they want is to increase the untorn write boundary from "one
>>> disc block" to one database block, typically 8kB or 16kB.
>>>
>>> So they would be quite happy with a much simpler interface where they
>>> set the inode block size at inode creation time, and then all writes to
>>> that inode were guaranteed to be untorn.  This would also be simpler to
>>> implement for buffered writes.
>> You're conflating filesystem functionality that applications will use
>> with hardware and block-layer enablement that filesystems and
>> filesystem utilities need to configure the filesystem in ways that
>> allow users to make use of atomic write capability of the hardware.
>>
>> The block layer functionality needs to export everything that the
>> hardware can do and filesystems will make use of. The actual
>> application usage and setup of atomic writes at the filesystem/page
>> cache layer is a separate problem.  i.e. The block layer interfaces
>> need only support direct IO and expose limits for issuing atomic
>> direct IO, and nothing more. All the more complex stuff to make it
>> "easy to use" is filesystem level functionality and completely
>> outside the scope of this patchset....
> A CoW filesystem can implement atomic writes without any block device
> support. It seems to me that might have been the easier place to start -
> start by getting the APIs right, then do all the plumbing for efficient
> untorn writes on non CoW filesystems...

03/10 and 04/10 in this series define the user API, i.e. RWF_ATOMIC and 
statx updates.

Any filesystem-specific changes - like in 
https://lore.kernel.org/linux-xfs/20240304130428.13026-1-john.g.garry@oracle.com/ 
- are just for enabling this API for that filesystem.