Received-SPF: pass (google.com: domain of linux-kernel+bounces-132899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 5 Apr 2024 08:21:00 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: David Ahern <dsahern@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Christoph Hellwig <hch@infradead.org>,
	Saeed Mahameed <saeed@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Leon Romanovsky <leonro@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
	Leonid Bloch <lbloch@nvidia.com>, Itay Avraham <itayavr@nvidia.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Aron Silverton <aron.silverton@oracle.com>,
	linux-kernel@vger.kernel.org,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Andy Gospodarek <andrew.gospodarek@broadcom.com>
Subject: Re: [PATCH V4 0/5] mlx5 ConnectX control misc driver
Message-ID: <20240405112100.GC5383@nvidia.com>
References: <Zf2n02q0GevGdS-Z@C02YVCJELVCG>
 <20240322135826.1c4655e2@kernel.org>
 <e5c61607-4d66-4cd8-bf45-0aac2b3af126@kernel.org>
 <20240322154027.5555780a@kernel.org>
 <1cd2a70c-17b8-4421-b70b-3c0199a84a6a@kernel.org>
 <0ea32dd4-f408-5870-77eb-f18899f1ad44@gmail.com>
 <20240402184055.GP946323@nvidia.com>
 <83025203-fefb-d828-724d-259e5df7c1b2@gmail.com>
 <20240404183305.GM1723999@nvidia.com>
 <1bb526d4-31ac-b25d-e494-ef5adbaef7ac@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1bb526d4-31ac-b25d-e494-ef5adbaef7ac@gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?TjW37yaJ0LMtZYR6GfRlYlNhuU4KjGGZzigd0TOfJ43/m43J6HdzGcUu0C8d?=
 =?us-ascii?Q?scaFdn74TdX+tbUDSzvo1YkoOaHF6dHpK/TNO1yPBxphfoLink5xgDO6Ry78?=
 =?us-ascii?Q?bXIBrX5UIbs2YW7js2t7nu300uwubhIF4Fiw9rBXMBOrBMoOBGMUViam5S5r?=
 =?us-ascii?Q?5R9/EDghuYBiVK7Nifx/SORoTdibrCGfB5Uhr26018t/wC8i7GKi5VL2PiM/?=
 =?us-ascii?Q?os77wKuxnx5fDDCAsngMlYGs4UJNZYx2qhJh7mKRNF0bbTh3SZRmWSmjfJUg?=
 =?us-ascii?Q?8pZz6TdiHHjbf6EIROYkRRoOWejMzU0ybJY37KGYTsO/FB6ftE6jKN8PGkkh?=
 =?us-ascii?Q?4Kr3UFZD4zl3+RM6IPWNgwg9ArY+rDPUKPfgYkxVz37ype47iD53RpcDyXDO?=
 =?us-ascii?Q?X1VKhhO251o8IxsyUEAGOAiBlG6m5VCNZvLjeUAcpQWosMsqkHKKmIPLfw5J?=
 =?us-ascii?Q?dXexRhyn1fYNO7igLc8jvlTX3IsSSEJGMvhgp6M1sbGth0+u32J6rb95C/lB?=
 =?us-ascii?Q?x/rnC9Wbm80OJiDtA3s2z0UiVKiSSdPI6l2DXQUevcRY41rQRFGeUu3fC6hy?=
 =?us-ascii?Q?ehTc/16FfqJ80gPhSPm4RBy6iv2AQwUYdSBIFTLQgR8jxKQpJW000VsDwW3K?=
 =?us-ascii?Q?VKcooIIKcYQrjPrX3EpdEretVJUb74148yNkMn/MWho12kVAfA362IFMZLTa?=
 =?us-ascii?Q?SKAU2kVk/vrLKY89qAneJew5fdaZ4xyRI4zblIiOKOVXPiepMDxhqBhXlngY?=
 =?us-ascii?Q?FmzD5u/WvtbsbWvkuIgSpxo/03QKT6nzZ+4+WoRTTCjBNgYjJk4G+Kh4JmmY?=
 =?us-ascii?Q?2RqiQZJkiCvaPNSqRTMw/xS1+OEFjslJjrPthG1XIWGrmhc20jLug7nsFkMY?=
 =?us-ascii?Q?1U2jRmZXezwsSIyYevTVSPKo4RRqOLKGeCQ3H972uR3uJc9hUPEqmqSYxAzv?=
 =?us-ascii?Q?um8EqLTNdSOP8+zCpn9gBtQnOmXDaO0DbQLgl7GuYoEglVpOK8QmDKxtTlnW?=
 =?us-ascii?Q?ohF9Oiy0YyV77qfFgkiD3KgVkopzl41kFIAXO9YByuAlkPP9SzwB/Mq4VI1V?=
 =?us-ascii?Q?Uo9fCjpdMsp+TfIfc2h9uoSxFbd02/yNwz78mcKjv2U08xunqZek7wofwGOR?=
 =?us-ascii?Q?22UfllV4zNsx/+Uip+uy4i1a8OT87+/sfqSzbkiVy2H03llvKMFFoJlP5S+e?=
 =?us-ascii?Q?DX36sdOKcc0aKTjwvwQqFaP75R88rI/13Vm2ebKoPBOO7eSPWfqkmQzJUKha?=
 =?us-ascii?Q?I2YFo5wViCnBTLbcpolJqdshi1ZJ5slSQi4+x39T9UXVXjlYZNVbSjiXYwrn?=
 =?us-ascii?Q?CcOHqYYiE50nk2WyFKAUzDZM9VQ/TDbkT9osLNXWVn1z1a3iGaAMYN7cMypO?=
 =?us-ascii?Q?ze8MkaMrNZshKSlvjebdDKoHpbDjZN8yQvyuME0FAz0INGJTMl0xLI1FJTJ4?=
 =?us-ascii?Q?sKefKGNF73as7Neo2cyKYJxo4Q5zPbuiEo7MqPXmwP56mm2RThhzoqJYLlhw?=
 =?us-ascii?Q?GdBTxyM0kJeDPFqsvJ3V4mKSctUc+LUlkQPA6ojCJT1+eqoKyORowbe69+OJ?=
 =?us-ascii?Q?L3C4oZ0bMVpZpr/Wosw/CpFlKteDN6LyI9gU4ZMu?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3755c69f-14bf-4ea2-98f0-08dc556279a4
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 11:21:01.7042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9HnlcdCu3IfSbRfgilZq8SKWvf6abH8W9QjehwXdAGkqH3RaQ5xthU6hYjI5gUz/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6326

On Thu, Apr 04, 2024 at 08:31:24PM +0100, Edward Cree wrote:
> > of in the factory looses the "implied engineering benefits of open
> > source".
> 
> You're looking at the wrong point on the causal graph.
> Whether you apply the hacks in the factory or at runtime, their hacky
>  design is what prevents them from having the benefits of open source
>  (because those benefits consist of a development process that weeds
>  out hacks and bad design).

Oh please. They are not hacks, you are inventing this idea entirely
out of thin air based on your own lack of detailed knowledge or
personal aesthetic preferences.

> > Overreach. The job of the kernel maintainer is to review the driver
> > software, not the device design.
> 
> Really? [1]

Yep. TOEs are supported in the RDMA stack.

The only thing the kernel community decided was that a TOE cannot be
accessed using the socket API, the HW is still supported.

> But strangely, there are people out there who trust the upstream process
>  to ensure quality/security/etc. more than they trust vendors and their
>  "oh don't worry, the device will enforce security scopes on these raw
>  commands from userspace" magic firmware blobs.

Upstream Linux community has already decided trusting firwmare is
acceptable. I gave many examples in the fwctl document if you'd care
to understand it.

And of course we get the usual garbage solution "oh just fork linux"
which *completely misses the point* of what Linux really is or what
the community is fundamentally seeking to achieve.

> What you are asking for here is a special exemption to all those
>  requirements and security measures because "just trust me bro".

Actually no, fwctl is following accepted kernel design principles with
many prior examples.

Jason