Received-SPF: pass (google.com: domain of linux-kernel+bounces-132903-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <7c616ed5-fd80-7afc-a881-9f21e85ea6b6@quicinc.com>
Date: Fri, 5 Apr 2024 16:52:40 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: qcs6490-rb3gen2: Enable various
 remoteprocs
Content-Language: en-US
To: Bjorn Andersson <quic_bjorande@quicinc.com>
CC: Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        Rob Herring <robh@kernel.org>,
        "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_tsoni@quicinc.com>
References: <20240402090349.30172-1-quic_kbajaj@quicinc.com>
 <20240402090349.30172-3-quic_kbajaj@quicinc.com>
 <Zg9nmVl9eqTbkkDe@hu-bjorande-lv.qualcomm.com>
From: Komal Bajaj <quic_kbajaj@quicinc.com>
In-Reply-To: <Zg9nmVl9eqTbkkDe@hu-bjorande-lv.qualcomm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 4/5/2024 8:23 AM, Bjorn Andersson wrote:
> On Tue, Apr 02, 2024 at 02:33:49PM +0530, Komal Bajaj wrote:
>> Enable the ADSP, CDSP and WPSS that are found on qcs6490-rb3gen2.
>>
>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> index 97824c769ba3..a25431ddf922 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> @@ -434,6 +434,21 @@ &qupv3_id_0 {
>>   	status = "okay";
>>   };
>>
>> +&remoteproc_adsp {
>> +	firmware-name = "qcom/qcm6490/adsp.mbn";
> 
> Should this be qcm6490?
>  >
> I already proposed a patch to add adsp and cdsp, using qcs6490, and this
> was merged earlier this week. Please pay attention and review patches
> posted on the public list.

Apologies, I missed that.
Will drop adsp and cdsp firmware path update in the next series.

Rebase this change on top of your change, also will add the firmware 
path update for modem for GPS usecase.

Thanks
Komal

> 
> Either way, this will now have to be rebased on linux-next.
> 
> Thanks,
> Bjorn
> 
>> +	status = "okay";
>> +};
>> +
>> +&remoteproc_cdsp {
>> +	firmware-name = "qcom/qcm6490/cdsp.mbn";
>> +	status = "okay";
>> +};
>> +
>> +&remoteproc_wpss {
>> +	firmware-name = "qcom/qcm6490/wpss.mbn";
>> +	status = "okay";
>> +};
>> +
>>   &tlmm {
>>   	gpio-reserved-ranges = <32 2>, /* ADSP */
>>   			       <48 4>; /* NFC */
>> --
>> 2.42.0
>>