Received-SPF: pass (google.com: domain of linux-kernel+bounces-132924-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Martin Steigerwald <martin@lichtvoll.de>
To: linux-pm@vger.kernel.org, regressions@lists.linux.dev,
 linux-kernel@vger.kernel.org,
 Linux regressions mailing list <regressions@lists.linux.dev>
Subject:
 Re: [regression] 6.8.1: fails to hibernate with
 pm_runtime_force_suspend+0x0/0x120 returns -16
Date: Fri, 05 Apr 2024 13:49:00 +0200
Message-ID: <6034738.lOV4Wx5bFT@lichtvoll.de>
In-Reply-To: <be5a7213-78b3-4917-b95b-ec31cd2350e4@leemhuis.info>
References:
 <2325246.ElGaqSPkdT@lichtvoll.de> <12401263.O9o76ZdvQC@lichtvoll.de>
 <be5a7213-78b3-4917-b95b-ec31cd2350e4@leemhuis.info>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Linux regression tracking (Thorsten Leemhuis) - 19.03.24, 09:40:06 CEST:
> On 16.03.24 17:12, Martin Steigerwald wrote:
> > Martin Steigerwald - 16.03.24, 17:02:44 CET:
> >> ThinkPad T14 AMD Gen 1 fails to hibernate with self-compiled 6.8.1.
> >> Hibernation works correctly with self-compiled 6.7.9.
> >=20
> > Apparently 6.8.1 does not even reboot correctly anymore. runit on
> > Devuan. It says it is doing the system reboot but then nothing
> > happens.
> >=20
> > As for hibernation the kernel cancels the attempt and returns back to
> > user space desktop session.
> >=20
> >> Trying to use "no_console_suspend" to debug next. Will not do bisect
> >> between major kernel releases on a production machine.
>=20
> FWIW, without a bisection I guess no developer will take a closer look
> (but I might be wrong and you lucky here!), as any change in those
> hundreds of drivers used on that machine can possibly lead to problems
> like yours. So without a bisection we are likely stuck here, unless
> someone else runs into the same problem and bisects or fixes it. Sorry,
> but that's just how it is.

The plot thickens, now 6.7.12 as compared to 6.7.11 which failed hibernation
with busy work queues=B9 and 6.7.9 + bcachefs downgrade fixes fails
hibernation with the same error message than 6.8.1:

[   74.330285] PM: hibernation: hibernation entry
[   74.617009] Filesystems sync: 0.097 seconds
[   74.617309] Freezing user space processes
[   74.620021] Freezing user space processes completed (elapsed 0.002 secon=
ds)
[   74.620048] OOM killer disabled.
[   74.620250] PM: hibernation: Marking nosave pages: [mem 0x00000000-0x000=
00fff]
[   74.620253] PM: hibernation: Marking nosave pages: [mem 0x0009f000-0x000=
fffff]
[   74.620256] PM: hibernation: Marking nosave pages: [mem 0x09c00000-0x09d=
00fff]
[   74.620261] PM: hibernation: Marking nosave pages: [mem 0x09f00000-0x09f=
0ffff]
[   74.620263] PM: hibernation: Marking nosave pages: [mem 0xa22b7000-0xa22=
b7fff]
[   74.620264] PM: hibernation: Marking nosave pages: [mem 0xa22c4000-0xa22=
c5fff]
[   74.620266] PM: hibernation: Marking nosave pages: [mem 0xa22d3000-0xa22=
d4fff]
[   74.620267] PM: hibernation: Marking nosave pages: [mem 0xa22e5000-0xa22=
e5fff]
[   74.620269] PM: hibernation: Marking nosave pages: [mem 0xb9533000-0xb95=
c3fff]
[   74.620272] PM: hibernation: Marking nosave pages: [mem 0xbd9de000-0xcc3=
fdfff]
[   74.620752] PM: hibernation: Marking nosave pages: [mem 0xce000000-0xfff=
fffff]
[   74.622717] PM: hibernation: Basic memory bitmaps created
[   74.629269] PM: hibernation: Preallocating image memory
[   76.658495] PM: hibernation: Allocated 2042025 pages for snapshot
[   76.658875] PM: hibernation: Allocated 8168100 kbytes in 2.02 seconds (4=
043.61 MB/s)
[   76.658901] Freezing remaining freezable tasks
[   76.660457] Freezing remaining freezable tasks completed (elapsed 0.001 =
seconds)
[   76.666115] port 0000:02:00.1:0.0: PM: dpm_run_callback(): pm_runtime_fo=
rce_suspend+0x0/0x120 returns -16
[   76.666255] port 0000:02:00.1:0.0: PM: failed to freeze: error -16
[   78.616495] psmouse serio1: synaptics: queried max coordinates: x [..567=
8], y [..4694]
[   78.654349] psmouse serio1: synaptics: queried min coordinates: x [1266.=
=2E], y [1162..]
[   79.106531] PM: hibernation: Basic memory bitmaps freed
[   79.106855] OOM killer enabled.
[   79.106873] Restarting tasks ... done.
[   79.111514] PM: hibernation: hibernation exit

Not doing it today or probably the weekend, but now I have some actionable
git bisect plan without bisecting between major kernel releases which as I
have been told between 6.7 an 6.8-rc1 can lead to non working modeset
graphics on AMD Ryzen in between.

It seems now I only need to git bisect between 6.7.11 and 6.7.12 to find the
patch that breaks hibernation on 6.8.1 as well. However first I will briefly
check whether 6.8.4 hibernates okay.

[1] * 6.7.11: Fails to hibernate - work queues still busy
@ 2024-04-02 19:29 Martin Steigerwald

https://lore.kernel.org/regressions/2ad93b57-8fdc-476e-83b7-2c0af1cfd41d@le=
emhuis.info/T/#t

Best,
=2D-=20
Martin