Received-SPF: pass (google.com: domain of linux-kernel+bounces-132948-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <e3c0da47-8748-42ba-bd0e-872a5e66090f@gmail.com>
Date: Fri, 5 Apr 2024 13:06:40 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/3] Add REQ_F_CQE_SKIP support to io_uring zerocopy
To: Oliver Crumrine <ozlinuxc@gmail.com>, axboe@kernel.dk,
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, shuah@kernel.org, leitao@debian.org
Cc: io-uring@vger.kernel.org, netdev@vger.kernel.org,
 linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1712268605.git.ozlinuxc@gmail.com>
Content-Language: en-US
From: Pavel Begunkov <asml.silence@gmail.com>
In-Reply-To: <cover.1712268605.git.ozlinuxc@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/4/24 23:16, Oliver Crumrine wrote:
> This patchset allows for io_uring zerocopy to support REQ_F_CQE_SKIP,
> skipping the normal completion notification, but not the zerocopy buffer
> release notification.

It's an io_uring internal change not altering how it operates
with the net layer, you don't need to CC the net list.

> This patchset also includes a test to test these changes, and a patch to
> mini_liburing to enable io_uring_peek_cqe, which is needed for the test.

For the same reason tests should be in liburing, where all io_uring tests
are, and the selftest can be dropped. See liburing/test/send-zerocopy.c


> Oliver Crumrine (3):
>    io_uring: Add REQ_F_CQE_SKIP support for io_uring zerocopy
>    io_uring: Add io_uring_peek_cqe to mini_liburing
>    io_uring: Support IOSQE_CQE_SKIP_SUCCESS in io_uring zerocopy test
> 
>   io_uring/net.c                                |  6 +--
>   tools/include/io_uring/mini_liburing.h        | 18 +++++++++
>   .../selftests/net/io_uring_zerocopy_tx.c      | 37 +++++++++++++++++--
>   .../selftests/net/io_uring_zerocopy_tx.sh     |  7 +++-
>   4 files changed, 59 insertions(+), 10 deletions(-)
> 

-- 
Pavel Begunkov