Received-SPF: pass (google.com: domain of linux-kernel+bounces-133140-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <cb683a87f9d6942df057567fbf2de57f83bd6546.camel@linux.ibm.com>
Subject: Re: [PATCH v5][next] integrity: Avoid
 -Wflex-array-member-not-at-end warnings
From: Mimi Zohar <zohar@linux.ibm.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        "Gustavo A. R. Silva"
 <gustavoars@kernel.org>,
        Roberto Sassu <roberto.sassu@huawei.com>,
        Dmitry
 Kasatkin <dmitry.kasatkin@gmail.com>,
        Eric Snowberg
 <eric.snowberg@oracle.com>,
        Paul Moore <paul@paul-moore.com>, James Morris
 <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Date: Fri, 05 Apr 2024 10:17:09 -0400
In-Reply-To: <d6c9a04e-66e3-4010-9a35-fb5efc3f1af0@embeddedor.com>
References: <Zg7AoOh7CL5ZD/fe@neat>
	 <27d36ec8e0539c5d6bc760de7305299a2142f9f1.camel@linux.ibm.com>
	 <b3956fd36307d33ebbf0e4633e0d2389860cf720.camel@linux.ibm.com>
	 <d6c9a04e-66e3-4010-9a35-fb5efc3f1af0@embeddedor.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

On Thu, 2024-04-04 at 18:56 -0600, Gustavo A. R. Silva wrote:
> > "checkpatch.pl --strict" complains "CHECK: Alignment should match open
> > parenthesis".  I'll queue the patch, but how about teaching checkpatch.pl to
> > ignore __struct_group()?
> 
> I think this would do it:
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9c4c4a61bc83..e229b97f17f6 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3958,7 +3958,7 @@ sub process {
>                          my $rest = $2;
> 
>                          my $pos = pos_last_openparen($rest);
> -                       if ($pos >= 0) {
> +                       if ($pos >= 0 && $rest !~
> /(__)?struct_group(_(tagged|attr))?(\()/) {
>                                  $line =~ /^(\+| )([ \t]*)/;
>                                  my $newindent = $2;
> 
> I'll send a proper patch. Thanks for the suggestion, Mimi.

Thanks, it works.

Mimi