Received-SPF: pass (google.com: domain of linux-kernel+bounces-133192-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <bf8771c31f282ae31009a1ef5737c03849deebc2.camel@irl.hu>
Subject: Re: [PATCH v4 1/3] ACPI: platform-profile: add
 platform_profile_cycle()
From: Gergo Koteles <soyer@irl.hu>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
  "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>,
  Ike Panhc <ike.pan@canonical.com>,
  Hans de Goede <hdegoede@redhat.com>,
  Ilpo =?ISO-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
  Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: linux-acpi@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net,
  platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Fri, 05 Apr 2024 16:48:48 +0200
In-Reply-To: <87d38d4c-14e2-4c64-baba-c9b8bd694339@linaro.org>
References: <cover.1712282976.git.soyer@irl.hu>
	 <fdc1b0b9f910753967b7a9b1996e4923cc63124f.1712282976.git.soyer@irl.hu>
	 <87d38d4c-14e2-4c64-baba-c9b8bd694339@linaro.org>
Autocrypt: addr=soyer@irl.hu; prefer-encrypt=mutual;
 keydata=mDMEZgeDQBYJKwYBBAHaRw8BAQdAD5oxV6MHkjzSfQL2O8VsPW3rSUeCHfbx/a6Yfj3NUnS0HEdlcmdvIEtvdGVsZXMgPHNveWVyQGlybC5odT6ImQQTFgoAQRYhBLSYvEYEgjzzEMQCqgtEJzXf/1IRBQJmB4NAAhsDBQkFo5qABQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEAtEJzXf/1IRmdYA/0bE1BX7zOGKBgCa1DwzH2UHXawSKLpptADvI/ao6OOtAP4+wYgpR0kWR28lhmkRTpzG/+8GiMWsT60SV2bz9B7sCbg4BGYHg0ASCisGAQQBl1UBBQEBB0CPo8ow/E97WYtaek9EsLXvsvwpBsjWLq5mMOgJL/ukCwMBCAeIfgQYFgoAJhYhBLSYvEYEgjzzEMQCqgtEJzXf/1IRBQJmB4NAAhsMBQkFo5qAAAoJEAtEJzXf/1IRklEA/ipTfAI/onzNwZIp9sCdnt0bLhR5Oz8RD/FpbrJV1v7eAP0c/C6NQPDPWbQpobBR0pf1eTjWXjjr1fj2jxSvWbMRCw==
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

Hi Daniel,

On Fri, 2024-04-05 at 08:48 +0200, Daniel Lezcano wrote:
> Hi Gergo,
>=20
> please Cc people who commented your changes.

Thanks for this info, next time :)

> > +int platform_profile_cycle(void)
> > +{
> > +	enum platform_profile_option profile;
> > +	enum platform_profile_option next;
> > +	int err;
> > +
> > +	err =3D mutex_lock_interruptible(&profile_lock);
> > +	if (err)
> > +		return err;
> > +
> > +	if (!cur_profile) {
> > +		mutex_unlock(&profile_lock);
> > +		return -ENODEV;
> > +	}
> > +
> > +	err =3D cur_profile->profile_get(cur_profile, &profile);
> > +	if (err) {
> > +		mutex_unlock(&profile_lock);
> > +		return err;
> > +	}
> > +
> > +	next =3D ffs(cur_profile->choices[0] >> (profile + 1)) + profile;
> > +
> > +	/* current profile is the highest, select the lowest */
> > +	if (next =3D=3D profile)
> > +		next =3D ffs(cur_profile->choices[0]) - 1;
> > +
> > +	if (WARN_ON((next < 0) || (next >=3D ARRAY_SIZE(profile_names)))) {
> > +		mutex_unlock(&profile_lock);
> > +		return -EINVAL;
> > +	}
>=20
> Why do you need to do this?
>=20

Many platform drivers use the platform profile module. They support
different sets of profiles, not all. They sets the corresponding bits
in the choices variable.

like this:
set_bit(PLATFORM_PROFILE_BALANCED, platform_profile_handler.choices);

The platform_profile_cycle() cycles through the enabled profiles.

Best regards,
Gergo

> That can be simplified by:
>=20
> 	[ ... ]
>=20
> 	err =3D cur_profile->profile_get(cur_profile, &profile);
> 	if (err)
> 		goto out;
>=20
> 	profile =3D (profile + 1) % ARRAY_SIZE(profile_names);
>=20
> 	err =3D cur_profile->profile_set(cur_profile, next);
> out:
> 	mutex_unlock(&profile_lock);
> =09
> 	[ ... ]
>=20
> > +	err =3D cur_profile->profile_set(cur_profile, next);
> > +	mutex_unlock(&profile_lock);
> > +
> > +	if (!err)
> > +		sysfs_notify(acpi_kobj, NULL, "platform_profile");
> > +
> > +	return err;
> > +}
> > +EXPORT_SYMBOL_GPL(platform_profile_cycle);
> > +
> >   int platform_profile_register(struct platform_profile_handler *pprof)
> >   {
> >   	int err;
> > diff --git a/include/linux/platform_profile.h b/include/linux/platform_=
profile.h
> > index e5cbb6841f3a..f5492ed413f3 100644
> > --- a/include/linux/platform_profile.h
> > +++ b/include/linux/platform_profile.h
> > @@ -36,6 +36,7 @@ struct platform_profile_handler {
> >  =20
> >   int platform_profile_register(struct platform_profile_handler *pprof)=
;
> >   int platform_profile_remove(void);
> > +int platform_profile_cycle(void);
> >   void platform_profile_notify(void);
> >  =20
> >   #endif  /*_PLATFORM_PROFILE_H_*/
>=20