Received-SPF: pass (google.com: domain of linux-kernel+bounces-133199-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <2a77adeb-ed22-4a9b-a1d9-ac5d29ae696d@linuxfoundation.org>
Date: Fri, 5 Apr 2024 08:56:31 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in
 ksft_exit_fail_msg()
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
 Eric Biederman <ebiederm@xmission.com>, Kees Cook <keescook@chromium.org>,
 Shuah Khan <shuah@kernel.org>, Andrew Morton <akpm@linux-foundation.org>,
 linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: kernel@collabora.com, Shuah Khan <skhan@linuxfoundation.org>
References: <20240405131748.1582646-1-usama.anjum@collabora.com>
Content-Language: en-US
From: Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20240405131748.1582646-1-usama.anjum@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/5/24 07:17, Muhammad Usama Anjum wrote:
> "Bail out! " is not descriptive. It rather should be: "Failed: " and
> then this added prefix doesn't need to be added everywhere. Usually in
> the logs, we are searching for "Failed" or "Error" instead of "Bail
> out" so it must be replace.
> 
> Remove Error/Failed prefixes from all usages as well.
> 
> Muhammad Usama Anjum (2):
>    selftests: Replace "Bail out" with "Error"
>    selftests: Remove Error/Failed prefix from ksft_exit_fail*() usages
> 
>   tools/testing/selftests/exec/load_address.c   |   8 +-
>   .../testing/selftests/exec/recursion-depth.c  |  10 +-
>   tools/testing/selftests/kselftest.h           |   2 +-
>   .../selftests/mm/map_fixed_noreplace.c        |  24 +--
>   tools/testing/selftests/mm/map_populate.c     |   2 +-
>   tools/testing/selftests/mm/mremap_dontunmap.c |   2 +-
>   tools/testing/selftests/mm/pagemap_ioctl.c    | 166 +++++++++---------
>   .../selftests/mm/split_huge_page_test.c       |   2 +-
>   8 files changed, 108 insertions(+), 108 deletions(-)
> 

Andrew, Kees,

I will apply these to linux-kselftest next as a series since these
changes depend on change to tools/testing/selftests/kselftest.h
and need to go together.

Are you okay with that?

thanks,
-- Shuah