Received-SPF: pass (google.com: domain of linux-kernel+bounces-133200-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 5 Apr 2024 10:56:30 -0400
From: Frank Li <Frank.li@nxp.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>,
	"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@lists.linux.dev>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] arm64: dts: imx8qxp-mek: add cm40_i2c, wm8960/wm8962
 and sai[0,1,4,5]
Message-ID: <ZhARHhzZ0mUmMyVw@lizhi-Precision-Tower-5810>
References: <20240404161914.1655305-1-Frank.Li@nxp.com>
 <20240405063648.GA4562@francesco-nb>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240405063648.GA4562@francesco-nb>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+qJMScozOQF2IzoGNmvDlB5qsAhqjTx7p5QeNspgoPspK8nA9LNHxR3Nk8ns?=
 =?us-ascii?Q?jHqsFNNCVNOCCpm5rfiRVT0g9FVvtdPCWc/ZQXJ3gwMsKffhNGEqNtZk4BIR?=
 =?us-ascii?Q?ORKB2EwC0lTMq86yefL8AjvEHjE2lTFrm7XH35XE+VpuvnG0lwBlRoJ2PuYo?=
 =?us-ascii?Q?1P3bQRygwNOqQuFUgbWhesSSHu5a3fRMXtRhGoJ7XeI4w1PxmiXMZf1T+Le8?=
 =?us-ascii?Q?5TIyDLmnwhSGJDbS3KMUaWSgpEsAeWPAksv/5TEU78kEyHYozR8JckAvc/5A?=
 =?us-ascii?Q?aYtgWeqrZAOGPvvcNIpj3o47/EjBveSra0xsgG0ngKij/ivj5HlgwVRBvNoo?=
 =?us-ascii?Q?qxNjlBZX2ydMfCTfoT+VFK2voK3v4+PmMK2fXzxNx/YGUsDAxIm5WF7TWtyD?=
 =?us-ascii?Q?BJ9r0SyjE/ikcSUmJpBcZ8BmwTH/Ftiu+5LeNRwkJsPfurfGgvbLfaY21Kmz?=
 =?us-ascii?Q?z3DhIsHH15XF+7hXw610aDaJqw1nVGoLsJeM51yeRH3qK4XsXkgoZPcGgmEb?=
 =?us-ascii?Q?zpaC2dfoFtGhl1E6HxGJl54h+USS4DDlUwYU8Qvj1OGda/QgqLbB8xfMrJNL?=
 =?us-ascii?Q?CasYv1C6fNLpPE6zD2FK2QKIb5hTk3zaKvi/QHbtwmr2oz4ankjoPCyDfYix?=
 =?us-ascii?Q?2jQAWR/9RHeoMV52xrp9BxQ0uLdC8HeGfMpqCD1kkVEOnhws0af2/NweF3Vc?=
 =?us-ascii?Q?BwtmJMt15Iho3+j9SkdLXsVRsaCictN66wt6OuMx4HFbs23rnhIBNvdNHdBD?=
 =?us-ascii?Q?XiEqDpGgFxh7HPHbwdC4Trm6JoqpxGOmdRl5hK+xtXmixK3puPF8F8fsByje?=
 =?us-ascii?Q?rZQUY9sNa5YNqtNXUG2MGZbf94oTA4LhpeLN2ofUcluLriACNAShVonciXAG?=
 =?us-ascii?Q?B1wo7E9vl793Z41fjcB76Ij4jlZcBZK4p0+KYsZvXvQy3iLrYUiS5tO4KFti?=
 =?us-ascii?Q?ctRtYRiGLmi0AC4sRh2GKrvMbt6HceSPgjwEEZUy4SBgkWJR259xjYffe1C7?=
 =?us-ascii?Q?qwcC1b7twSf6TnnbWrdZ24+8LVO0Vqf9BGskmZIlUYNTi/aCWx6dpQcNI7Q9?=
 =?us-ascii?Q?1VgOW/nBitVHC7Xe6HfRx5i/mXjIEOSqRZL11VxjREptiquRiaOxjDcRzZA5?=
 =?us-ascii?Q?xhIqVNw7qythcQC/RQh85DAngoYalpKilJFIUlcd/6+++vuxPRA/NXWM/5PP?=
 =?us-ascii?Q?m9Olhv0YDl06piuUpa6twIY4K+Ee5ySzwJpPvL//WEYFLS0D618L3w+DwS0+?=
 =?us-ascii?Q?jwS5SxOcSYDq36yoYhClUjAkp41m7b06KVEXsjMJrQjgMKmZAexDfVSwEHTA?=
 =?us-ascii?Q?6R+iuwuYlVNpmDf5MbmMSLL1meiQ+eGIrxlSTeWutIpQBqwzHTDZORaGd1XW?=
 =?us-ascii?Q?goRxul3FHFU2MdrnqIdchM/xB4nZgtVDjopLA/TcqvdjLHyCFSLfg9kNCfxL?=
 =?us-ascii?Q?/WkLpc20cv6fVOios78ifTosZyaQEpDU8etn1P+SW1BdnWNZx5C9Z6jTPke0?=
 =?us-ascii?Q?v8jjWSjTUvYJ0y8uR3Q9tY0pgVRaLvA4D+fbzJRGD7uyvVXDguq0WWb9weZ9?=
 =?us-ascii?Q?qCCRfoas9iX6//vd+5yQK2a/W5nh5AeUA8ycd+y0?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24d8fbde-bbaa-4b32-2d74-08dc55809846
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 14:56:38.0027
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pbxlnnoDFewhuBe/AjP6thnosqIRG8Nal+hUL32iwJEx5uYo1JI7j+Lbal40IILD5nxb8NtDvQGK8ePxAmOpdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6802

On Fri, Apr 05, 2024 at 08:36:48AM +0200, Francesco Dolcini wrote:
> Hello Frank,
> 
> On Thu, Apr 04, 2024 at 12:19:13PM -0400, Frank Li wrote:
> > imx8qxp-mek use two kind audio codec, wm8960 and wm8962. Using dummy gpio
> > i2c bus mux to connect both i2c devices. One will probe failure and other
> > will probe success when devices driver check whoami. So one dtb can cover
> > both board configuration.
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 210 ++++++++++++++++++
> >  1 file changed, 210 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> > index 8360bb851ac03..adff87c7cf305 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> > @@ -44,6 +51,105 @@ usb3_data_ss: endpoint {
> 
> [...]
> 
> > +	/*
> > +	 * This dummy i2c mux. GPIO actually will not impact selection. At actual boards, only 1
> > +	 * device connectted. I2C client driver will check ID when probe. Only matched ID's driver
> > +	 * probe successfully.
> > +	 */
> > +	i2cvmux: i2cmux {
> > +		compatible = "i2c-mux-gpio";
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		mux-gpios = <&lsio_gpio5 0 GPIO_ACTIVE_HIGH>; /* use an unused gpio */
> 
> There is for sure people that have more experience and competency that
> me and it would be interesting to hear their feedback, but this
> looks like a bad hack, and you are just playing with the driver
> behavior to ensure that you get what you need.

We want to use one dtb to handle differecne bench boards because some chips
are out of life-cycle. I don't think it is 'hack' although not
straightforward.

check woiam is quite common at i2c drivers. All used method is quite
common, I just change it from difference point.

> 
> Francesco
> 
>