Received-SPF: pass (google.com: domain of linux-kernel+bounces-133223-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240404222009.670685-1-andreas@kemnade.info> <20240404222009.670685-3-andreas@kemnade.info>
In-Reply-To: <20240404222009.670685-3-andreas@kemnade.info>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, 5 Apr 2024 18:13:45 +0300
Message-ID: <CAHp75VeZ9U_+1rJQjr4KvvzjYQGzfKtk+BK00vqvKcVn2-yP3g@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] Input: edt-ft5x06 - add ft5426
To: Andreas Kemnade <andreas@kemnade.info>
Cc: dmitry.torokhov@gmail.com, robh+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, 
	o.rempel@pengutronix.de, u.kleine-koenig@pengutronix.de, hdegoede@redhat.com, 
	ye.xingchen@zte.com.cn, p.puschmann@pironex.com, linux-input@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	caleb.connolly@linaro.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 5, 2024 at 1:20=E2=80=AFAM Andreas Kemnade <andreas@kemnade.inf=
o> wrote:
>
> As ft5426 seems to be compatible with this driver, add it.
> Debug output during identification: Model "generic ft5x06 (79)", Rev. "

..

> @@ -1484,6 +1484,7 @@ static const struct of_device_id edt_ft5x06_of_matc=
h[] =3D {
>         { .compatible =3D "edt,edt-ft5206", .data =3D &edt_ft5x06_data },
>         { .compatible =3D "edt,edt-ft5306", .data =3D &edt_ft5x06_data },
>         { .compatible =3D "edt,edt-ft5406", .data =3D &edt_ft5x06_data },
> +       { .compatible =3D "focaltech,ft5426", .data =3D &edt_ft5506_data =
},

Why a different vendor prefix?
In case you need to use this one, keep the list sorted, currently this
splits the edt,* ones.

>         { .compatible =3D "edt,edt-ft5506", .data =3D &edt_ft5506_data },
>         { .compatible =3D "evervision,ev-ft5726", .data =3D &edt_ft5506_d=
ata },
>         /* Note focaltech vendor prefix for compatibility with ft6236.c *=
/

--=20
With Best Regards,
Andy Shevchenko