Received-SPF: pass (google.com: domain of linux-kernel+bounces-133224-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 5 Apr 2024 17:14:41 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Trevor Gamblin <tgamblin@baylibre.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	michael.hennerich@analog.com, nuno.sa@analog.com, dlechner@baylibre.com
Subject: Re: [RFC PATCH 0/3] pwm: add support for duty_offset
Message-ID: <yi2h45jkaqevzmbv56lxnhopfg43474pumoz5gfmozmf65dxov@4ezyfnakwwkv>
References: <20240405003025.739603-1-tgamblin@baylibre.com>
 <fhrderkiwqzc7fw2hptz2la3aco72wlossqbrr4m42qllcpcpw@vhxflah2ex2a>
 <9b2bab7a-24a7-49da-8cb8-f58e28baf065@baylibre.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ihutw3or4wakatkd"
Content-Disposition: inline
In-Reply-To: <9b2bab7a-24a7-49da-8cb8-f58e28baf065@baylibre.com>


--ihutw3or4wakatkd
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Trevor,

On Fri, Apr 05, 2024 at 10:19:20AM -0400, Trevor Gamblin wrote:
> On 2024-04-05 08:23, Uwe Kleine-K=F6nig wrote:
> > Having said that I don't like the addition of .supports_offset to
> > struct pwm_chip, which only signals a new incomplete evolution of the
> > pwm framework. Better adapt all drivers and then assume all of them
> > support it.
> Can you clarify what you mean here - is the intent to put basic handling =
of
> duty_offset (even if that means simply setting it to 0) in each driver?

Well, it's a bit more complicated than setting it to 0. It involves
translating a setting with inverted polarity to one using .duty_offset
and make all drivers implement that accordingly.

For drivers that support both polarities the logic in .apply should be:

	if (.duty_offset >=3D .period - .duty_cycle)
		... set inverted polarity
	else
		... set normal polarity

I'm usure how to do the transformation in reviewable chunks. Maybe the
easiest option is a new .apply callback that honors .duty_offset?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--ihutw3or4wakatkd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYQFWAACgkQj4D7WH0S
/k6HTwgAlpLr1QB5F/boxHcwG6Vj9ErqXPT9OYI53ScblBJLwDhQkVrysQrVcAum
NmEzuWD670w4+H/v/uuxM/BXYNboNBcLH28i8aZRMXsqQ2OKytZkKDUUjtxZojVq
h2s8l4S/hs5EFp/L0eeWYpPd2oBD+hIWH0Ltv4VLLfrscXLfDfOa5c56ptUBdL8N
gUa8GGbJ+vCNO6gZaIaqOc2sJttunmY8TVxP6qIakvyLCVfad8zq++D768Eyd8H1
8vGL1SWYOnw338OkkwQWxZ8zTCPGxAJcPT826i11IntYTr/bPQBkvtUCKvndWqOT
t8dHlqoPfVe9ZuBIraPCQsbVerTbBA==
=pUxM
-----END PGP SIGNATURE-----

--ihutw3or4wakatkd--