Received-SPF: pass (google.com: domain of linux-kernel+bounces-133227-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <bbdb5c3c-1a2a-4fa3-8e08-2e1a3fc51b85@intel.com>
Date: Fri, 5 Apr 2024 17:15:58 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC net-next 1/7] netdev_features: remove unused
 __UNUSED_NETIF_F_1
To: Andrew Lunn <andrew@lunn.ch>
CC: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, David Ahern <dsahern@kernel.org>, Xuan Zhuo
	<xuanzhuo@linux.alibaba.com>, <nex.sw.ncis.osdt.itp.upstreaming@intel.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240405133731.1010128-1-aleksander.lobakin@intel.com>
 <20240405133731.1010128-2-aleksander.lobakin@intel.com>
 <f6d9db1c-bde2-4704-a3cf-69e84a5a6fd3@lunn.ch>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <f6d9db1c-bde2-4704-a3cf-69e84a5a6fd3@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T05rVktoOGhiU3BXL04vcUM1OUFTdWIyaGdmeGpDMVpJYVZ4SENtWkxZMXdk?=
 =?utf-8?B?MzJQalp1SGFOL0tUZk5ISmwvNURWTnhzNTNjS0oyOUdJbGZOVnM0RU9HNWRK?=
 =?utf-8?B?U2p3YWp5QTRLVjc2a3I4ZmVBTXQweXZ1S1ZVRkd1QnlDdnhOV2QzV3hERFZO?=
 =?utf-8?B?S1lud1lTL1VVcWpYYmtaa0lyNm5aS3k4Rk4wRUsvcy9nVXJBQ1MxOUduLzlT?=
 =?utf-8?B?b0ZuaGJRM05DUzhESEVpNmpseVZ3UjNyMzdBdEwzb1JGZEJYK2hRaDZpQXcw?=
 =?utf-8?B?WVlCWG9UdWRyb0Yva2svNXF2Mllsd3loSmNrVUp5RGhrcTlTKzQxdVVIajlX?=
 =?utf-8?B?Y3daSGdEZHhabmNISzJ4UHhuUUovNHA4OW56NWNKYWJNNEFpRzZjS1k5NFNq?=
 =?utf-8?B?MXdaTnEvVWZGS3BYZkhMRDgzbTNnQUw1YzlRcHA5V2tZdHdVdEdOOVRhNEZ2?=
 =?utf-8?B?UTduSmV0N1NqNDNmUXk0SmpQWU94RnBSa2dXU29abkhZYTJYMkNRYnNtM2pp?=
 =?utf-8?B?Z1FDZ1hZUjRtWTIwRXRyRjlxTnE1em5vZW5RNnJmUStPMHprb3A5ZlVHR2Ur?=
 =?utf-8?B?OGtzSHJmcUw4c1VjYlcwUThhRkxhK284THA3U3UwL1VZWXVCQzhPM1V2bzIw?=
 =?utf-8?B?TnBvZnlKL0tDZzVKdmVQY0hGN2RDd3BxZGtlWmN2ZDZJOWRraS8yWThMMDJG?=
 =?utf-8?B?Nm9VYll3aW1samk1UncxQmhtN1cwa0U2dlZNZzhWV3lZRkp6UUxhUzAxOEJL?=
 =?utf-8?B?emhsZWdsY1l6T2xUNjlJUDJNcTFtaDJmUlhkWXZUZG9yVkhqbytLYmVsdUdH?=
 =?utf-8?B?ZmMwNWQ5SXcrek5ZN09jVmg5eFlMbndnWWtnNnB5SWJuQktXS2IvUVJjUWIw?=
 =?utf-8?B?R3EyZFpYaFF4TzRXOVJnOGt4ODNNYnBYSkVQL0hvK1JTNXQ4SFdvOGFkZmps?=
 =?utf-8?B?RFpBV2dmSVlVR2FsSG9lVDBFR3JwTDhVVGhLS1NqcDl3OWQrNGFCMmV2Vjgw?=
 =?utf-8?B?eVFSMDE5bW1KSFVkSWRIUUdHV2Y3Zmd2TnNXbDMrQmJvWHcrWHp5NFdTM0lP?=
 =?utf-8?B?SkNNaHgyZm45K2N5R2hrakhEZFRsUUhBOTJIMEhHd2NOTjJlUnFUSVlrS0NO?=
 =?utf-8?B?dytXeitOZVUyYWZ2QzJBanNDQ2NLMDRTWVBRcDBWclhJeFJHY0trcEpHcHFn?=
 =?utf-8?B?L3dDLy8xMTVCRGM5ZDRnMlNFc0N2d01NREkxYVJSdE4zRnVaaGo3OGxRWkUz?=
 =?utf-8?B?c0Q3d3JmWElML1hPVjBKUkJNdnB2U2VMSTI0NitDS1k5WThHb204SFlybGFS?=
 =?utf-8?B?bW1jZEZhYXdiUjB0U1ZmN091K2M2c2ZWcU9RWWRDNjFyWm5SZjk5WlowZ1Zo?=
 =?utf-8?B?ZVl1SC82ak9oN1gvelBVVlJwV3hhYmlrcC9WaVkxWituNThuOHAzeWoyeG1G?=
 =?utf-8?B?aDZHSlhkbmJmb2VDMWVrVy9DeHR0R1JXR0c2TGZtVElmTXJpZVRiNGtjMXp2?=
 =?utf-8?B?SEl2bjB2K2ZndUJUd2FTbkhPakVsVmEzZ0dGMWh6ZXAyOGF3TCtiVkRzQkJY?=
 =?utf-8?B?ak4rZ25aVEpEalplR3FMaXZYWkphWGJIQmdqR01SdkpmQTJ3NjR6dTV1NFFt?=
 =?utf-8?B?K0FLY1FsWkpYbS9Nb0hyNUhnOVdRT0RPMUhaRWpZWVl0R1EwY21aOGY4ZHRq?=
 =?utf-8?B?eXA0VzJsMURwUjdnWldtVVppa2JpcGpKb0hjaUtTTVA4ODR3dmVSckdrYTQ2?=
 =?utf-8?B?czk4QUdXalhia2xMSkVhdG5xMjJWZTNlM0kzOTNkaGpJMEhDckV5MThhbUJJ?=
 =?utf-8?B?V3VOTHZWUTFla0RHQkVkN3MrNkZsa09Ba1UvNE5wWkJPQld5dElGdk9SVzhk?=
 =?utf-8?B?eUpQK1ViazdqM09WbkYwOUlQZ0JTM3pDSmIyVWpDODdDYkZFNFYwblpNUlh0?=
 =?utf-8?B?Z3lBK3h4UkVDWWdmUmwxMUEwZWpTR1RrRnEwUW5YYzkyVVV2bDN4cGozOEcz?=
 =?utf-8?B?WDJLT0xJcDRNRHJueHlNa1BYbGFjenFCTksyWDNBYmlvVzRlVWNqeTZpeWhF?=
 =?utf-8?B?a256d2cvQmlVY2Qxd0R5aHlUbDRFV3ZJZCtHZ1lmZndKcXM0NGlQNEk1aU5r?=
 =?utf-8?B?eUt3YWZxVUw5dXNGOCtWSTZKL0lMM0JJQzI3elZlM2JPcjAzUjJWeEtYclBF?=
 =?utf-8?B?VVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 05746eb9-88e7-44d5-66d6-08dc558380c3
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 15:17:27.1097
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iq9Bnvo8XDCZ6Dr52xfUX1onUWCTJKk9CNFDPte6Rxc+0Z9ZoJOJfHRRSN54Qyz7evzLK3FSdaOAFoL4M+ck2j+D4BGmsPe9h/Ba5qpOnho=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8578
X-OriginatorOrg: intel.com

From: Andrew Lunn <andrew@lunn.ch>
Date: Fri, 5 Apr 2024 16:12:50 +0200

> On Fri, Apr 05, 2024 at 03:37:25PM +0200, Alexander Lobakin wrote:
>> NETIF_F_NO_CSUM was removed in 3.2-rc2 by commit 34324dc2bf27
>> ("net: remove NETIF_F_NO_CSUM feature bit") and became
>> __UNUSED_NETIF_F_1. It's not used anywhere in the code.
>> Remove this bit waste.
>>
>> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
>> ---
>>  include/linux/netdev_features.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
>> index 7c2d77d75a88..44c428d62db4 100644
>> --- a/include/linux/netdev_features.h
>> +++ b/include/linux/netdev_features.h
>> @@ -14,7 +14,6 @@ typedef u64 netdev_features_t;
>>  enum {
>>  	NETIF_F_SG_BIT,			/* Scatter/gather IO. */
>>  	NETIF_F_IP_CSUM_BIT,		/* Can checksum TCP/UDP over IPv4. */
>> -	__UNUSED_NETIF_F_1,
>>  	NETIF_F_HW_CSUM_BIT,		/* Can checksum all the packets. */
>>  	NETIF_F_IPV6_CSUM_BIT,		/* Can checksum TCP/UDP over IPV6 */
>>  	NETIF_F_HIGHDMA_BIT,		/* Can DMA to high memory. */
> 
> Are you sure this enum is not ABI?

Why should this be ABI? It's not a part of UAPI and Ethtool receives
these bits together with string names.

> 
> It would be good to add an explanation why it is not ABI to the cover
> letter.
> 
> 	Andrew

Thanks,
Olek