Received: by 2002:a05:7208:31d3:b0:81:e143:7c29 with SMTP id v19csp428151rbd; Fri, 5 Apr 2024 08:33:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWoDzuK/O7+XFq8XEbh8NGS9QToeKbqfpTIN8AY0Pu4ZODqaW0y4zwdimwYXE8sNfUVzKund3llbQm0FgNoSWGJSWR6FH9clfk37ePfVg== X-Google-Smtp-Source: AGHT+IGVLqqraAVTMwTn18PZeiaH5vFw8UCPaq3gRZLKPXWPQahJ7ag3mIa5MNwY+IfKUL16T9XS X-Received: by 2002:a05:6a00:18a2:b0:6e8:f66f:6b33 with SMTP id x34-20020a056a0018a200b006e8f66f6b33mr2005520pfh.4.1712331233957; Fri, 05 Apr 2024 08:33:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712331233; cv=pass; d=google.com; s=arc-20160816; b=M9OpH5FxPKxobnIp0AFtN+t+T9qQYr7vMgydZ3urNyR7YqPZ0HfXMC/tT3Fy5wT2cZ x5CxicqzaJIV64g3K3nFmVP8ll1Pb2BGri7PS4+xjzpfYyaLYrg5vdpsadBcmlfBVtlF goPlnNMTdZOYNNZV9aeeFexEMlvey0IR7gvqjyQq7JbJm9YPyYNoqGNYBV+SWD+iwrPv EOHJkdAKMgdyh0g9mCA6x2TV+s/t5+r//2uBPDBIXWkWrTzUYv3MCSq7VhffL0BTUIWl tdBzJQOZxldTEoeXN1BsYDdAkQ3DvTeTuFb/3vIP1PbPtLg9Zj44Myg5WPLuOGRQlhhy 0/hA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5HBupVq8sRNQ0/e+zQ08oh46OVYn1TgMtv+BrDWwTbo=; fh=uNn+EHo7TpLac2Z7ywCD1+CZm7o5lCNyN3nEbLn8uDQ=; b=B78vpotCYZmLMAvXPbN47nxtJrIu1FmyqbocuAiBNIGjP4IR+y04VWZLAVtJsWBw37 Y3sUtSBF2uZxDwGLvNfB6F5ftlF5r6Z7hszlUMj5rdW33O5oW6RjhWeQCODGLMSii2c+ tZ4GeMGbLTyQPVxbCb1lW6XpsyXTdch7e05YmxqLJpP7YW78xA9o9Bvu5QI/xWFnxa3W iXSlfRveVO00ntFMse3mh4gkxItKQkrqHB8BWFzvqy/BpEJt1OlMYAGyJrP1+BFJKUn9 XaNrH7k3jMl3y9ocdghcjYWLWfD4hsh6ZLaATqxk86GgmE+logdyNGD0mGEm9uy9tXNR 1bCQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Hkg4dnxw; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-133258-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133258-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id y184-20020a638ac1000000b005e42b5cb08bsi1486657pgd.110.2024.04.05.08.33.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 08:33:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-133258-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Hkg4dnxw; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-133258-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133258-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2D47D28842C for ; Fri, 5 Apr 2024 15:33:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0231F171063; Fri, 5 Apr 2024 15:32:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Hkg4dnxw" Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B90E816F917 for ; Fri, 5 Apr 2024 15:32:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712331164; cv=none; b=CvrCtSnwQ0WYKdeYMLpH7VQeqTG0PteBrdzEHnq/By3OQrSPibRSLkd6/M4qpmbV2Y69OcOZQKmLs3pzhS5aeJlfupAiXqoi6SBd7oJOlBOyWSe1cE1ICBubTjIkKyKNYjS/GDaTspCtwbCMfAktuff+apVIolj8OWca7h93Lv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712331164; c=relaxed/simple; bh=5eqSCNEjtJXpk/6DZsrwgHXPlVatBGh6RhudIFZY20o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UegV7LeGrZ0peRl5bqR1UPTKWh/sv6iRLPPRETkPteioKvr7vehLZLr85VTx0iVxz4WBaLMc0xPH0ByE4rJwcPRcfbr4YaVN5Og2P6RRQPqaURvNgIU//pz3Z+N69VXqq/o9Ngf8ufZ71HuGM7LHWEELOzpB0S/lTBFIM6qDtSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Hkg4dnxw; arc=none smtp.client-ip=209.85.166.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-369acec1740so4944905ab.0 for ; Fri, 05 Apr 2024 08:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712331162; x=1712935962; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5HBupVq8sRNQ0/e+zQ08oh46OVYn1TgMtv+BrDWwTbo=; b=Hkg4dnxwDMCrAOvN8HDCH3ljSRijHRknpzplWblGFJ2GMQw8meOFH92uNGUF4Urhh/ IJrei5Y7kRlaWhwVatmaDvwNhhkFrr446f4x49yWMfulOu0q8Rme0RhqjitoXM9QoSU4 kTrVFszhX5PLuaU4AVdGfsgF93skE6FSpxlMw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712331162; x=1712935962; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5HBupVq8sRNQ0/e+zQ08oh46OVYn1TgMtv+BrDWwTbo=; b=eM9ar+bS+GTfH/QvjBHvtvKXoIzYlB8GIHXoJEyDltEMEFz4QzAjAVF3lwzJkpM7yw qZ3kGS3uFA4mBRqdvTRHD6H56aTY5hwmqzLNkDKK7M7bgugxhfe4QcZqf4wrJb1XnxE9 b17DbX/h5WW70jXKQjBhMJm2FeHzWIZi3gqSoOt/2Axo2k2DA8a5+HYkaLgCGs/SMbOp cbKynZkRekM8kvJOMZpxy7T0Zab/mBt/97w2iS6Fh6G6OXJNNBWH0eYO8BfEkjEsMnhL ItXKx2SDjdRHHlcGC3MW4H4Z3SKMImW2KC+NsyFikgTyB/EOwb5XD321WYzmt+zJGtC7 qd8A== X-Forwarded-Encrypted: i=1; AJvYcCXX3B6om5vI2Eb7We+iAHj3Z6BJdvRDYdd09kir5EA3iCJykPBI3B3wnnUKphQDgrKyeZD4d8S+hjSs21JIdjeVR5wMLzilJO5SvAF6 X-Gm-Message-State: AOJu0YxnvjJvYIv2RHGncbKa24m9aqeLQSJX0p+8Z6rMSBZ+LB7DWTu0 aMSKUY4U4DKQcvJQVdx4ECOttIj20etBQj055gleTZJ5N8GRLgbnTSn4R6EAcA== X-Received: by 2002:a05:6e02:1d0e:b0:366:89b9:565c with SMTP id i14-20020a056e021d0e00b0036689b9565cmr2174618ila.15.1712331154523; Fri, 05 Apr 2024 08:32:34 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id h5-20020a631205000000b005cf450e91d2sm1274954pgl.52.2024.04.05.08.32.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 08:32:33 -0700 (PDT) Date: Fri, 5 Apr 2024 08:32:33 -0700 From: Kees Cook To: Muhammad Usama Anjum Cc: Eric Biederman , Shuah Khan , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH 1/2] selftests: Replace "Bail out" with "Error" Message-ID: <202404050832.35AE5A95@keescook> References: <20240405131748.1582646-1-usama.anjum@collabora.com> <20240405131748.1582646-2-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240405131748.1582646-2-usama.anjum@collabora.com> On Fri, Apr 05, 2024 at 06:17:47PM +0500, Muhammad Usama Anjum wrote: > "Bail out! " is not descriptive. It rather should be: "Failed: " and > then that added prefix doesn't need to be added everywhere. Usually in > the logs, we are searching for "Failed" or "Error" instead of "Bail > out". > > Suggested-by: Kees Cook > Signed-off-by: Muhammad Usama Anjum Reviewed-by: Kees Cook -- Kees Cook