Received-SPF: pass (google.com: domain of linux-kernel+bounces-133308-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Luck, Tony" <tony.luck@intel.com>
To: Yazen Ghannam <yazen.ghannam@amd.com>, "linux-edac@vger.kernel.org"
	<linux-edac@vger.kernel.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>, "Avadhut.Naik@amd.com"
	<Avadhut.Naik@amd.com>, "John.Allen@amd.com" <John.Allen@amd.com>
Subject: RE: [PATCH v2 16/16] EDAC/mce_amd: Add support for FRU Text in MCA
Thread-Topic: [PATCH v2 16/16] EDAC/mce_amd: Add support for FRU Text in MCA
Thread-Index: AQHahqLS7zyVgK2sqUK2yq9QKfANxrFZ2C2w
Date: Fri, 5 Apr 2024 16:06:36 +0000
Message-ID: <SJ1PR11MB6083683CAEA79F935BFA1B31FC032@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20240404151359.47970-1-yazen.ghannam@amd.com>
 <20240404151359.47970-17-yazen.ghannam@amd.com>
In-Reply-To: <20240404151359.47970-17-yazen.ghannam@amd.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MfD5p+ujzIwE+9VGJySOG4LYMI4maccolN88RsUnZKcUwArIMKUptChmQ5eV?=
 =?us-ascii?Q?jemIAXFqH5SE6uNOatB4t3VEdzW423kbZeJO5GPmX8R1ZPPYzN67Q6pku0D4?=
 =?us-ascii?Q?2nZLXXVFhrXo7Q4HlqFdPC4RbqqMDCkDNK3b/RePIFl8bwBuqYZ4eiT7KnjQ?=
 =?us-ascii?Q?dwhXi9JyKrjaNFFtmXYmnYntZsJTigDDE5FjwCshWfhQ8n1rdFYBQ6hqnxOS?=
 =?us-ascii?Q?fmIdP3lxPAHduBrcsS/wIwew0r5AL+PqT8ynBRlTjWob7phrVVmxSPRLsFKk?=
 =?us-ascii?Q?YlmxsBsZR6sgGKelo4sk35Qm5tChVrnyGexC5ul28VtQyLCp3VSvNl1NbI/d?=
 =?us-ascii?Q?9V0tXcJ0RVCw2uI0zzij0mcNT8nUWykeruqZDNia47T7jb9vJwAse3Fap2J/?=
 =?us-ascii?Q?WcXdoUg+N8N1Nj+VxWhqYFd6lZnkRPYNDSCxjFPYk8fGjD/Z2NjHrD+hSCxV?=
 =?us-ascii?Q?F/3egnpkvPeNLEObXWNFb9+GWCI7SxIz7p0IGbBmV6clXmCyG6mQBzki3gT0?=
 =?us-ascii?Q?+03YAAXyZO0aoh9jNFcCRvY6al/BX4uCM86FmRk2nsfeYOTz2EBnTf8iXzvy?=
 =?us-ascii?Q?3EbcWQHElDsgeOg98gj8NYNK+EM+2q/swxomFMEodhxslCOZqnZnilYM09ZQ?=
 =?us-ascii?Q?RFQ8C3Yj4QllvuVnssyrNKvEC7L59EtKuNpccT0pS6ErXFx9ZO97kMt2Bs8G?=
 =?us-ascii?Q?z1+3zXj8foSJBBMmKl8MrlZLHLWLkdAygFiOUlC5/6nRLLYKWoIcTIxObLLX?=
 =?us-ascii?Q?FjLgc1mcUAxmLjmtFpTKK/W/9A6HodvQbNcD9iRfF+LKbMpbSjLMABnjyMoF?=
 =?us-ascii?Q?qmnLjqcxPUQUw3/QANfhbf2iLBWscjeVz77XwrHuF7ckmndOwhTQA9u3AVgu?=
 =?us-ascii?Q?Di+B4NLIWCBAvpuo7EdqXrbOEhtnRFQI0k33hN4KPIPN3jaTEL8yVbGIX0jd?=
 =?us-ascii?Q?8G7cyZLtUhdmv8vEdKVGSTD2x0/VuehHus0rHpst+HpfUh4qRifGj0sPxnSQ?=
 =?us-ascii?Q?RXGYo4ozIX6m6CYCn5s/q54AelEApZyX6PbBcTSiTce8TI8YRau6sZ9KWvc4?=
 =?us-ascii?Q?Ny7zmGxRmCzQINOfHr7+2295KYRIHdlKwzg/y9uFMrgbagIKmfKlsRIiS8uM?=
 =?us-ascii?Q?VGnehbbYr3ZepSAQhYTIqZCw8mantTY8YT559xykyGlt/Pyw5JonvASmTIS7?=
 =?us-ascii?Q?KwFDT7jQygEx4rWsk3osN/Xn28L8Ij23/KyI6VMFPkjJHGjLZ/LAFkb5213r?=
 =?us-ascii?Q?dYIrfHMkQL0BXLwv8AEebE0zN5sxwa4hH3vN6o3MLozjWAcr5fQCz8kPa6Ce?=
 =?us-ascii?Q?sYnBeNIn8VKwMYUl2Fq86w+H2FlwBC4oVu4hQr9lG6MeMSc5DXY7CGwOVcXq?=
 =?us-ascii?Q?VDCA3xeBOgOCASos4e9lkLk2oJcAoHQMUE00Rz+z8hwoc0RAabA9pqTV3te9?=
 =?us-ascii?Q?xzt/2MP3Rh+GJYnCMR2R2GPBtHFnbSAGpjFMaV0KtXDjZl8UV7/2nyeGVoQ7?=
 =?us-ascii?Q?XsgZmd+HEXbT1dAAo3wg2qI3IE531sa4ug7GHKkxZzabPY2Qi2gmPqXhN0Yn?=
 =?us-ascii?Q?ATgSIHR7jBTqa1JouqWnOYT75hLNkiQ+PAe0AQTN?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1af00bd7-6760-46c5-eddd-08dc558a5eae
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2024 16:06:36.1655
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: b6jZhLNpYUjR9ECXkL7nJt0bvYcYMrC1pAMeBDQ8gKe+8Wyomf2N/U8RfpSpdeBAUtF7U+Nj6JmfjQLuUt5WBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB5990
X-OriginatorOrg: intel.com

> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/cor=
e.c
> index aa27729f7899..a4d09dda5fae 100644
> --- a/arch/x86/kernel/cpu/mce/core.c
> +++ b/arch/x86/kernel/cpu/mce/core.c
> @@ -207,6 +207,8 @@ static void __print_mce(struct mce_hw_err *err)
>                       pr_cont("SYND2 %llx ", err->vi.amd.synd2);
>               if (m->ipid)
>                       pr_cont("IPID %llx ", m->ipid);
> +             if (err->vi.amd.config)

This is in common code. If other vendors start adding their own stuff to th=
e
"vi" union you might incorrectly print this.  Add a vendor check before loo=
king
at values inside "m->vi".

> +                     pr_cont("CONFIG %llx ", err->vi.amd.config);
>       }
>
>       pr_cont("\n");