Received: by 2002:ab2:5182:0:b0:1f4:61d5:3ad4 with SMTP id x2csp45898lqi; Fri, 5 Apr 2024 09:19:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV/FYKqMF8bufrC6sMUWpYdZuFgVHrzQvAEvxkIVCWanmK08a3fYdLZKO0ePx7CQMX+6/wO2wglOsZgr0XwWztAhJSw5yjr/g81hCMzpw== X-Google-Smtp-Source: AGHT+IGdr5Sy+igKjZ3YX5SnvbR5vZN3SDdrsYhs1vuWJdqPVZgGsdn7cv8GOlNxuKzSSe18q3t4 X-Received: by 2002:a17:903:41d0:b0:1df:f859:91bd with SMTP id u16-20020a17090341d000b001dff85991bdmr2388290ple.4.1712333993852; Fri, 05 Apr 2024 09:19:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712333993; cv=pass; d=google.com; s=arc-20160816; b=PbE9wYBvuTk/ZBr0ESsgLL4GVdzPMPsBAOmIkqaiK6ltmmNildB50aJonLoX3djUmZ 9m7x+tjpAxJ5INfc0hytgEpaNF/yfM39mIctDpdgKx0mh8sTMTCSK7aBT8l6aJJobBJY 0v1ZKaNljOWn9PZHdAMNwX+miCVl/rO3Bu7RsNFgwlzGo4YWQHk52ScHB8GDkU04Q/Z9 fX4KDvHmU1gZdrJH+YG3tsKyzqcnwtYyfta78wQ++aC4YO3S/B7tUk8x1E6J5pc1RAVA exDaI+yyEBOPBjAYfRenFUm2BLwNfexo7yWVpbbE8OGOISGbdfm2tLLx7n/pCv5FCOgT gptw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=QRnuU2T0zeBP54NjTK724wHa45BiVHY1dZbI/4zG+So=; fh=lj7x8VR8e31zhzzeQT4+JA/lJTAKwWZj20o+G8Du45s=; b=Mz9iwePgYCFlWx3sFUfPXYqGsqgALKzDIiuPJasAUWK5b0mxvaJo6xeuHJaJOsRGK4 1ydrwv1MrHgXKqeT2/XJhToH2wRPX2hxm+5puE87TBxX5en0lseN0BRdzFsi3hMXEpq5 QbSDogo08JcbtEeXS/ieu9BLJO7nuPfNt6bywb/wEMqWXbKc8upRe9DcUeaz4TFADTsw fTtqUsDW/BokX/VZCpijzVJjGyzuVcr0eF8dztLWEAqnMeTaTNU8lKMYpj/Y92RLCxBZ yym9Bkc0sEeeK/3OBuMY81Z9OLvGMvcUF+Ufa+dfg62QKXQOQweF5z+zzl0PCWAz+Vvu jc0A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Sg//saIJ"; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-133318-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133318-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id x16-20020a170902ec9000b001e276acdafdsi1622799plg.330.2024.04.05.09.19.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 09:19:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-133318-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Sg//saIJ"; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-133318-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133318-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6865B289CBB for ; Fri, 5 Apr 2024 16:10:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7379717107F; Fri, 5 Apr 2024 16:10:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Sg//saIJ" Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AC1F16ABC3; Fri, 5 Apr 2024 16:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712333429; cv=none; b=sm230r/fDp1FOiPGkKSmR4LTrtOzWPmF+q94qIvADGQItJcVG/jxAQmy3cT04ZV22ctAds+WmfGOUk8dHgDAEKWoIR6Y1IDpZQ0GF+ZnVzcTG9hneAYoOLGItOX6mlSNKvStrhgDUYGMsL6TYhkDpSoTMZUiNLcCiOfN18MJ+QU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712333429; c=relaxed/simple; bh=XoXoslvHGhFAGNnZ/jtkQPOaFZnm6QeH3/hk2RonHU8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EWsLNrsw7SM1kp61YNrN5OL86aSX4TqmVMLI3dZwjS9QNSc7e81SX3lUE6Yn6oHR/9NtIjg0HZaQNXHHIEaf28hEfg0PFLbbI6y88bBR3shNWxyVt4XvlqYYAPHj4K0hNVZ4gROeczUrQOqT7AJuEwaUGqA0mebxbNDH55UdTWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Sg//saIJ; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a4715991c32so350484566b.1; Fri, 05 Apr 2024 09:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712333427; x=1712938227; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QRnuU2T0zeBP54NjTK724wHa45BiVHY1dZbI/4zG+So=; b=Sg//saIJpNTqinmB2+tRADa5wtqoQWxwHXuOdbWL3EWDePEIJ7ZFvGR6vsGgZaClur fKyD7NDPBMBtOTzrYeuF5NFBqqQBPAgZn4bP2vbrTOCFQqE3W+kDpeJ/ozakujp+tUMY /QiOBTP8jwnl0IXFBu+S7MCw5s5jrhaTSFF1TYd/8UGGG0buZLO9wFMGe1if7wWrBZZF RSPf3L8dJKbwbB95JQs4yhCORhbc02ZufaxRRLnchOq5YToG0ljoIa9aSW4JaooG/g1j 2U5C/h/9WTpy0j1GTtM3fKiWG/4Hqg56P0xbXAl7M1VrKS9QB8EgT1Ud+45xYYPOsd/E BMkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712333427; x=1712938227; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QRnuU2T0zeBP54NjTK724wHa45BiVHY1dZbI/4zG+So=; b=JCxtT4sHBAEEjJOdX3BZXdsenIA55CadPBCI6nqNBzCGctTlfjweCkasjptQjiXtGb P9csVQ1afQFuD5EuVyTr4kB1XY7RVXbryURU7/BIkhU60/4qx7pU2gGVO6bmH9qmnnzJ /Tj36A78ir43ngsEBTCFQvtDqjGI7JB3alJSXghkxi83yECCrwCWDpe8nWfe7AYXMV/w PeWlwPaYAF1xEofwKeMfTfzPhUxPTXLdrBLXZdli29LqjY7rekDnqTL+/4GSrCENPhxB qV5FgcvbsqPbwe40tnaIQivLd6j1xV1IWXvKbZW7bsmM2RDF3NpN7A/6YnMDh6rl+WOD YUIw== X-Forwarded-Encrypted: i=1; AJvYcCUCx7ZYlvT9+52kuHO45e53ROHVS7mO3GhH6fstSDJOr291ihd/Dg10zhxcTswhjh5wCh+3bGTtBAGDkL6A4h39zfKvb00k/b6G+sK4 X-Gm-Message-State: AOJu0YzBSjSz5y7O26HskrbKl30xuxiAyzxj950LQtDv2tRC+BCGULPy z4YajXg/cVqM8yy28fuqgiNLzi076Yfm8tzpZDnWSt2vp2K6KleE X-Received: by 2002:a17:907:ea8:b0:a4e:d43:dc4b with SMTP id ho40-20020a1709070ea800b00a4e0d43dc4bmr1835447ejc.58.1712333426307; Fri, 05 Apr 2024 09:10:26 -0700 (PDT) Received: from skbuf ([2a02:2f04:d700:2000::b2c]) by smtp.gmail.com with ESMTPSA id n2-20020a1709062bc200b00a517e505e3bsm979891ejg.204.2024.04.05.09.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 09:10:25 -0700 (PDT) Date: Fri, 5 Apr 2024 19:10:23 +0300 From: Vladimir Oltean To: Pawel Dembicki Cc: netdev@vger.kernel.org, Linus Walleij , Simon Horman , Florian Fainelli , Russell King , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Russell King , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v8 02/16] net: dsa: vsc73xx: convert to PHYLINK Message-ID: <20240405161023.qp2jl2a63z4vg3a2@skbuf> References: <20240403103734.3033398-1-paweldembicki@gmail.com> <20240403103734.3033398-3-paweldembicki@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403103734.3033398-3-paweldembicki@gmail.com> On Wed, Apr 03, 2024 at 12:37:18PM +0200, Pawel Dembicki wrote: > This patch replaces the adjust_link api with the phylink apis that provide > equivalent functionality. > > The remaining functionality from the adjust_link is now covered in the > phylink_mac_link_* and phylink_mac_config. > > Removes: > .adjust_link > Adds: > .phylink_mac_config > .phylink_mac_link_up > .phylink_mac_link_down > > Signed-off-by: Pawel Dembicki > Reviewed-by: Florian Fainelli > Reviewed-by: Linus Walleij > Reviewed-by: Russell King (Oracle) > --- I think you should split out the phylink patches from VLAN work, since these seem good to go.