Received-SPF: pass (google.com: domain of linux-kernel+bounces-133344-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 05 Apr 2024 16:34:58 +0000
To: Gergo Koteles <soyer@irl.hu>
From: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, Ike Panhc <ike.pan@canonical.com>, Hans de Goede <hdegoede@redhat.com>, =?utf-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>, Henrique de Moraes Holschuh <hmh@hmh.eng.br>, linux-acpi@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] ACPI: platform-profile: add platform_profile_cycle()
Message-ID: <g_07w0jkBp9IeComzpK26YHPB1QZNjN_amEZ2bTG6xrOMMltvaav0Rd9Oh4a0nlzPsW2guvvUHkNQrfzSdFGbJhKDB0SHgUJB4belZNrapI=@protonmail.com>
In-Reply-To: <fdc1b0b9f910753967b7a9b1996e4923cc63124f.1712282976.git.soyer@irl.hu>
References: <cover.1712282976.git.soyer@irl.hu> <fdc1b0b9f910753967b7a9b1996e4923cc63124f.1712282976.git.soyer@irl.hu>
Feedback-ID: 20568564:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi


2024. =C3=A1prilis 5., p=C3=A9ntek 5:05 keltez=C3=A9ssel, Gergo Koteles <so=
yer@irl.hu> =C3=ADrta:

> Some laptops have a key to switch platform profiles.
>=20
> Add a platform_profile_cycle() function to cycle between the enabled
> profiles.
>=20
> Signed-off-by: Gergo Koteles <soyer@irl.hu>
> ---
>  drivers/acpi/platform_profile.c  | 42 ++++++++++++++++++++++++++++++++
>  include/linux/platform_profile.h |  1 +
>  2 files changed, 43 insertions(+)
>=20
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_prof=
ile.c
> index d418462ab791..1579f380d469 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -136,6 +136,48 @@ void platform_profile_notify(void)
>  }
>  EXPORT_SYMBOL_GPL(platform_profile_notify);
>=20
> +int platform_profile_cycle(void)
> +{
> +=09enum platform_profile_option profile;
> +=09enum platform_profile_option next;
> +=09int err;
> +
> +=09err =3D mutex_lock_interruptible(&profile_lock);
> +=09if (err)
> +=09=09return err;
> +
> +=09if (!cur_profile) {
> +=09=09mutex_unlock(&profile_lock);
> +=09=09return -ENODEV;
> +=09}
> +
> +=09err =3D cur_profile->profile_get(cur_profile, &profile);
> +=09if (err) {
> +=09=09mutex_unlock(&profile_lock);
> +=09=09return err;
> +=09}
> +
> +=09next =3D ffs(cur_profile->choices[0] >> (profile + 1)) + profile;
> +
> +=09/* current profile is the highest, select the lowest */
> +=09if (next =3D=3D profile)
> +=09=09next =3D ffs(cur_profile->choices[0]) - 1;

I think you can use `find_next_bit()` or similar instead.


> +
> +=09if (WARN_ON((next < 0) || (next >=3D ARRAY_SIZE(profile_names)))) {
> +=09=09mutex_unlock(&profile_lock);
> +=09=09return -EINVAL;
> +=09}
> +
> +=09err =3D cur_profile->profile_set(cur_profile, next);
> +=09mutex_unlock(&profile_lock);
> +
> +=09if (!err)
> +=09=09sysfs_notify(acpi_kobj, NULL, "platform_profile");
> +
> +=09return err;
> +}
> +EXPORT_SYMBOL_GPL(platform_profile_cycle);
> +
>  int platform_profile_register(struct platform_profile_handler *pprof)
>  {
>  =09int err;
> diff --git a/include/linux/platform_profile.h b/include/linux/platform_pr=
ofile.h
> index e5cbb6841f3a..f5492ed413f3 100644
> --- a/include/linux/platform_profile.h
> +++ b/include/linux/platform_profile.h
> @@ -36,6 +36,7 @@ struct platform_profile_handler {
>=20
>  int platform_profile_register(struct platform_profile_handler *pprof);
>  int platform_profile_remove(void);
> +int platform_profile_cycle(void);
>  void platform_profile_notify(void);
>=20
>  #endif  /*_PLATFORM_PROFILE_H_*/
> --
> 2.44.0
>=20


Regards,
Barnab=C3=A1s P=C5=91cze