Received-SPF: pass (google.com: domain of linux-kernel+bounces-133346-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Zi Yan <ziy@nvidia.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, vbabka@suse.cz,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: set pageblock_order to HPAGE_PMD_ORDER in case with
 !CONFIG_HUGETLB_PAGE but THP enabled
Date: Fri, 05 Apr 2024 12:36:17 -0400
Message-ID: <5CECC6AA-F7AE-4C01-AB4B-83E95EE52A1D@nvidia.com>
In-Reply-To: <3d57d253070035bdc0f6d6e5681ce1ed0e1934f7.1712286863.git.baolin.wang@linux.alibaba.com>
References: <3d57d253070035bdc0f6d6e5681ce1ed0e1934f7.1712286863.git.baolin.wang@linux.alibaba.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_7BE47CE4-DE40-406A-BE69-7F54E585825E_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?u/GcaMdlt9gGFk4Q/l1V3jCgWO7VE4rda7Z1fvAqVZovms7jEGNelvChtkZG?=
 =?us-ascii?Q?vbmflgXOvClreiOpE9YvpLV32t8+EdZmdOR1/YchR+TjThrSP7JuKdxjfn5S?=
 =?us-ascii?Q?DA4SzX2Akxl3RJbTJSe3eu5f+XGePI8ZjVfFoPQC2a1EJmEn4WsFPJHz/dyF?=
 =?us-ascii?Q?BNIyMZB21Tu0tPDIV4Cedv7WdMEpHQy0V2PEK25p2PgZ7G2HtIaQFSpeaSjQ?=
 =?us-ascii?Q?ASBV9hrgML4P7Fka3+fu3ErxqfMcFoB9USSlSu0wmsjsMbOXa4GiDZPo+IA8?=
 =?us-ascii?Q?QsljpG9lb+5yEyeFdpUClrQXatLp6U1Gvp7nsI+yq4xNRAqeR96GBTsax4QT?=
 =?us-ascii?Q?SQ/iuPO13qoMapCtJoBXIl+yPU/cnYEECg1Kzzl3BuuEGv3MxUppdyd/WCXY?=
 =?us-ascii?Q?dYRAqW9CbIV53MRiCP0C+6pqK9szlpExHCNvf4Vspi9dq7Zyb0lnTi+eMSiC?=
 =?us-ascii?Q?5gnwBZoZ4RxleniiHNPNCZ3o4GKCL/EyF7C/zRBHlEoLp7YO++lhoDqqU1ss?=
 =?us-ascii?Q?n0JnYm+mGvQoTtQ9rvpILQck8BaH1o1rrWzGjReal3jjAl0LC3sIXGOembMD?=
 =?us-ascii?Q?VOK/8SbOnx9UUEB8uRw1P3P1pu+mi4NsjaONb+vRWoNoemtb2sj1koR+6zrd?=
 =?us-ascii?Q?nML5zSKOIwdTkFiWzEgShNY4g04qskluV7qsESGaHR73/Sv4Cd+Ui/+laSV0?=
 =?us-ascii?Q?GdPxi5RqFIPVOWE85bvaHTXwld+wmCRLZ+gQzDr4Vthd2joXg7Vy3E13o1n9?=
 =?us-ascii?Q?OxZ80kXNwzA/k5Wo3HdfFDEY/kwN3jLyZrA1bvBNgJoOffhWg7ZvUuTMungY?=
 =?us-ascii?Q?rCYSCEXlq/IbZKWt0+z1tdZ5n/BTQGfQTzxnrcjJSSQ++BtyvNAJ3YiIC4FP?=
 =?us-ascii?Q?9HZBdmC/ZEI+fg8UH2Wy3mX/ytDZJAAwpKcUfebn5ws3OKzVa0CXbf4+qI54?=
 =?us-ascii?Q?MtI81n+zJvFIekf0iBYP0QlJ8WuxLsdy+hPV9xto6qjUEmixKmvlgdo3nOPY?=
 =?us-ascii?Q?r/tuaEKXlEmK66hlhD+MY9Gg0ZP6/7kL17nOc7u9UibvPMpYUd/s6NGv6lh2?=
 =?us-ascii?Q?Gso4RMZrpfbQKKp/vhQmnyG4Rs1x3C0K5zI/XlhnIXLurP8EN5uatbfJ6FEK?=
 =?us-ascii?Q?ZCkEsvlfrpT/ePKrcK/xDM3nLago2ki/BnALt0e3a2PkSc6vPqevvUOC7Nvw?=
 =?us-ascii?Q?WSUE5T01rNkaLg82oOrG3LkcBFw8ab7/tCKmHKzDutrXcVOIw2nGU1sxqLtD?=
 =?us-ascii?Q?Ua6rczFxZl+ekKp5cc9/8DMV4RmheW8t9H7rFxguydhV6QQN2lKzjDJg3eYy?=
 =?us-ascii?Q?R2h3PPTXhBk6Ekkfp3Gk5rhI3B3lsXNkWougvQZIl1tdQloKtkWgsfLPIW26?=
 =?us-ascii?Q?HWhWNc9zokP9HA2Ye3NbwOsPP3aGeyJO32mItKBSs/7nFX0Jj5afXNYNdrEJ?=
 =?us-ascii?Q?zHupagNKQijBMxct/LxQt2FfFnNrvKg8mh+NOnadzV8r58G0WvypLVW8ReVD?=
 =?us-ascii?Q?KwhdG1HGAW2hPkcFaZZPhjMVjh14l2SOYh+coYaXw0N1qlkp92PPuojOGRCc?=
 =?us-ascii?Q?YCcXIEdsk1+n459zpcGAyjSerhtfCLP7wJ9eeiVp?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e0244a7-6cfe-475b-e269-08dc558e8564
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 16:36:19.2653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6fQhSp/Hyh57yytTGAcPGPunHIlP/An+THqPH4kJP5eMT3+Z1oJCx4sZwjC55Xdi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4207

--=_MailMate_7BE47CE4-DE40-406A-BE69-7F54E585825E_=
Content-Type: text/plain

On 5 Apr 2024, at 8:24, Baolin Wang wrote:

> As Vlastimil suggested in previous discussion[1], it doesn't make sense to set
> pageblock_order as MAX_PAGE_ORDER when hugetlbfs is not enabled and THP is enabled.
> Instead, it should be set to HPAGE_PMD_ORDER.
>
> [1] https://lore.kernel.org/all/76457ec5-d789-449b-b8ca-dcb6ceb12445@suse.cz/
> Suggested-by: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
>  include/linux/pageblock-flags.h | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_7BE47CE4-DE40-406A-BE69-7F54E585825E_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmYQKIEPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUjRMP/Rl/7EsCNGNLzfsD99qWtjv5eU3ss6CKddKR
AAnDvZbrBf+/dLwKALp+0NYk1oR2nFaHpDpaVAnWEpXfN6BkVKLKXy4f8hs0yCEQ
NkG7pNolMtFgbql2G1fLTXy6dz7dFj1oq+YSlIZM8lV1mFCUntKiF33zRNApw08B
Rla8V6BOo7blMMloANEKiPugnzqPRC/4PsG7ZXLVW2VKoZNKbF1uG/TbzLASyzLg
Ic8d3dBh1f0XYXJMHvDbm073wKydM4+xWUvkS2rh0ykR4ZbfQd5BaokUCRhtfKlT
U9KH27nknN/EGArq/t3eP/TTYAAUzX4uyjMgDxeFZeufk++WOedmTL9eoSI0y7Lc
wnbtO04u9GGcalF9uOazndJuuTzVl09TEZXDeQsm2x7oVDLMueF8nvz5nfc82JdM
zu66tTPOlF5ljwQJcKOEMcEKQuixoNW+OgtnWlgR4haiukuiIttroYABkjqGUw4B
brNSRkfSqNGdobEB63q1iIasZcVPeUp6ps9Yz41cUqvFKoeDNaEPo6BHkUM/V0FH
//I8dBCvu6nCFc4owCfk0mLR79Uf428PgIEn9PoTb3V3fTsww1+AZORcRwmWex8e
Wkh646kxgtIWq6ZHqNRPrUnzoF0oc1dre8ZfCnhyteWSqAmMTq406bo/aIgPQ1JX
M4okRhQu
=BicG
-----END PGP SIGNATURE-----

--=_MailMate_7BE47CE4-DE40-406A-BE69-7F54E585825E_=--