Received: by 2002:ab2:5182:0:b0:1f4:61d5:3ad4 with SMTP id x2csp57553lqi; Fri, 5 Apr 2024 09:37:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVzlcDV4nTJErjwrAjwTGio+xR4Zx+D3Dj5bhC7PQakZjAd9YQFbyJA7tcCwfViwkbVSGJIF5yv8+sbM573xhlFUGpuCDPzhvtXsjsKJA== X-Google-Smtp-Source: AGHT+IGOQxQV76i4A+L60bmrZzNM/jcSkEEc0w2xzInGhLOpLqDA8YiwwaRhw+ZKrtwe0DtrNr+9 X-Received: by 2002:a05:6102:161f:b0:479:de61:671c with SMTP id cu31-20020a056102161f00b00479de61671cmr1827407vsb.10.1712335060482; Fri, 05 Apr 2024 09:37:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712335060; cv=pass; d=google.com; s=arc-20160816; b=vhJ9anMkxPHOM1utAA164Yl81KbV8ARDahVM119dVEHUllV5qqeNzTh9mm6kc72NOp 18k7WjCjuBu1YfgYPwjOXFhvfxM7eLChVRyZSgm6R46s73TVD3OsAdZ4MIC6BnvrTHXV 6C8MuJqGh7weULKo4GEGC38i0TvnqQkOp4Hz2L6kkRWNylWrOnyqKyO4lNpzdMVs6oKQ 9C5q05xsOXZxMPB0G0FoEqLsSM18QAIc2z/TeV6ucreEhlzUF1zetWriTZskoIzM2+9o H53ZqKdJwsGkDNw4C6bRqLpOJbAgmVvoi2lhB2vbjGh+6GX0qxbYT7ybr/832bDpGEMs DBUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:date:references:in-reply-to:subject:cc:to :from:dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=9b6bVC5wHtPZFe+lwb/5F0DCN1XHlga3Dp0t9Yx4D6E=; fh=jy2FGn+Xv1CfERLPk8MxHVLnvStvcDZc4d0ZSpL+Vbg=; b=oHwp3CZ3UaavaLzGPSfcLruPbTTUYa05noL5laqXRYShSpxq+GRjmHS0PfeUQaAEF6 hHz+6gZX6CYjIhRocXI+SoiV+W1J2EwAVRuSorbRnoCBFCrKkTcNb+FQcJZLVTtsqfJ8 WNvB1zjbQfkDcDG7rfi3MNozf2vq3yCswFF1sUy8sz7qQsrx7hHG8BMTMoGG9rJk+s5w 5UL4BY+3sK2dqdHSyVGj9wSOxLiNa+b2/Yap7FuTTjErFhHooAVLtmpLHWxZeVXQiFrX rav1eYOSnzlRSVmf3GbX5od2k4Mu0WbPF0JJu7Yy1iep7H5I1cuftobDLBTsB5O2/SnM dwmw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="W/kTTz5a"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=riYSMPLf; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="W/kTTz5a"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-133347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133347-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id c10-20020a67f9ca000000b00479cf0112d5si357341vsq.253.2024.04.05.09.37.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 09:37:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-133347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="W/kTTz5a"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=riYSMPLf; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="W/kTTz5a"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-133347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133347-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 177ED1C22414 for ; Fri, 5 Apr 2024 16:37:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6197917108E; Fri, 5 Apr 2024 16:37:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="W/kTTz5a"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="riYSMPLf"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="W/kTTz5a"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="riYSMPLf" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 879BB50A98; Fri, 5 Apr 2024 16:37:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712335043; cv=none; b=UGiuKnTwTr35EEUIs3X3JS8E8fWvy73pFikU1dA4G02eyyqM+YlbfJmAQk5c+R0sMV6FifzxuMYdS4dCZy1Es+lm6e/zytJNXmBYyC+hHmsXgS7oy+fZ/PdXU1jmBCIxQEVKJxikzFJ9N7QTvRjPOm2FLu7NG1MqLZL9s8/uKiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712335043; c=relaxed/simple; bh=fbRV8D+g8Pp361DpMzV4d80YR3tASUfH1VeZ1zh+ic4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=OPbCvtKiX2OJCOsVHPGyULSOqp8v8LE+EaV3/Y3YtGb3QbMxs3JdB5My8EyHoyq7dANVgfRD/TnPaMltVIj1AODetOXZdgp27N3DNIKe2uWH62mT6GY1caZjAyjfoFcmZG9Bvl6IVQb/I/hZ8ZPmsGEW5WoHPfr2J0XkY6BoCE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=W/kTTz5a; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=riYSMPLf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=W/kTTz5a; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=riYSMPLf; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 417FD21ABB; Fri, 5 Apr 2024 16:37:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712335034; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9b6bVC5wHtPZFe+lwb/5F0DCN1XHlga3Dp0t9Yx4D6E=; b=W/kTTz5a0vf6qCbYd530AH8Ld3LbgdAvwrl0o7mQRnx++sK7lsXO8cVDnspMF3EtOiFfjQ WLF1c0RrSGfafJ5DK84sZcOqa+r0iDAUUK5jXG/Eaq1O4tbnQKhwe9egaX0XsVi2stjctD S8iinN3fNaL1br9CIG528txeUo1AqHk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712335034; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9b6bVC5wHtPZFe+lwb/5F0DCN1XHlga3Dp0t9Yx4D6E=; b=riYSMPLfFTJTaeD9N5m3QqVojPpAR+UoMNiolx4g/5uczTHbCJoXBox2cOjheK1LSwgJ/W pjdwpvQXkjkVpWAQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="W/kTTz5a"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=riYSMPLf DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712335034; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9b6bVC5wHtPZFe+lwb/5F0DCN1XHlga3Dp0t9Yx4D6E=; b=W/kTTz5a0vf6qCbYd530AH8Ld3LbgdAvwrl0o7mQRnx++sK7lsXO8cVDnspMF3EtOiFfjQ WLF1c0RrSGfafJ5DK84sZcOqa+r0iDAUUK5jXG/Eaq1O4tbnQKhwe9egaX0XsVi2stjctD S8iinN3fNaL1br9CIG528txeUo1AqHk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712335034; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9b6bVC5wHtPZFe+lwb/5F0DCN1XHlga3Dp0t9Yx4D6E=; b=riYSMPLfFTJTaeD9N5m3QqVojPpAR+UoMNiolx4g/5uczTHbCJoXBox2cOjheK1LSwgJ/W pjdwpvQXkjkVpWAQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id E3926139E8; Fri, 5 Apr 2024 16:37:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id dhBHK7koEGblbwAAn2gu4w (envelope-from ); Fri, 05 Apr 2024 16:37:13 +0000 From: Gabriel Krisman Bertazi To: Eugen Hristev Cc: Matthew Wilcox , tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, jaegeuk@kernel.org, chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, ebiggers@kernel.org Subject: Re: [PATCH v16 0/9] Cache insensitive cleanup for ext4/f2fs In-Reply-To: (Eugen Hristev's message of "Fri, 5 Apr 2024 16:02:15 +0300") References: <20240405121332.689228-1-eugen.hristev@collabora.com> Date: Fri, 05 Apr 2024 12:37:12 -0400 Message-ID: <87le5r3gw7.fsf@mailhost.krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Level: X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[15]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:98:from]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap2.dmz-prg2.suse.org:helo,imap2.dmz-prg2.suse.org:rdns,suse.de:dkim,wikipedia.org:url]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 417FD21ABB X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Score: -4.51 Eugen Hristev writes: > On 4/5/24 15:18, Matthew Wilcox wrote: >> On Fri, Apr 05, 2024 at 03:13:23PM +0300, Eugen Hristev wrote: >>> Hello, >>> >>> I am trying to respin the series here : >>> https://www.spinics.net/lists/linux-ext4/msg85081.html >> >> The subject here is "Cache insensitive cleanup for ext4/f2fs". >> Cache insensitive means something entirely different >> https://en.wikipedia.org/wiki/Cache-oblivious_algorithm >> >> I suspect you mean "Case insensitive". > > You are correct, I apologize for the typo. Heh. I completely missed it in the previous submissions. I guess we both just mentally auto-corrected. Since we are here, I think I contributed to the typo in the cover letter with the summary lines of patch 1 and 2. Differently from the rest of the series, these two are actually working on a "cache of casefolded strings". But their summary lines are misleading. Can you rename them to: [PATCH v16 1/9] ext4: Simplify the handling of cached casefolded names [PATCH v16 2/9] f2fs: Simplify the handling of cached casefolded names From a quick look, the series is looking good and the strict mode issue pointed in the last iteration seems fixed, though I didn't run it yet. I'll take a closer look later today and fully review. -- Gabriel Krisman Bertazi